Index: clang-tools-extra/trunk/clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp =================================================================== --- clang-tools-extra/trunk/clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp +++ clang-tools-extra/trunk/clang-tidy/misc/UnconventionalAssignOperatorCheck.cpp @@ -58,7 +58,10 @@ this); const auto IsBadReturnStatement = returnStmt(unless(has(ignoringParenImpCasts( - unaryOperator(hasOperatorName("*"), hasUnaryOperand(cxxThisExpr())))))); + anyOf(unaryOperator(hasOperatorName("*"), hasUnaryOperand(cxxThisExpr())), + cxxOperatorCallExpr(argumentCountIs(1), + callee(unresolvedLookupExpr()), + hasArgument(0, cxxThisExpr()))))))); const auto IsGoodAssign = cxxMethodDecl(IsAssign, HasGoodReturnType); Finder->addMatcher(returnStmt(IsBadReturnStatement, forFunction(IsGoodAssign)) Index: clang-tools-extra/trunk/test/clang-tidy/misc-unconventional-assign-operator.cpp =================================================================== --- clang-tools-extra/trunk/test/clang-tidy/misc-unconventional-assign-operator.cpp +++ clang-tools-extra/trunk/test/clang-tidy/misc-unconventional-assign-operator.cpp @@ -87,3 +87,25 @@ return n; } }; + +namespace pr31531 { +enum E { e }; +// This declaration makes the 'return *this' below have an unresolved operator +// in the class template, but not in an instantiation. +E operator*(E, E); + +template +struct UnresolvedOperator { + UnresolvedOperator &operator=(const UnresolvedOperator &) { return *this; } +}; + +UnresolvedOperator UnresolvedOperatorInt; + +template +struct Template { + Template &operator=(const Template &) { return this; } + // CHECK-MESSAGES: :[[@LINE-1]]:43: warning: operator=() should always return '*this' +}; + +Template TemplateInt; +}