Index: llvm/lib/LTO/LTO.cpp =================================================================== --- llvm/lib/LTO/LTO.cpp +++ llvm/lib/LTO/LTO.cpp @@ -446,6 +446,11 @@ if (GV.hasAppendingLinkage()) Keep.push_back(&GV); + DenseSet AliasedGlobals; + for (auto &GA : M.aliases()) + if (GlobalObject *GO = GA.getBaseObject()) + AliasedGlobals.insert(GO); + for (const InputFile::Symbol &Sym : make_range(InputFile::symbol_iterator(SymTab.symbols().begin(), SymTab, nullptr), @@ -471,13 +476,21 @@ GV->setLinkage(GlobalValue::WeakODRLinkage); break; } - } else if (GV->hasAvailableExternallyLinkage()) { - // We can link available_externally symbols even if they are - // non-prevailing. + } else if (isa(GV) && + (GV->hasLinkOnceODRLinkage() || GV->hasWeakODRLinkage() || + GV->hasAvailableExternallyLinkage()) && + !AliasedGlobals.count(cast(GV))) { + // Either of the above three types of linkage indicates that the + // chosen prevailing symbol will have the same semantics as this copy of + // the symbol, so we can link it with available_externally linkage. We + // only need to do this if the symbol is undefined. GlobalValue *CombinedGV = RegularLTO.CombinedModule->getNamedValue(GV->getName()); - if (!CombinedGV || CombinedGV->isDeclaration()) + if (!CombinedGV || CombinedGV->isDeclaration()) { Keep.push_back(GV); + GV->setLinkage(GlobalValue::AvailableExternallyLinkage); + cast(GV)->setComdat(nullptr); + } } } // Common resolution: collect the maximum size/alignment over all commons. Index: llvm/test/LTO/Resolution/X86/Inputs/link-availextern.ll =================================================================== --- /dev/null +++ llvm/test/LTO/Resolution/X86/Inputs/link-availextern.ll @@ -0,0 +1,11 @@ +target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" +target triple = "x86_64-unknown-linux-gnu" + +define linkonce_odr i32 @f() { + ret i32 2 +} + +define void @f3() { + %x = call i32 @f() + ret void +} Index: llvm/test/LTO/Resolution/X86/link-availextern.ll =================================================================== --- /dev/null +++ llvm/test/LTO/Resolution/X86/link-availextern.ll @@ -0,0 +1,30 @@ +; RUN: llvm-as %s -o %t1 +; RUN: llvm-as %S/Inputs/link-availextern.ll -o %t2 + +; RUN: llvm-lto2 -o %t3 %t1 -r %t1,f, -r %t1,f2,p -save-temps +; RUN: llvm-dis < %t3.0.0.preopt.bc -o - | FileCheck --check-prefix=NONPREVAILING %s + +; RUN: llvm-lto2 -o %t3 %t1 %t2 -r %t1,f, -r %t1,f2,p -r %t2,f, -r %t2,f3,p -save-temps +; RUN: llvm-dis < %t3.0.0.preopt.bc -o - | FileCheck --check-prefix=NONPREVAILING %s + +; RUN: llvm-lto2 -o %t3 %t1 %t2 -r %t1,f, -r %t1,f2,p -r %t2,f,p -r %t2,f3,p -save-temps +; RUN: llvm-dis < %t3.0.0.preopt.bc -o - | FileCheck --check-prefix=PREVAILING %s + +; RUN: llvm-lto2 -o %t3 %t2 %t1 -r %t1,f, -r %t1,f2,p -r %t2,f,p -r %t2,f3,p -save-temps +; RUN: llvm-dis < %t3.0.0.preopt.bc -o - | FileCheck --check-prefix=PREVAILING %s + +target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" +target triple = "x86_64-unknown-linux-gnu" + +; NONPREVAILING: define available_externally i32 @f() +; NONPREVAILING-NEXT: ret i32 1 +; PREVAILING: define weak_odr i32 @f() +; PREVAILING-NEXT: ret i32 2 +define linkonce_odr i32 @f() { + ret i32 1 +} + +define void @f2() { + %x = call i32 @f() + ret void +}