Index: llvm/lib/LTO/LTO.cpp =================================================================== --- llvm/lib/LTO/LTO.cpp +++ llvm/lib/LTO/LTO.cpp @@ -455,20 +455,52 @@ SymbolResolution Res = *ResI++; addSymbolToGlobalRes(Used, Sym, Res, 0); - if (Sym.getFlags() & object::BasicSymbolRef::SF_Undefined) - continue; - if (Res.Prevailing && Sym.isGV()) { + if (Sym.isGV()) { GlobalValue *GV = Sym.getGV(); - Keep.push_back(GV); - switch (GV->getLinkage()) { - default: - break; - case GlobalValue::LinkOnceAnyLinkage: - GV->setLinkage(GlobalValue::WeakAnyLinkage); - break; - case GlobalValue::LinkOnceODRLinkage: - GV->setLinkage(GlobalValue::WeakODRLinkage); - break; + GlobalValue *CombinedGV = + RegularLTO.CombinedModule->getNamedValue(GV->getName()); + if (Res.Prevailing) { + if (Sym.getFlags() & object::BasicSymbolRef::SF_Undefined) + continue; + Keep.push_back(GV); + switch (GV->getLinkage()) { + default: + break; + case GlobalValue::LinkOnceAnyLinkage: + GV->setLinkage(GlobalValue::WeakAnyLinkage); + break; + case GlobalValue::LinkOnceODRLinkage: + GV->setLinkage(GlobalValue::WeakODRLinkage); + break; + } + + if (CombinedGV && CombinedGV->hasAvailableExternallyLinkage()) { + // Remove the body of any available_externally copy of the symbol that + // we may have linked below. We can only ever get here with a + // GlobalObject because we only ever link non-prevailing symbols if + // they are GlobalObjects. + auto *CombinedGO = cast(CombinedGV); + CombinedGO->setLinkage(GlobalValue::ExternalLinkage); + CombinedGO->setComdat(nullptr); + CombinedGO->clearMetadata(); + if (auto *CombinedF = dyn_cast(CombinedGV)) + CombinedF->deleteBody(); + else + cast(CombinedGV)->setInitializer(nullptr); + } + } else if (isa(GV) && + (GV->hasLinkOnceODRLinkage() || GV->hasWeakODRLinkage() || + GV->hasAvailableExternallyLinkage())) { + // Either of the above three types of linkage indicates that the + // chosen prevailing symbol will have the same semantics as this copy of + // the symbol, so we can link it with available_externally linkage. We + // only need to do this if the symbol is undefined. + if (!CombinedGV || + (isa(CombinedGV) && CombinedGV->isDeclaration())) { + Keep.push_back(GV); + GV->setLinkage(GlobalValue::AvailableExternallyLinkage); + cast(GV)->setComdat(nullptr); + } } } // Common resolution: collect the maximum size/alignment over all commons. Index: llvm/test/LTO/Resolution/X86/Inputs/link-availextern.ll =================================================================== --- /dev/null +++ llvm/test/LTO/Resolution/X86/Inputs/link-availextern.ll @@ -0,0 +1,6 @@ +target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" +target triple = "x86_64-unknown-linux-gnu" + +define linkonce_odr i32 @f() { + ret i32 2 +} Index: llvm/test/LTO/Resolution/X86/link-availextern.ll =================================================================== --- /dev/null +++ llvm/test/LTO/Resolution/X86/link-availextern.ll @@ -0,0 +1,22 @@ +; RUN: llvm-as %s -o %t1 +; RUN: llvm-as %S/Inputs/link-availextern.ll -o %t2 + +; RUN: llvm-lto2 -o %t3 %t1 -r %t1,f, -save-temps +; RUN: llvm-dis < %t3.0.0.preopt.bc -o - | FileCheck --check-prefix=SINGLE %s + +; RUN: llvm-lto2 -o %t3 %t1 %t2 -r %t1,f, -r %t2,f,p -save-temps +; RUN: llvm-dis < %t3.0.0.preopt.bc -o - | FileCheck --check-prefix=BOTH %s + +; RUN: llvm-lto2 -o %t3 %t2 %t1 -r %t1,f, -r %t2,f,p -save-temps +; RUN: llvm-dis < %t3.0.0.preopt.bc -o - | FileCheck --check-prefix=BOTH %s + +target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" +target triple = "x86_64-unknown-linux-gnu" + +; SINGLE: define available_externally i32 @f() +; SINGLE-NEXT: ret i32 1 +; BOTH: define weak_odr i32 @f() +; BOTH-NEXT: ret i32 2 +define linkonce_odr i32 @f() { + ret i32 1 +}