Page MenuHomePhabricator

[MemorySSA] Fix invariant.group test and add new
ClosedPublic

Authored by Prazek on Jan 20 2017, 1:45 PM.

Details

Summary

This test had a bug: !llvm.invariant.group instead
of !invariant.group.

Also add some new test for future development.
All tests passes, when MSSA will support invariant.group
only the lines with FIXIT should be changed.

Event Timeline

Prazek created this revision.Jan 20 2017, 1:45 PM

So the idea is that we'll just use the dominating Def/Phi of the closest related barrier call for invariant group things?

Assuming yes, this LGTM. Thanks!

This revision is now accepted and ready to land.Jan 20 2017, 1:58 PM

So the idea is that we'll just use the dominating Def/Phi of the closest related barrier call for invariant group things?

Assuming yes, this LGTM. Thanks!

Yes, exactly. I am working on that now

This revision was automatically updated to reflect the committed changes.