Index: include/llvm/Object/SymbolicFile.h =================================================================== --- include/llvm/Object/SymbolicFile.h +++ include/llvm/Object/SymbolicFile.h @@ -16,6 +16,7 @@ #include "llvm/Object/Binary.h" #include "llvm/Support/Format.h" +#include #include namespace llvm { @@ -31,9 +32,10 @@ DataRefImpl() { std::memset(this, 0, sizeof(DataRefImpl)); } }; + template OStream& operator<<(OStream &OS, const DataRefImpl &D) { - OS << "(" << format("0x%x8", D.p) << " (" << format("0x%x8", D.d.a) << ", " << format("0x%x8", D.d.b) << "))"; + OS << "(" << format("0x%08x" PRIxPTR, D.p) << " (" << format("0x%08x", D.d.a) << ", " << format("0x%08x", D.d.b) << "))"; return OS; } Index: unittests/Object/CMakeLists.txt =================================================================== --- unittests/Object/CMakeLists.txt +++ unittests/Object/CMakeLists.txt @@ -4,5 +4,6 @@ add_llvm_unittest(ObjectTests SymbolSizeTest.cpp + SymbolicFileTest.cpp ) Index: unittests/Object/SymbolicFileTest.cpp =================================================================== --- unittests/Object/SymbolicFileTest.cpp +++ unittests/Object/SymbolicFileTest.cpp @@ -0,0 +1,34 @@ +//===- SymbolicFileTest.cpp - Tests for SymbolicFile.cpp ------------------===// +// +// The LLVM Compiler Infrastructure +// +// This file is distributed under the University of Illinois Open Source +// License. See LICENSE.TXT for details. +// +//===----------------------------------------------------------------------===// + +#include "llvm/Object/SymbolicFile.h" +#include "llvm/Support/raw_ostream.h" +#include "gtest/gtest.h" +#include + +TEST(Object, DataRefImplOstream) { + std::string s; + llvm::raw_string_ostream OS(s); + llvm::object::DataRefImpl Data; + Data.d.a = 0xeeee0000; + Data.d.b = 0x0000ffff; + + static_assert(sizeof Data.p == sizeof(uint64_t) || + sizeof Data.p == sizeof(uint32_t), + "Test expected pointer type to be 32 or 64-bit."); + + char const *Expected = sizeof Data.p == sizeof(uint64_t) + ? "(0xffffeeee0000 (0xeeee0000, 0x0000ffff))" + : "(0xeeee0000 (0xeeee0000, 0x0000ffff))"; + + OS << Data; + OS.flush(); + + EXPECT_EQ(Expected, s); +}