This is an archive of the discontinued LLVM Phabricator instance.

Differential D28632

[libFuzzer] Remove optimization flags for tests on Windows.
ClosedPublic

Authored by mpividori on Jan 12 2017, 5:47 PM.

Details

Reviewers
kcc
zturner
Commits
rG403007e3c11f: [libFuzzer] Remove optimization flags for tests.
rL292737: [libFuzzer] Remove optimization flags for tests.
Summary

I also remove the optimizations for Windows. I realize this was the reason of the failure in some tests.

Diff Detail

Repository
rL LLVM

Event Timeline

mpividori updated this revision to Diff 84204.Jan 12 2017, 5:47 PM
mpividori retitled this revision from to [libFuzzer] Remove optimization flags for tests on Windows..
mpividori updated this object.
mpividori added reviewers: kcc, zturner.
mpividori set the repository for this revision to rL LLVM.
mpividori added a subscriber: llvm-commits.
Herald added a subscriber: mgorny. · View Herald TranscriptJan 12 2017, 5:47 PM
mpividori updated this revision to Diff 84311.Jan 13 2017, 8:18 AM
mpividori removed rL LLVM as the repository for this revision.
kcc accepted this revision.Jan 17 2017, 12:58 PM

LGTM

This revision is now accepted and ready to land.Jan 17 2017, 12:58 PM
Closed by commit rL292737: [libFuzzer] Remove optimization flags for tests. (authored by mpividori). · Explain WhyJan 21 2017, 5:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
Fuzzer/
test/
12 lines

Diff 85257

llvm/trunk/lib/Fuzzer/test/CMakeLists.txt

# Build all these tests with -O0, otherwise optimizations may merge some # Build all these tests with -O0, otherwise optimizations may merge some
# basic blocks and we'll fail to discover the targets. # basic blocks and we'll fail to discover the targets.
# We change the flags for every build type because we might be doing # We change the flags for every build type because we might be doing
# a multi-configuration build (e.g. Xcode) where CMAKE_BUILD_TYPE doesn't # a multi-configuration build (e.g. Xcode) where CMAKE_BUILD_TYPE doesn't
# mean anything. # mean anything.
set(variables_to_filter set(variables_to_filter
CMAKE_CXX_FLAGS_RELEASE CMAKE_CXX_FLAGS_RELEASE
CMAKE_CXX_FLAGS_DEBUG CMAKE_CXX_FLAGS_DEBUG
CMAKE_CXX_FLAGS_RELWITHDEBINFO CMAKE_CXX_FLAGS_RELWITHDEBINFO
CMAKE_CXX_FLAGS_MINSIZEREL CMAKE_CXX_FLAGS_MINSIZEREL
LIBFUZZER_FLAGS_BASE LIBFUZZER_FLAGS_BASE
) )
foreach (VARNAME ${variables_to_filter}) foreach (VARNAME ${variables_to_filter})
string(REPLACE " " ";" BUILD_FLAGS_AS_LIST "${${VARNAME}}") string(REGEX REPLACE "([-/]O)[123s]" "\\10" ${VARNAME} "${${VARNAME}}")
set(new_flags "")
foreach (flag ${BUILD_FLAGS_AS_LIST})
# NOTE: Use of XX here is to avoid a CMake warning due to CMP0054
if (NOT ("XX${flag}" MATCHES "XX-O[0123s]"))
set(new_flags "${new_flags} ${flag}")
else()
set(new_flags "${new_flags} -O0")
endif()
endforeach()
set(${VARNAME} "${new_flags}")
endforeach() endforeach()
# Enable the coverage instrumentation (it is disabled for the Fuzzer lib). # Enable the coverage instrumentation (it is disabled for the Fuzzer lib).
set(CMAKE_CXX_FLAGS "${LIBFUZZER_FLAGS_BASE} -fsanitize-coverage=trace-pc-guard,indirect-calls,trace-cmp,trace-div,trace-gep -gline-tables-only") set(CMAKE_CXX_FLAGS "${LIBFUZZER_FLAGS_BASE} -fsanitize-coverage=trace-pc-guard,indirect-calls,trace-cmp,trace-div,trace-gep -gline-tables-only")
if(MSVC) if(MSVC)
# In order to use the sanitizers in Windows, we need to link against many # In order to use the sanitizers in Windows, we need to link against many
# runtime libraries which will depend on the target being created # runtime libraries which will depend on the target being created
▲ Show 20 Lines • Show All 208 Lines • Show Last 20 Lines