Index: include/llvm/Analysis/ValueTracking.h =================================================================== --- include/llvm/Analysis/ValueTracking.h +++ include/llvm/Analysis/ValueTracking.h @@ -86,8 +86,10 @@ /// Return true if the given value is known to be non-zero when defined. For /// vectors, return true if every element is known to be non-zero when - /// defined. Supports values with integer or pointer type and vectors of - /// integers. + /// defined. For pointers, if the context instruction and dominator tree are + /// specified, perform context-sensitive analysis and return true if the + /// pointer couldn't possibly be null at the specified instruction. + /// Supports values with integer or pointer type and vectors of integers. bool isKnownNonZero(const Value *V, const DataLayout &DL, unsigned Depth = 0, AssumptionCache *AC = nullptr, const Instruction *CxtI = nullptr, Index: lib/Analysis/ValueTracking.cpp =================================================================== --- lib/Analysis/ValueTracking.cpp +++ lib/Analysis/ValueTracking.cpp @@ -1785,10 +1785,12 @@ return true; } -/// Return true if the given value is known to be non-zero when defined. -/// For vectors return true if every element is known to be non-zero when -/// defined. Supports values with integer or pointer type and vectors of -/// integers. +/// Return true if the given value is known to be non-zero when defined. For +/// vectors, return true if every element is known to be non-zero when +/// defined. For pointers, if the context instruction and dominator tree are +/// specified, perform context-sensitive analysis and return true if the +/// pointer couldn't possibly be null at the specified instruction. +/// Supports values with integer or pointer type and vectors of integers. bool isKnownNonZero(const Value *V, unsigned Depth, const Query &Q) { if (auto *C = dyn_cast(V)) { if (C->isNullValue()) @@ -1831,7 +1833,7 @@ // Check for pointer simplifications. if (V->getType()->isPointerTy()) { - if (isKnownNonNull(V)) + if (isKnownNonNullAt(V, Q.CxtI, Q.DT)) return true; if (const GEPOperator *GEP = dyn_cast(V)) if (isGEPKnownNonNull(GEP, Depth, Q)) @@ -3377,6 +3379,16 @@ if (NumUsesExplored >= DomConditionsMaxUses) break; NumUsesExplored++; + + // If the value is used as an argument to a function call, then argument + // attributes may provide an answer about null-ness. + if (auto *Call = dyn_cast(U)) + if (auto *CalledFunc = Call->getCalledFunction()) + for (Argument &Arg : CalledFunc->args()) + if (Call->getArgOperand(Arg.getArgNo()) == V && + Arg.hasNonNullAttr() && DT->dominates(Call, CtxI)) + return true; + // Consider only compare instructions uniquely controlling a branch CmpInst::Predicate Pred; if (!match(const_cast(U), Index: test/Analysis/ValueTracking/known-nonnull-at.ll =================================================================== --- test/Analysis/ValueTracking/known-nonnull-at.ll +++ test/Analysis/ValueTracking/known-nonnull-at.ll @@ -8,8 +8,7 @@ define i1 @caller1(i8* %x, i8* %y) { ; CHECK-LABEL: @caller1( ; CHECK-NEXT: call void @bar(i8* %x, i8* %y) -; CHECK-NEXT: [[NULL_CHECK:%.*]] = icmp eq i8* %y, null -; CHECK-NEXT: ret i1 [[NULL_CHECK]] +; CHECK-NEXT: ret i1 false ; call void @bar(i8* %x, i8* %y) %null_check = icmp eq i8* %y, null @@ -34,24 +33,44 @@ define i1 @caller3(i8* %x, i8* %y) { ; CHECK-LABEL: @caller3( ; CHECK-NEXT: call void @bar(i8* %x, i8* %y) -; CHECK-NEXT: [[NULL_CHECK:%.*]] = icmp ne i8* %y, null -; CHECK-NEXT: ret i1 [[NULL_CHECK]] +; CHECK-NEXT: ret i1 true ; call void @bar(i8* %x, i8* %y) %null_check = icmp ne i8* %y, null ret i1 %null_check } -; Don't know anything about 'y'. +; FIXME: The call is guaranteed to execute, so 'y' must be nonnull throughout. define i1 @caller4(i8* %x, i8* %y) { ; CHECK-LABEL: @caller4( -; CHECK-NEXT: call void @bar(i8* %y, i8* %x) ; CHECK-NEXT: [[NULL_CHECK:%.*]] = icmp ne i8* %y, null +; CHECK-NEXT: call void @bar(i8* %x, i8* %y) ; CHECK-NEXT: ret i1 [[NULL_CHECK]] ; - call void @bar(i8* %y, i8* %x) %null_check = icmp ne i8* %y, null + call void @bar(i8* %x, i8* %y) + ret i1 %null_check +} + +; The call to bar() does not dominate the null check, so no change. + +define i1 @caller5(i8* %x, i8* %y) { +; CHECK-LABEL: @caller5( +; CHECK-NEXT: [[NULL_CHECK:%.*]] = icmp eq i8* %y, null +; CHECK-NEXT: br i1 [[NULL_CHECK]], label %t, label %f +; CHECK: t: +; CHECK-NEXT: ret i1 [[NULL_CHECK]] +; CHECK: f: +; CHECK-NEXT: call void @bar(i8* %x, i8* %y) +; CHECK-NEXT: ret i1 [[NULL_CHECK]] +; + %null_check = icmp eq i8* %y, null + br i1 %null_check, label %t, label %f +t: + ret i1 %null_check +f: + call void @bar(i8* %x, i8* %y) ret i1 %null_check } Index: test/Transforms/InstCombine/call_nonnull_arg.ll =================================================================== --- test/Transforms/InstCombine/call_nonnull_arg.ll +++ test/Transforms/InstCombine/call_nonnull_arg.ll @@ -37,7 +37,7 @@ define void @deduce_nonnull_from_another_call(i8* %a, i8* %b) { ; CHECK-LABEL: @deduce_nonnull_from_another_call( ; CHECK-NEXT: call void @bar(i8* %a, i8* %b) -; CHECK-NEXT: call void @baz(i8* %b, i8* %b) +; CHECK-NEXT: call void @baz(i8* nonnull %b, i8* nonnull %b) ; CHECK-NEXT: ret void ; call void @bar(i8* %a, i8* %b)