Index: llvm/trunk/lib/Target/AVR/AVRExpandPseudoInsts.cpp =================================================================== --- llvm/trunk/lib/Target/AVR/AVRExpandPseudoInsts.cpp +++ llvm/trunk/lib/Target/AVR/AVRExpandPseudoInsts.cpp @@ -203,6 +203,10 @@ bool AVRExpandPseudo:: isLogicImmOpRedundant(unsigned Op, unsigned ImmVal) const { + // ANDI Rd, 0xff is redundant. + if (Op == AVR::ANDIRdK && ImmVal == 0xff) + return true; + // ORI Rd, 0x0 is redundant. if (Op == AVR::ORIRdK && ImmVal == 0x0) return true; Index: llvm/trunk/test/CodeGen/AVR/PR31345.ll =================================================================== --- llvm/trunk/test/CodeGen/AVR/PR31345.ll +++ llvm/trunk/test/CodeGen/AVR/PR31345.ll @@ -0,0 +1,51 @@ +; RUN: llc < %s -march=avr | FileCheck %s + +; Unit test for: PR 31345 + +define i16 @and16_reg_imm_0xff00(i16 %a) { +; CHECK-LABEL: and16_reg_imm_0xff00 +; CHECK: andi {{r[0-9]+}}, 0 +; CHECK-NOT: andi {{r[0-9]+}}, 255 + %result = and i16 %a, 65280 + ret i16 %result +} + +define i16 @and16_reg_imm_0xffb3(i16 %a) { +; CHECK-LABEL: and16_reg_imm_0xffb3 +; CHECK: andi {{r[0-9]+}}, 179 +; CHECK-NOT: andi {{r[0-9]+}}, 255 + %result = and i16 %a, 65459 + ret i16 %result +} + +define i16 @and16_reg_imm_0x00ff(i16 %a) { +; CHECK-LABEL: and16_reg_imm_0x00ff +; CHECK-NOT: andi {{r[0-9]+}}, 255 +; CHECK: andi {{r[0-9]+}}, 0 + %result = and i16 %a, 255 + ret i16 %result +} + +define i16 @and16_reg_imm_0xb3ff(i16 %a) { +; CHECK-LABEL: and16_reg_imm_0xb3ff +; CHECK-NOT: andi {{r[0-9]+}}, 255 +; CHECK: andi {{r[0-9]+}}, 179 + %result = and i16 %a, 46079 + ret i16 %result +} + +define i16 @and16_reg_imm_0xffff(i16 %a) { +; CHECK-LABEL: and16_reg_imm_0xffff +; CHECK-NOT: andi {{r[0-9]+}}, 255 +; CHECK-NOT: andi {{r[0-9]+}}, 255 + %result = and i16 %a, 65535 + ret i16 %result +} + +define i16 @and16_reg_imm_0xabcd(i16 %a) { +; CHECK-LABEL: and16_reg_imm_0xabcd +; CHECK: andi {{r[0-9]+}}, 205 +; CHECK: andi {{r[0-9]+}}, 171 + %result = and i16 %a, 43981 + ret i16 %result +} Index: llvm/trunk/test/CodeGen/AVR/and.ll =================================================================== --- llvm/trunk/test/CodeGen/AVR/and.ll +++ llvm/trunk/test/CodeGen/AVR/and.ll @@ -67,7 +67,8 @@ define i64 @and64_reg_imm(i64 %a) { ; CHECK-LABEL: and64_reg_imm: ; CHECK: andi r18, 253 -; CHECK: andi r19, 255 +; Per PR 31345, we optimize away ANDI Rd, 0xff +; CHECK-NOT: andi r19, 255 ; CHECK: andi r20, 155 ; CHECK: andi r21, 88 ; CHECK: andi r22, 76