Index: clang-tools-extra/trunk/include-fixer/find-all-symbols/FindAllSymbols.cpp =================================================================== --- clang-tools-extra/trunk/include-fixer/find-all-symbols/FindAllSymbols.cpp +++ clang-tools-extra/trunk/include-fixer/find-all-symbols/FindAllSymbols.cpp @@ -32,6 +32,18 @@ return false; } +AST_POLYMORPHIC_MATCHER(isFullySpecialized, + AST_POLYMORPHIC_SUPPORTED_TYPES(FunctionDecl, VarDecl, + CXXRecordDecl)) { + if (Node.getTemplateSpecializationKind() == TSK_ExplicitSpecialization) { + bool IsPartialSpecialization = + llvm::isa(Node) || + llvm::isa(Node); + return !IsPartialSpecialization; + } + return false; +} + std::vector GetContexts(const NamedDecl *ND) { std::vector Contexts; for (const auto *Context = ND->getDeclContext(); Context; @@ -126,8 +138,7 @@ auto CCMatcher = allOf(HasNSOrTUCtxMatcher, unless(IsInSpecialization), unless(ast_matchers::isTemplateInstantiation()), - unless(isInstantiated()), unless(classTemplateSpecializationDecl()), - unless(isExplicitTemplateSpecialization())); + unless(isInstantiated()), unless(isFullySpecialized())); // Matchers specific to code in extern "C" {...}. auto ExternCMatcher = hasDeclContext(linkageSpecDecl()); @@ -156,8 +167,7 @@ // Matchers for C++ record declarations. auto CxxRecordDecl = - cxxRecordDecl(CommonFilter, CCMatcher, isDefinition(), - unless(isExplicitTemplateSpecialization())); + cxxRecordDecl(CommonFilter, CCMatcher, isDefinition()); MatchFinder->addMatcher(CxxRecordDecl.bind("decl"), this); // Matchers for function declarations. Index: clang-tools-extra/trunk/unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp =================================================================== --- clang-tools-extra/trunk/unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp +++ clang-tools-extra/trunk/unittests/include-fixer/find-all-symbols/FindAllSymbolsTests.cpp @@ -229,6 +229,28 @@ EXPECT_TRUE(hasSymbol(Symbol)); } +TEST_F(FindAllSymbolsTest, DontIgnoreTemplatePartialSpecialization) { + static const char Code[] = R"( + template class Class; // undefined + template + class Class { + }; + + template void f() {}; + template<> void f() {}; + )"; + runFindAllSymbols(Code); + SymbolInfo Symbol = + SymbolInfo("Class", SymbolInfo::SymbolKind::Class, HeaderName, 4, {}); + EXPECT_TRUE(hasSymbol(Symbol)); + Symbol = + SymbolInfo("f", SymbolInfo::SymbolKind::Function, HeaderName, 7, {}); + EXPECT_TRUE(hasSymbol(Symbol)); + Symbol = + SymbolInfo("f", SymbolInfo::SymbolKind::Function, HeaderName, 8, {}); + EXPECT_FALSE(hasSymbol(Symbol)); +} + TEST_F(FindAllSymbolsTest, FunctionSymbols) { static const char Code[] = R"( namespace na {