Index: llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp =================================================================== --- llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp +++ llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp @@ -48,6 +48,7 @@ #include "llvm/IR/GlobalVariable.h" #include "llvm/IR/GVMaterializer.h" #include "llvm/IR/InlineAsm.h" +#include "llvm/IR/InstIterator.h" #include "llvm/IR/InstrTypes.h" #include "llvm/IR/Instruction.h" #include "llvm/IR/Instructions.h" @@ -60,6 +61,7 @@ #include "llvm/IR/TrackingMDRef.h" #include "llvm/IR/Type.h" #include "llvm/IR/ValueHandle.h" +#include "llvm/IR/Verifier.h" #include "llvm/Support/AtomicOrdering.h" #include "llvm/Support/Casting.h" #include "llvm/Support/CommandLine.h" @@ -148,6 +150,16 @@ return false; } +// Strip all the TBAA attachment for the module. +void stripTBAA(Module *M) { + for (auto &F : *M) { + if (F.isMaterializable()) + continue; + for (auto &I : instructions(F)) + I.setMetadata(LLVMContext::MD_tbaa, nullptr); + } +} + /// Read the "IDENTIFICATION_BLOCK_ID" block, do some basic enforcement on the /// "epoch" encoded in the bitcode, and return the producer name if any. Expected readIdentificationBlock(BitstreamCursor &Stream) { @@ -460,6 +472,7 @@ bool WillMaterializeAllForwardRefs = false; bool StripDebugInfo = false; + TBAAVerifier TBAAVerifyHelper; std::vector BundleTags; @@ -4449,6 +4462,17 @@ if (DISubprogram *SP = MDLoader->lookupSubprogramForFunction(F)) F->setSubprogram(SP); + // Check if the TBAA Metadata are valid, otherwise we will need to strip them. + if (!MDLoader->isStrippingTBAA()) { + for (auto &I : instructions(F)) { + MDNode *TBAA = I.getMetadata(LLVMContext::MD_tbaa); + if (!TBAA || TBAAVerifyHelper.visitTBAAMetadata(I, TBAA)) + continue; + MDLoader->setStripTBAA(true); + stripTBAA(F->getParent()); + } + } + // Bring in any functions that this function forward-referenced via // blockaddresses. return materializeForwardReferencedFunctions(); Index: llvm/trunk/lib/Bitcode/Reader/MetadataLoader.h =================================================================== --- llvm/trunk/lib/Bitcode/Reader/MetadataLoader.h +++ llvm/trunk/lib/Bitcode/Reader/MetadataLoader.h @@ -52,6 +52,12 @@ // Parse a function metadata block Error parseFunctionMetadata() { return parseMetadata(false); } + /// Set the mode to strip TBAA metadata on load. + void setStripTBAA(bool StripTBAA = true); + + /// Return true if the Loader is stripping TBAA metadata. + bool isStrippingTBAA(); + // Return true there are remaining unresolved forward references. bool hasFwdRefs() const; Index: llvm/trunk/lib/Bitcode/Reader/MetadataLoader.cpp =================================================================== --- llvm/trunk/lib/Bitcode/Reader/MetadataLoader.cpp +++ llvm/trunk/lib/Bitcode/Reader/MetadataLoader.cpp @@ -382,6 +382,7 @@ // Map the bitcode's custom MDKind ID to the Module's MDKind ID. DenseMap MDKindMap; + bool StripTBAA = false; bool HasSeenOldLoopTags = false; Error parseMetadataStrings(ArrayRef Record, StringRef Blob, @@ -420,6 +421,9 @@ Error parseMetadataKinds(); + void setStripTBAA(bool Value) { StripTBAA = Value; } + bool isStrippingTBAA() { return StripTBAA; } + unsigned size() const { return MetadataList.size(); } void shrinkTo(unsigned N) { MetadataList.shrinkTo(N); } }; @@ -1208,6 +1212,9 @@ DenseMap::iterator I = MDKindMap.find(Kind); if (I == MDKindMap.end()) return error("Invalid ID"); + if (I->second == LLVMContext::MD_tbaa && StripTBAA) + continue; + Metadata *Node = MetadataList.getMetadataFwdRef(Record[i + 1]); if (isa(Node)) // Drop the attachment. This used to be legal, but there's no @@ -1327,5 +1334,11 @@ return Pimpl->parseMetadataKinds(); } +void MetadataLoader::setStripTBAA(bool StripTBAA) { + return Pimpl->setStripTBAA(StripTBAA); +} + +bool MetadataLoader::isStrippingTBAA() { return Pimpl->isStrippingTBAA(); } + unsigned MetadataLoader::size() const { return Pimpl->size(); } void MetadataLoader::shrinkTo(unsigned N) { return Pimpl->shrinkTo(N); } Index: llvm/trunk/test/Verifier/tbaa.ll =================================================================== --- llvm/trunk/test/Verifier/tbaa.ll +++ llvm/trunk/test/Verifier/tbaa.ll @@ -1,5 +1,9 @@ ; RUN: not llvm-as < %s 2>&1 | FileCheck %s +; RUN: llvm-as -disable-verify < %s 2>&1 | opt -verify -S | FileCheck %s --check-prefix=STRIP +; STRIP-NOT: tbaa +; STRIP: @f_0 +; STRIP: Do no strip this define void @f_0(i32* %ptr) { ; This part checks for the easy syntactic verifier rules. @@ -34,10 +38,10 @@ store i32 4, i32* %ptr, !tbaa !{!3, null, !"40", i64 0} store i32 5, i32* %ptr, !tbaa !{!3, !3, !"40", i64 0} store i32 6, i32* %ptr, !tbaa !{!3, !2, i32 40, i64 0} - store i32 7, i32* %ptr, !tbaa !{!3, !12, i32 40, i64 0} + store i32 7, i32* %ptr, !tbaa !{!3, !12, i32 40, i64 0}, !metadata !42 ret void } - +!42 = !{!"Do no strip this!"} define void @f_1(i32* %ptr) { ; This part checks for more semantic verifier rules.