Index: cfe/trunk/lib/Format/Format.cpp =================================================================== --- cfe/trunk/lib/Format/Format.cpp +++ cfe/trunk/lib/Format/Format.cpp @@ -844,9 +844,10 @@ Env.getSourceManager(), Start, Length, ReplacementText)); // FIXME: handle error. For now, print error message and skip the // replacement for release version. - if (Err) + if (Err) { llvm::errs() << llvm::toString(std::move(Err)) << "\n"; - assert(!Err); + assert(false); + } }; Replace(Start, 1, IsSingle ? "'" : "\""); Replace(FormatTok->Tok.getEndLoc().getLocWithOffset(-1), 1, @@ -1193,9 +1194,10 @@ Fixes.add(tooling::Replacement(Env.getSourceManager(), SR, "")); // FIXME: better error handling. for now just print error message and skip // for the release version. - if (Err) + if (Err) { llvm::errs() << llvm::toString(std::move(Err)) << "\n"; - assert(!Err && "Fixes must not conflict!"); + assert(false && "Fixes must not conflict!"); + } Idx = End + 1; } @@ -1327,9 +1329,10 @@ FileName, Includes.front().Offset, IncludesBlockSize, result)); // FIXME: better error handling. For now, just skip the replacement for the // release version. - if (Err) + if (Err) { llvm::errs() << llvm::toString(std::move(Err)) << "\n"; - assert(!Err); + assert(false); + } } namespace { Index: cfe/trunk/lib/Format/SortJavaScriptImports.cpp =================================================================== --- cfe/trunk/lib/Format/SortJavaScriptImports.cpp +++ cfe/trunk/lib/Format/SortJavaScriptImports.cpp @@ -197,9 +197,10 @@ ReferencesText)); // FIXME: better error handling. For now, just print error message and skip // the replacement for the release version. - if (Err) + if (Err) { llvm::errs() << llvm::toString(std::move(Err)) << "\n"; - assert(!Err); + assert(false); + } return Result; } Index: cfe/trunk/lib/Format/WhitespaceManager.cpp =================================================================== --- cfe/trunk/lib/Format/WhitespaceManager.cpp +++ cfe/trunk/lib/Format/WhitespaceManager.cpp @@ -501,9 +501,10 @@ SourceMgr, CharSourceRange::getCharRange(Range), Text)); // FIXME: better error handling. For now, just print an error message in the // release version. - if (Err) + if (Err) { llvm::errs() << llvm::toString(std::move(Err)) << "\n"; - assert(!Err); + assert(false); + } } void WhitespaceManager::appendNewlineText(std::string &Text, Index: cfe/trunk/lib/Lex/ModuleMap.cpp =================================================================== --- cfe/trunk/lib/Lex/ModuleMap.cpp +++ cfe/trunk/lib/Lex/ModuleMap.cpp @@ -827,7 +827,7 @@ return; HeaderList.push_back(KH); - Mod->Headers[headerRoleToKind(Role)].push_back(std::move(Header)); + Mod->Headers[headerRoleToKind(Role)].push_back(Header); bool isCompilingModuleHeader = LangOpts.isCompilingModule() && Mod->getTopLevelModule() == SourceModule; Index: cfe/trunk/lib/Tooling/RefactoringCallbacks.cpp =================================================================== --- cfe/trunk/lib/Tooling/RefactoringCallbacks.cpp +++ cfe/trunk/lib/Tooling/RefactoringCallbacks.cpp @@ -45,9 +45,10 @@ CharSourceRange::getTokenRange(FromMatch->getSourceRange()), ToText)); // FIXME: better error handling. For now, just print error message in the // release version. - if (Err) + if (Err) { llvm::errs() << llvm::toString(std::move(Err)) << "\n"; - assert(!Err); + assert(false); + } } } @@ -63,9 +64,10 @@ replaceStmtWithStmt(*Result.SourceManager, *FromMatch, *ToMatch)); // FIXME: better error handling. For now, just print error message in the // release version. - if (Err) + if (Err) { llvm::errs() << llvm::toString(std::move(Err)) << "\n"; - assert(!Err); + assert(false); + } } } @@ -82,9 +84,10 @@ Replace.add(replaceStmtWithStmt(*Result.SourceManager, *Node, *Body)); // FIXME: better error handling. For now, just print error message in the // release version. - if (Err) + if (Err) { llvm::errs() << llvm::toString(std::move(Err)) << "\n"; - assert(!Err); + assert(false); + } } else if (!PickTrueBranch) { // If we want to use the 'else'-branch, but it doesn't exist, delete // the whole 'if'. @@ -92,9 +95,10 @@ Replace.add(replaceStmtWithText(*Result.SourceManager, *Node, "")); // FIXME: better error handling. For now, just print error message in the // release version. - if (Err) + if (Err) { llvm::errs() << llvm::toString(std::move(Err)) << "\n"; - assert(!Err); + assert(false); + } } } }