This is an archive of the discontinued LLVM Phabricator instance.

[libc++abi] Disable failing test on Darwin
ClosedPublic

Authored by smeenai on Dec 5 2016, 4:56 PM.

Details

Summary

The macOS thread-local variable finalizer routines do not handle the
case where a termination function registers another termination function
correctly, causing this test to fail. I've filed a radar for this;
disable the test in the meantime. See [1] for more details.

[1] http://lists.llvm.org/pipermail/cfe-dev/2016-November/051376.html

Diff Detail

Repository
rL LLVM

Event Timeline

smeenai updated this revision to Diff 80344.Dec 5 2016, 4:56 PM
smeenai retitled this revision from to [libc++abi] Disable failing test on Darwin.
smeenai updated this object.
smeenai added reviewers: EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
EricWF accepted this revision.Dec 7 2016, 1:45 PM
EricWF edited edge metadata.

If this caused by a bug it should be marked XFAIL and have a comment explaining why it fails and links to the relevant PR's.

Feel free to commit after making those changes.

This revision is now accepted and ready to land.Dec 7 2016, 1:45 PM
This revision was automatically updated to reflect the committed changes.

Note for posterity in case someone does some archeology and ends up here (as I am doing): the Radar number is 29523281.