Index: lld/trunk/ELF/Config.h =================================================================== --- lld/trunk/ELF/Config.h +++ lld/trunk/ELF/Config.h @@ -62,7 +62,6 @@ llvm::StringRef Name; size_t Id; std::vector Globals; - std::vector Locals; size_t NameOff; // Offset in string table. }; @@ -92,6 +91,7 @@ std::vector SearchPaths; std::vector Undefined; std::vector VersionScriptGlobals; + std::vector VersionScriptLocals; std::vector BuildIdVector; bool AllowMultipleDefinition; bool AsNeeded = false; Index: lld/trunk/ELF/LinkerScript.cpp =================================================================== --- lld/trunk/ELF/LinkerScript.cpp +++ lld/trunk/ELF/LinkerScript.cpp @@ -1844,7 +1844,7 @@ if (VerStr.empty()) setError("locals list for anonymous version is not supported"); - readSymbols(Config->VersionDefinitions.back().Locals); + readSymbols(Config->VersionScriptLocals); } void ScriptParser::readVersionExtern(std::vector *V) { Index: lld/trunk/ELF/SymbolTable.cpp =================================================================== --- lld/trunk/ELF/SymbolTable.cpp +++ lld/trunk/ELF/SymbolTable.cpp @@ -716,24 +716,21 @@ // First, we assign versions to exact matching symbols, // i.e. version definitions not containing any glob meta-characters. - for (VersionDefinition &V : Config->VersionDefinitions) { + for (SymbolVersion Sym : Config->VersionScriptLocals) + assignVersion(Sym, VER_NDX_LOCAL, "local"); + for (VersionDefinition &V : Config->VersionDefinitions) for (SymbolVersion Sym : V.Globals) assignVersion(Sym, V.Id, V.Name); - for (SymbolVersion Sym : V.Locals) - assignVersion(Sym, VER_NDX_LOCAL, "local"); - } // Next, we assign versions to fuzzy matching symbols, // i.e. version definitions containing glob meta-characters. // Note that because the last match takes precedence over previous matches, // we iterate over the definitions in the reverse order. - for (size_t I = Config->VersionDefinitions.size() - 1; I != (size_t)-1; --I) { - VersionDefinition &V = Config->VersionDefinitions[I]; - for (SymbolVersion &Ver : V.Locals) - assignWildcardVersion(Ver, VER_NDX_LOCAL); - for (SymbolVersion &Ver : V.Globals) - assignWildcardVersion(Ver, V.Id); - } + for (SymbolVersion &Ver : Config->VersionScriptLocals) + assignWildcardVersion(Ver, VER_NDX_LOCAL); + for (size_t I = Config->VersionDefinitions.size() - 1; I != (size_t)-1; --I) + for (SymbolVersion &Ver : Config->VersionDefinitions[I].Globals) + assignWildcardVersion(Ver, Config->VersionDefinitions[I].Id); } template class elf::SymbolTable;