Index: cfe/trunk/lib/StaticAnalyzer/Checkers/MacOSXAPIChecker.cpp =================================================================== --- cfe/trunk/lib/StaticAnalyzer/Checkers/MacOSXAPIChecker.cpp +++ cfe/trunk/lib/StaticAnalyzer/Checkers/MacOSXAPIChecker.cpp @@ -94,10 +94,15 @@ bool SuggestStatic = false; os << "Call to '" << FName << "' uses"; if (const VarRegion *VR = dyn_cast(RB)) { - // We filtered out globals earlier, so it must be a local variable. + // We filtered out globals earlier, so it must be a local variable + // or a block variable which is under UnknownSpaceRegion. if (VR != R) os << " memory within"; - os << " the local variable '" << VR->getDecl()->getName() << '\''; + if (VR->getDecl()->hasAttr()) + os << " the block variable '"; + else + os << " the local variable '"; + os << VR->getDecl()->getName() << '\''; SuggestStatic = true; } else if (const ObjCIvarRegion *IVR = getParentIvarRegion(R)) { if (IVR != R) @@ -108,6 +113,9 @@ } else if (isa(RS)) { // Presence of an IVar superregion has priority over this branch, because // ObjC objects are on the heap even if the core doesn't realize this. + // Presence of a block variable base region has priority over this branch, + // because block variables are known to be either on stack or on heap + // (might actually move between the two, hence UnknownSpace). return; } else { os << " stack allocated memory"; Index: cfe/trunk/test/Analysis/dispatch-once.m =================================================================== --- cfe/trunk/test/Analysis/dispatch-once.m +++ cfe/trunk/test/Analysis/dispatch-once.m @@ -90,3 +90,20 @@ void test_ivar_array_from_external_obj(Object *o) { dispatch_once(&o->once_array[1], ^{}); // expected-warning{{Call to 'dispatch_once' uses memory within the instance variable 'once_array' for the predicate value.}} } + +void test_block_var_from_block() { + __block dispatch_once_t once; + ^{ + dispatch_once(&once, ^{}); // expected-warning{{Call to 'dispatch_once' uses the block variable 'once' for the predicate value.}} + }; +} + +void use_block_var(dispatch_once_t *once); + +void test_block_var_from_outside_block() { + __block dispatch_once_t once; + ^{ + use_block_var(&once); + }; + dispatch_once(&once, ^{}); // expected-warning{{Call to 'dispatch_once' uses the block variable 'once' for the predicate value.}} +}