This is an archive of the discontinued LLVM Phabricator instance.

Fix archetypes.hpp under libcpp-no-extensions and std level < 14
ClosedPublic

Authored by rogfer01 on Oct 31 2016, 6:55 AM.

Details

Summary

Under -fno-exceptions TEST_THROW becomes abort / __builtin_abort which returns void. This causes a type mismatch in the conditional operator when testing the library in C++98,03,11 modes.

This patch uses a comma operator to workaround this problem.

Diff Detail

Repository
rL LLVM

Event Timeline

rogfer01 updated this revision to Diff 76393.Oct 31 2016, 6:55 AM
rogfer01 retitled this revision from to Fix archetypes.hpp under libcpp-no-extensions and std level < 14.
rogfer01 updated this object.
rogfer01 added reviewers: EricWF, mclow.lists, rmaprath.
rogfer01 added a subscriber: cfe-commits.
EricWF accepted this revision.Oct 31 2016, 7:11 AM
EricWF edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Oct 31 2016, 7:11 AM
This revision was automatically updated to reflect the committed changes.