Index: lib/Target/AMDGPU/SIInsertWaits.cpp =================================================================== --- lib/Target/AMDGPU/SIInsertWaits.cpp +++ lib/Target/AMDGPU/SIInsertWaits.cpp @@ -93,6 +93,9 @@ bool LastInstWritesM0; + /// Whether or not we have flat operations outstanding. + bool IsFlatOutstanding; + /// \brief Whether the machine function returns void bool ReturnsVoid; @@ -294,6 +297,9 @@ Counters Limit = ZeroCounts; unsigned Sum = 0; + if (TII->mayAccessFlatAddressSpace(*I)) + IsFlatOutstanding = true; + for (unsigned i = 0; i < 3; ++i) { LastIssued.Array[i] += Increment.Array[i]; if (Increment.Array[i]) @@ -368,8 +374,9 @@ // Figure out if the async instructions execute in order bool Ordered[3]; - // VM_CNT is always ordered - Ordered[0] = true; + // VM_CNT is always ordered except when there are flat instructions, which + // can return out of order. + Ordered[0] = !IsFlatOutstanding; // EXP_CNT is unordered if we have both EXP & VM-writes Ordered[1] = ExpInstrTypesSeen == 3; @@ -419,6 +426,7 @@ LastOpcodeType = OTHER; LastInstWritesM0 = false; + IsFlatOutstanding = false; return true; } @@ -532,6 +540,7 @@ LastIssued = ZeroCounts; LastOpcodeType = OTHER; LastInstWritesM0 = false; + IsFlatOutstanding = false; ReturnsVoid = MF.getInfo()->returnsVoid(); memset(&UsedRegs, 0, sizeof(UsedRegs)); Index: lib/Target/AMDGPU/SIInstrInfo.h =================================================================== --- lib/Target/AMDGPU/SIInstrInfo.h +++ lib/Target/AMDGPU/SIInstrInfo.h @@ -607,6 +607,8 @@ unsigned getInstSizeInBytes(const MachineInstr &MI) const override; + bool mayAccessFlatAddressSpace(const MachineInstr &MI) const; + ArrayRef> getSerializableTargetIndices() const override; Index: lib/Target/AMDGPU/SIInstrInfo.cpp =================================================================== --- lib/Target/AMDGPU/SIInstrInfo.cpp +++ lib/Target/AMDGPU/SIInstrInfo.cpp @@ -3494,6 +3494,20 @@ } } +bool SIInstrInfo::mayAccessFlatAddressSpace(const MachineInstr &MI) const { + if (!isFLAT(MI)) + return false; + + if (MI.memoperands_empty()) + return true; + + for (const MachineMemOperand *MMO : MI.memoperands()) { + if (MMO->getAddrSpace() == AMDGPUAS::FLAT_ADDRESS) + return true; + } + return false; +} + ArrayRef> SIInstrInfo::getSerializableTargetIndices() const { static const std::pair TargetIndices[] = { Index: test/CodeGen/MIR/AMDGPU/waitcnt.mir =================================================================== --- /dev/null +++ test/CodeGen/MIR/AMDGPU/waitcnt.mir @@ -0,0 +1,59 @@ +# RUN: llc -march=amdgcn -mcpu=fiji -run-pass si-insert-waits %s -o - | FileCheck %s + +--- | + define void @flat_zero_waitcnt(i32 addrspace(1)* %global4, + <4 x i32> addrspace(1)* %global16, + i32 addrspace(4)* %flat4, + <4 x i32> addrspace(4)* %flat16) { + ret void + } +... +--- + +# CHECK-LABEL: name: flat_zero_waitcnt + +# CHECK-LABEL: bb.0: +# CHECK: FLAT_LOAD_DWORD +# CHECK: FLAT_LOAD_DWORDX4 +# Global loads will return in order so we should: +# s_waitcnt vmcnt(1) lgkmcnt(0) +# CHECK-NEXT: S_WAITCNT 113 + +# CHECK-LABEL: bb.1: +# CHECK: FLAT_LOAD_DWORD +# CHECK: FLAT_LOAD_DWORDX4 +# One outstand load has no mem operand, so we should assume it access the flat +# address space. +# s_waitcnt vmcnt(0) lgkmcnt(0) +# CHECK-NEXT: S_WAITCNT 112 + +# CHECK-LABEL: bb.2: +# CHECK: FLAT_LOAD_DWORD +# CHECK: FLAT_LOAD_DWORDX4 +# One outstand loads access the flat address space. +# s_waitcnt vmcnt(0) lgkmcnt(0) +# CHECK-NEXT: S_WAITCNT 112 + +name: flat_zero_waitcnt + +body: | + bb.0: + successors: %bb.1 + %vgpr0 = FLAT_LOAD_DWORD %vgpr1_vgpr2, 0, 0, 0, implicit %exec, implicit %flat_scr :: (load 4 from %ir.global4) + %vgpr3_vgpr4_vgpr5_vgpr6 = FLAT_LOAD_DWORDX4 %vgpr7_vgpr8, 0, 0, 0, implicit %exec, implicit %flat_scr :: (load 16 from %ir.global16) + %vgpr0 = V_MOV_B32_e32 %vgpr1, implicit %exec + S_BRANCH %bb.1 + + bb.1: + successors: %bb.2 + %vgpr0 = FLAT_LOAD_DWORD %vgpr1_vgpr2, 0, 0, 0, implicit %exec, implicit %flat_scr + %vgpr3_vgpr4_vgpr5_vgpr6 = FLAT_LOAD_DWORDX4 %vgpr7_vgpr8, 0, 0, 0, implicit %exec, implicit %flat_scr :: (load 16 from %ir.global16) + %vgpr0 = V_MOV_B32_e32 %vgpr1, implicit %exec + S_BRANCH %bb.2 + + bb.2: + %vgpr0 = FLAT_LOAD_DWORD %vgpr1_vgpr2, 0, 0, 0, implicit %exec, implicit %flat_scr :: (load 4 from %ir.flat4) + %vgpr3_vgpr4_vgpr5_vgpr6 = FLAT_LOAD_DWORDX4 %vgpr7_vgpr8, 0, 0, 0, implicit %exec, implicit %flat_scr :: (load 16 from %ir.flat16) + %vgpr0 = V_MOV_B32_e32 %vgpr1, implicit %exec + S_ENDPGM +...