This is an archive of the discontinued LLVM Phabricator instance.

Safely bailout when isl_vec_alloc was not able to allocate
Needs ReviewPublic

Authored by chrisj on Oct 19 2016, 5:19 PM.

Details

Reviewers
Meinersbur
Summary

There is possibility that memory was not allocated (due to hitting max operations etc.) and we need guard against it.

Diff Detail

Repository
rL LLVM

Event Timeline

chrisj updated this revision to Diff 75259.Oct 19 2016, 5:19 PM
chrisj retitled this revision from to Safely bailout when isl_vec_alloc was not able to allocate.
chrisj updated this object.
chrisj added reviewers: grosser, Meinersbur.
chrisj set the repository for this revision to rL LLVM.
chrisj added a subscriber: pollydev.
grosser edited edge metadata.Oct 19 2016, 6:48 PM

Hi Chris,

the change looks good! However, changes to isl should be first upstreamed to isl and only then imported back to ensure we do not get out-of-sync. Any chance you can submit this patch directly to isl-development mailing list.

Best,
Tobias

grosser resigned from this revision.Nov 29 2016, 11:57 AM
grosser removed a reviewer: grosser.

This has been implemented in isl and committed to polly in r287098. I cannot close this revision, so please close it yourself.

Resigning.