Page MenuHomePhabricator

[CMake] Cleanup check-lldb targets
ClosedPublic

Authored by beanz on Oct 11 2016, 2:10 PM.

Details

Summary

This patch adds the following fixes to the check-lldb targets:

  • Adds missing dependencies on lldb tools so they get built before tests execute
  • Adds Ninja USES_TERMINAL to the target so that the output streams to stdout as it executes
  • Uses a generator expression to find the lldb executable, this is more robust than constructing the path manually

Event Timeline

beanz updated this revision to Diff 74296.Oct 11 2016, 2:10 PM
beanz retitled this revision from to [CMake] Cleanup check-lldb targets.
beanz updated this object.
beanz added reviewers: tfiala, zturner.
beanz added a subscriber: lldb-commits.
zturner accepted this revision.Oct 11 2016, 3:58 PM
zturner edited edge metadata.
zturner added inline comments.
test/CMakeLists.txt
12 ↗(On Diff #74296)

OMG. I've been looking for this magic for forever. Praise the sun!

This revision is now accepted and ready to land.Oct 11 2016, 3:58 PM
This revision was automatically updated to reflect the committed changes.
tfiala edited edge metadata.Oct 13 2016, 9:35 AM

(Retro) Ah nice, I like the generator expression you put in there.