This is an archive of the discontinued LLVM Phabricator instance.

Differential D25459

[lit] Add more testing instructions to README
ClosedPublic

Authored by modocache on Oct 10 2016, 10:40 PM.

Details

Reviewers
echristo
beanz
• ddunbar
chapuni
delcypher
cmatthews
Commits
rGae8c2517b4fb: [lit] Add more testing instructions to README
rL284919: [lit] Add more testing instructions to README
Summary

r283710 introduced two regressions, one to llvm-lit, and the other to
lit executables that were installed via setuptools. Add instructions on
how to test for these regressions in the future.

Diff Detail

Event Timeline

modocache updated this revision to Diff 74196.Oct 10 2016, 10:40 PM
modocache retitled this revision from to [lit] Add more testing instructions to README.
modocache updated this object.
modocache added reviewers: • ddunbar, echristo, delcypher, beanz, chapuni, cmatthews.
modocache added a subscriber: llvm-commits.
Herald added a subscriber: mehdi_amini. · View Herald TranscriptOct 10 2016, 10:40 PM
modocache added a comment.Oct 19 2016, 1:26 PM

@ddunbar Friendly ping! :)

echristo accepted this revision.Oct 19 2016, 1:57 PM
echristo edited edge metadata.

LGTM.

-eric

This revision is now accepted and ready to land.Oct 19 2016, 1:57 PM
modocache closed this revision.Oct 22 2016, 10:36 AM

Revision Contents

PathSize
utils/
lit/
15 lines

Diff 74196

utils/lit/README.txt

Show All 16 LinesBefore submitting patches, run the test suite to ensure nothing has regressed:
utils/lit/lit.py \ utils/lit/lit.py \
--path /path/to/your/llvm/build/bin \ --path /path/to/your/llvm/build/bin \
utils/lit/tests utils/lit/tests
Note that lit's tests depend on 'not' and 'FileCheck', LLVM utilities. Note that lit's tests depend on 'not' and 'FileCheck', LLVM utilities.
You will need to have built LLVM tools in order to run lit's test suite You will need to have built LLVM tools in order to run lit's test suite
successfully. successfully.
You'll also want to confirm that lit continues to work when testing LLVM.
Follow the instructions in http://llvm.org/docs/TestingGuide.html to run the
regression test suite:
make check-llvm
And be sure to run the llvm-lit wrapper script as well:
/path/to/your/llvm/build/bin/llvm-lit utils/lit/tests
Finally, make sure lit works when installed via setuptools:
python utils/lit/setup.py install
lit --path /path/to/your/llvm/build/bin utils/lit/tests