Index: clang/include/clang/Basic/DiagnosticSemaKinds.td =================================================================== --- clang/include/clang/Basic/DiagnosticSemaKinds.td +++ clang/include/clang/Basic/DiagnosticSemaKinds.td @@ -6717,8 +6717,8 @@ def err_shared_var_init : Error< "initialization is not supported for __shared__ variables.">; def err_device_static_local_var : Error< - "Within a __device__/__global__ function, " - "only __shared__ variables may be marked \"static\"">; + "within a %select{__device__|__global__|__host__|__host__ __device__}0 " + "function, only __shared__ variables may be marked 'static'">; def err_cuda_vla : Error< "cannot use variable-length arrays in " "%select{__device__|__global__|__host__|__host__ __device__}0 functions">; Index: clang/lib/Sema/SemaDecl.cpp =================================================================== --- clang/lib/Sema/SemaDecl.cpp +++ clang/lib/Sema/SemaDecl.cpp @@ -10642,12 +10642,11 @@ // CUDA E.2.9.4: Within the body of a __device__ or __global__ // function, only __shared__ variables may be declared with // static storage class. - if (getLangOpts().CUDA && getLangOpts().CUDAIsDevice && - (FD->hasAttr() || FD->hasAttr()) && - !VD->hasAttr()) { - Diag(VD->getLocation(), diag::err_device_static_local_var); + if (getLangOpts().CUDA && !VD->hasAttr() && + CUDADiagIfDeviceCode(VD->getLocation(), + diag::err_device_static_local_var) + << CurrentCUDATarget()) VD->setInvalidDecl(); - } } } @@ -10661,7 +10660,7 @@ if (Init && VD->hasGlobalStorage()) { if (VD->hasAttr() || VD->hasAttr() || VD->hasAttr()) { - assert((!VD->isStaticLocal() || VD->hasAttr())); + assert(!VD->isStaticLocal() || VD->hasAttr()); bool AllowedInit = false; if (const CXXConstructExpr *CE = dyn_cast(Init)) AllowedInit = Index: clang/test/SemaCUDA/device-var-init.cu =================================================================== --- clang/test/SemaCUDA/device-var-init.cu +++ clang/test/SemaCUDA/device-var-init.cu @@ -207,9 +207,9 @@ // expected-error@-1 {{initialization is not supported for __shared__ variables.}} static __device__ int ds; - // expected-error@-1 {{Within a __device__/__global__ function, only __shared__ variables may be marked "static"}} + // expected-error@-1 {{within a __device__ function, only __shared__ variables may be marked 'static'}} static __constant__ int dc; - // expected-error@-1 {{Within a __device__/__global__ function, only __shared__ variables may be marked "static"}} + // expected-error@-1 {{within a __device__ function, only __shared__ variables may be marked 'static'}} static int v; - // expected-error@-1 {{Within a __device__/__global__ function, only __shared__ variables may be marked "static"}} + // expected-error@-1 {{within a __device__ function, only __shared__ variables may be marked 'static'}} } Index: clang/test/SemaCUDA/static-vars-hd.cu =================================================================== --- /dev/null +++ clang/test/SemaCUDA/static-vars-hd.cu @@ -0,0 +1,20 @@ +// RUN: %clang_cc1 -fcxx-exceptions -fcuda-is-device -S -o /dev/null -verify %s +// RUN: %clang_cc1 -fcxx-exceptions -S -o /dev/null -D HOST -verify %s + +#include "Inputs/cuda.h" + +#ifdef HOST +// expected-no-diagnostics +#endif + +__host__ __device__ void f() { + static int x = 42; +#ifndef HOST + // expected-error@-2 {{within a __host__ __device__ function, only __shared__ variables may be marked 'static'}} +#endif +} + +inline __host__ __device__ void g() { + static int x = 42; // no error on device because this is never codegen'ed there. +} +void call_g() { g(); }