Index: clang-rename/RenamingAction.cpp =================================================================== --- clang-rename/RenamingAction.cpp +++ clang-rename/RenamingAction.cpp @@ -68,12 +68,14 @@ << ":" << FullLoc.getSpellingLineNumber() << ":" << FullLoc.getSpellingColumnNumber() << "\n"; } - // FIXME: better error handling. tooling::Replacement Replace(SourceMgr, Loc, PrevNameLen, NewName); llvm::Error Err = FileToReplaces[Replace.getFilePath()].add(Replace); + // FIXME: As for clang-rename, replacement fails IFF either the AST node + // has been matched multiple times (which shouldn't happen in reality, + // need to fix that) or when it's a specific header. For now, just ingore + // there error that happened as it doesn't mean a failure. if (Err) - llvm::errs() << "Renaming failed in " << Replace.getFilePath() << "! " - << llvm::toString(std::move(Err)) << "\n"; + llvm::consumeError(std::move(Err)); } }