Index: llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp =================================================================== --- llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp +++ llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp @@ -991,19 +991,22 @@ } // X udiv (C1 << N), where C1 is "1< X >> (N+C2) +// X udiv (zext (C1 << N)), where C1 is "1< X >> (N+C2) static Instruction *foldUDivShl(Value *Op0, Value *Op1, const BinaryOperator &I, InstCombiner &IC) { - Instruction *ShiftLeft = cast(Op1); - if (isa(ShiftLeft)) - ShiftLeft = cast(ShiftLeft->getOperand(0)); - - const APInt &CI = - cast(ShiftLeft->getOperand(0))->getUniqueInteger(); - Value *N = ShiftLeft->getOperand(1); - if (CI != 1) - N = IC.Builder->CreateAdd(N, ConstantInt::get(N->getType(), CI.logBase2())); - if (ZExtInst *Z = dyn_cast(Op1)) - N = IC.Builder->CreateZExt(N, Z->getDestTy()); + Value *ShiftLeft; + if (!match(Op1, m_ZExt(m_Value(ShiftLeft)))) + ShiftLeft = Op1; + + const APInt *CI; + Value *N; + if (!match(ShiftLeft, m_Shl(m_APInt(CI), m_Value(N)))) + llvm_unreachable("match should never fail here!"); + if (*CI != 1) + N = IC.Builder->CreateAdd(N, + ConstantInt::get(N->getType(), CI->logBase2())); + if (Op1 != ShiftLeft) + N = IC.Builder->CreateZExt(N, Op1->getType()); BinaryOperator *LShr = BinaryOperator::CreateLShr(Op0, N); if (I.isExact()) LShr->setIsExact(); Index: llvm/trunk/test/Transforms/InstCombine/udiv-simplify.ll =================================================================== --- llvm/trunk/test/Transforms/InstCombine/udiv-simplify.ll +++ llvm/trunk/test/Transforms/InstCombine/udiv-simplify.ll @@ -47,3 +47,18 @@ %z = sext i32 %r to i64 ret i64 %z } + +; The udiv should be simplified according to the rule: +; X udiv (C1 << N), where C1 is `1< X >> (N+C2) +@b = external global [1 x i16] + +define i32 @PR30366(i1 %a) { +; CHECK-LABEL: @PR30366( +; CHECK-NEXT: [[Z:%.*]] = zext i1 %a to i32 +; CHECK-NEXT: [[D:%.*]] = lshr i32 [[Z]], zext (i16 ptrtoint ([1 x i16]* @b to i16) to i32) +; CHECK-NEXT: ret i32 [[D]] +; + %z = zext i1 %a to i32 + %d = udiv i32 %z, zext (i16 shl (i16 1, i16 ptrtoint ([1 x i16]* @b to i16)) to i32) + ret i32 %d +}