This is an archive of the discontinued LLVM Phabricator instance.

[ELF] - Fix for: bug 29115 - linkerscript does not support non-wildcard filename spec.
ClosedPublic

Authored by grimar on Aug 24 2016, 7:56 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar updated this revision to Diff 69119.Aug 24 2016, 7:56 AM
grimar retitled this revision from to [ELF] - Fix for: bug 29115 - linkerscript does not support non-wildcard filename spec..
grimar updated this object.
grimar added reviewers: ruiu, rafael.
grimar added subscribers: grimar, davide, llvm-commits, evgeny777.
ruiu added inline comments.Aug 25 2016, 1:17 AM
ELF/LinkerScript.cpp
949 ↗(On Diff #69119)

So we no longer print out "unknown command" error, don't we? I think we want that error.

grimar added inline comments.Aug 25 2016, 1:19 AM
ELF/LinkerScript.cpp
949 ↗(On Diff #69119)

I am not sure it is possible to recognize unknown command here. It can be just a name of file. If not then readInputSectionDescription() will report something.

ruiu added inline comments.Aug 25 2016, 1:23 AM
ELF/LinkerScript.cpp
949 ↗(On Diff #69119)

A filename must be followed by '(', no?

grimar added inline comments.Aug 25 2016, 1:27 AM
ELF/LinkerScript.cpp
949 ↗(On Diff #69119)

Yes and that is a problem. Because
filename.a [ ... )
does not mean that filename.a is a unknown command, but just means that input section description is incorrect.
So there is no good solution here I think. Though I can do such check here If you think it is better.

grimar updated this revision to Diff 69216.Aug 25 2016, 2:27 AM
  • Addressed review comments.
ruiu accepted this revision.Aug 29 2016, 4:24 PM
ruiu edited edge metadata.

LGTM

This revision is now accepted and ready to land.Aug 29 2016, 4:24 PM
This revision was automatically updated to reflect the committed changes.