Index: cfe/trunk/include/clang/AST/StmtGraphTraits.h =================================================================== --- cfe/trunk/include/clang/AST/StmtGraphTraits.h +++ cfe/trunk/include/clang/AST/StmtGraphTraits.h @@ -25,19 +25,18 @@ template <> struct GraphTraits { - typedef clang::Stmt NodeType; typedef clang::Stmt * NodeRef; typedef clang::Stmt::child_iterator ChildIteratorType; typedef llvm::df_iterator nodes_iterator; - static NodeType* getEntryNode(clang::Stmt* S) { return S; } + static NodeRef getEntryNode(clang::Stmt *S) { return S; } - static inline ChildIteratorType child_begin(NodeType* N) { + static inline ChildIteratorType child_begin(NodeRef N) { if (N) return N->child_begin(); else return ChildIteratorType(); } - static inline ChildIteratorType child_end(NodeType* N) { + static inline ChildIteratorType child_end(NodeRef N) { if (N) return N->child_end(); else return ChildIteratorType(); } @@ -53,19 +52,18 @@ template <> struct GraphTraits { - typedef const clang::Stmt NodeType; typedef const clang::Stmt * NodeRef; typedef clang::Stmt::const_child_iterator ChildIteratorType; typedef llvm::df_iterator nodes_iterator; - static NodeType* getEntryNode(const clang::Stmt* S) { return S; } + static NodeRef getEntryNode(const clang::Stmt *S) { return S; } - static inline ChildIteratorType child_begin(NodeType* N) { + static inline ChildIteratorType child_begin(NodeRef N) { if (N) return N->child_begin(); else return ChildIteratorType(); } - static inline ChildIteratorType child_end(NodeType* N) { + static inline ChildIteratorType child_end(NodeRef N) { if (N) return N->child_end(); else return ChildIteratorType(); } Index: cfe/trunk/include/clang/Analysis/Analyses/Dominators.h =================================================================== --- cfe/trunk/include/clang/Analysis/Analyses/Dominators.h +++ cfe/trunk/include/clang/Analysis/Analyses/Dominators.h @@ -167,19 +167,12 @@ /// namespace llvm { template <> struct GraphTraits< ::clang::DomTreeNode* > { - typedef ::clang::DomTreeNode NodeType; typedef ::clang::DomTreeNode *NodeRef; - typedef NodeType::iterator ChildIteratorType; + typedef ::clang::DomTreeNode::iterator ChildIteratorType; - static NodeType *getEntryNode(NodeType *N) { - return N; - } - static inline ChildIteratorType child_begin(NodeType *N) { - return N->begin(); - } - static inline ChildIteratorType child_end(NodeType *N) { - return N->end(); - } + static NodeRef getEntryNode(NodeRef N) { return N; } + static inline ChildIteratorType child_begin(NodeRef N) { return N->begin(); } + static inline ChildIteratorType child_end(NodeRef N) { return N->end(); } typedef llvm::pointer_iterator> nodes_iterator; @@ -195,7 +188,7 @@ template <> struct GraphTraits< ::clang::DominatorTree* > : public GraphTraits< ::clang::DomTreeNode* > { - static NodeType *getEntryNode(::clang::DominatorTree *DT) { + static NodeRef getEntryNode(::clang::DominatorTree *DT) { return DT->getRootNode(); } Index: cfe/trunk/include/clang/Analysis/CFG.h =================================================================== --- cfe/trunk/include/clang/Analysis/CFG.h +++ cfe/trunk/include/clang/Analysis/CFG.h @@ -945,63 +945,59 @@ // Traits for: CFGBlock template <> struct GraphTraits< ::clang::CFGBlock *> { - typedef ::clang::CFGBlock NodeType; typedef ::clang::CFGBlock *NodeRef; typedef ::clang::CFGBlock::succ_iterator ChildIteratorType; - static NodeType* getEntryNode(::clang::CFGBlock *BB) - { return BB; } + static NodeRef getEntryNode(::clang::CFGBlock *BB) { return BB; } - static inline ChildIteratorType child_begin(NodeType* N) - { return N->succ_begin(); } + static inline ChildIteratorType child_begin(NodeRef N) { + return N->succ_begin(); + } - static inline ChildIteratorType child_end(NodeType* N) - { return N->succ_end(); } + static inline ChildIteratorType child_end(NodeRef N) { return N->succ_end(); } }; template <> struct GraphTraits< const ::clang::CFGBlock *> { - typedef const ::clang::CFGBlock NodeType; typedef const ::clang::CFGBlock *NodeRef; typedef ::clang::CFGBlock::const_succ_iterator ChildIteratorType; - static NodeType* getEntryNode(const clang::CFGBlock *BB) - { return BB; } + static NodeRef getEntryNode(const clang::CFGBlock *BB) { return BB; } - static inline ChildIteratorType child_begin(NodeType* N) - { return N->succ_begin(); } + static inline ChildIteratorType child_begin(NodeRef N) { + return N->succ_begin(); + } - static inline ChildIteratorType child_end(NodeType* N) - { return N->succ_end(); } + static inline ChildIteratorType child_end(NodeRef N) { return N->succ_end(); } }; template <> struct GraphTraits > { - typedef ::clang::CFGBlock NodeType; typedef ::clang::CFGBlock *NodeRef; typedef ::clang::CFGBlock::const_pred_iterator ChildIteratorType; - static NodeType *getEntryNode(Inverse< ::clang::CFGBlock*> G) - { return G.Graph; } + static NodeRef getEntryNode(Inverse<::clang::CFGBlock *> G) { + return G.Graph; + } - static inline ChildIteratorType child_begin(NodeType* N) - { return N->pred_begin(); } + static inline ChildIteratorType child_begin(NodeRef N) { + return N->pred_begin(); + } - static inline ChildIteratorType child_end(NodeType* N) - { return N->pred_end(); } + static inline ChildIteratorType child_end(NodeRef N) { return N->pred_end(); } }; template <> struct GraphTraits > { - typedef const ::clang::CFGBlock NodeType; typedef const ::clang::CFGBlock *NodeRef; typedef ::clang::CFGBlock::const_pred_iterator ChildIteratorType; - static NodeType *getEntryNode(Inverse G) - { return G.Graph; } + static NodeRef getEntryNode(Inverse G) { + return G.Graph; + } - static inline ChildIteratorType child_begin(NodeType* N) - { return N->pred_begin(); } + static inline ChildIteratorType child_begin(NodeRef N) { + return N->pred_begin(); + } - static inline ChildIteratorType child_end(NodeType* N) - { return N->pred_end(); } + static inline ChildIteratorType child_end(NodeRef N) { return N->pred_end(); } }; // Traits for: CFG @@ -1011,7 +1007,7 @@ typedef ::clang::CFG::iterator nodes_iterator; - static NodeType *getEntryNode(::clang::CFG* F) { return &F->getEntry(); } + static NodeRef getEntryNode(::clang::CFG *F) { return &F->getEntry(); } static nodes_iterator nodes_begin(::clang::CFG* F) { return F->nodes_begin();} static nodes_iterator nodes_end(::clang::CFG* F) { return F->nodes_end(); } static unsigned size(::clang::CFG* F) { return F->size(); } @@ -1022,9 +1018,7 @@ typedef ::clang::CFG::const_iterator nodes_iterator; - static NodeType *getEntryNode( const ::clang::CFG* F) { - return &F->getEntry(); - } + static NodeRef getEntryNode(const ::clang::CFG *F) { return &F->getEntry(); } static nodes_iterator nodes_begin( const ::clang::CFG* F) { return F->nodes_begin(); } @@ -1041,7 +1035,7 @@ typedef ::clang::CFG::iterator nodes_iterator; - static NodeType *getEntryNode( ::clang::CFG* F) { return &F->getExit(); } + static NodeRef getEntryNode(::clang::CFG *F) { return &F->getExit(); } static nodes_iterator nodes_begin( ::clang::CFG* F) {return F->nodes_begin();} static nodes_iterator nodes_end( ::clang::CFG* F) { return F->nodes_end(); } }; @@ -1051,7 +1045,7 @@ typedef ::clang::CFG::const_iterator nodes_iterator; - static NodeType *getEntryNode(const ::clang::CFG* F) { return &F->getExit(); } + static NodeRef getEntryNode(const ::clang::CFG *F) { return &F->getExit(); } static nodes_iterator nodes_begin(const ::clang::CFG* F) { return F->nodes_begin(); } Index: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h =================================================================== --- cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h +++ cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h @@ -450,57 +450,43 @@ namespace llvm { template<> struct GraphTraits { - typedef clang::ento::ExplodedNode NodeType; typedef clang::ento::ExplodedNode *NodeRef; - typedef NodeType::succ_iterator ChildIteratorType; - typedef llvm::df_iterator nodes_iterator; + typedef clang::ento::ExplodedNode::succ_iterator ChildIteratorType; + typedef llvm::df_iterator nodes_iterator; - static inline NodeType* getEntryNode(NodeType* N) { - return N; - } + static inline NodeRef getEntryNode(NodeRef N) { return N; } - static inline ChildIteratorType child_begin(NodeType* N) { + static inline ChildIteratorType child_begin(NodeRef N) { return N->succ_begin(); } - static inline ChildIteratorType child_end(NodeType* N) { + static inline ChildIteratorType child_end(NodeRef N) { return N->succ_end(); } - static inline nodes_iterator nodes_begin(NodeType* N) { - return df_begin(N); - } + static inline nodes_iterator nodes_begin(NodeRef N) { return df_begin(N); } - static inline nodes_iterator nodes_end(NodeType* N) { - return df_end(N); - } + static inline nodes_iterator nodes_end(NodeRef N) { return df_end(N); } }; template<> struct GraphTraits { - typedef const clang::ento::ExplodedNode NodeType; typedef const clang::ento::ExplodedNode *NodeRef; - typedef NodeType::const_succ_iterator ChildIteratorType; - typedef llvm::df_iterator nodes_iterator; + typedef clang::ento::ExplodedNode::const_succ_iterator ChildIteratorType; + typedef llvm::df_iterator nodes_iterator; - static inline NodeType* getEntryNode(NodeType* N) { - return N; - } + static inline NodeRef getEntryNode(NodeRef N) { return N; } - static inline ChildIteratorType child_begin(NodeType* N) { + static inline ChildIteratorType child_begin(NodeRef N) { return N->succ_begin(); } - static inline ChildIteratorType child_end(NodeType* N) { + static inline ChildIteratorType child_end(NodeRef N) { return N->succ_end(); } - static inline nodes_iterator nodes_begin(NodeType* N) { - return df_begin(N); - } + static inline nodes_iterator nodes_begin(NodeRef N) { return df_begin(N); } - static inline nodes_iterator nodes_end(NodeType* N) { - return df_end(N); - } + static inline nodes_iterator nodes_end(NodeRef N) { return df_end(N); } }; } // end llvm namespace Index: cfe/trunk/lib/Serialization/ModuleManager.cpp =================================================================== --- cfe/trunk/lib/Serialization/ModuleManager.cpp +++ cfe/trunk/lib/Serialization/ModuleManager.cpp @@ -433,16 +433,15 @@ namespace llvm { template<> struct GraphTraits { - typedef ModuleFile NodeType; typedef ModuleFile *NodeRef; typedef llvm::SetVector::const_iterator ChildIteratorType; typedef ModuleManager::ModuleConstIterator nodes_iterator; - - static ChildIteratorType child_begin(NodeType *Node) { + + static ChildIteratorType child_begin(NodeRef Node) { return Node->Imports.begin(); } - static ChildIteratorType child_end(NodeType *Node) { + static ChildIteratorType child_end(NodeRef Node) { return Node->Imports.end(); } Index: llvm/trunk/include/llvm/ADT/GraphTraits.h =================================================================== --- llvm/trunk/include/llvm/ADT/GraphTraits.h +++ llvm/trunk/include/llvm/ADT/GraphTraits.h @@ -27,15 +27,10 @@ struct GraphTraits { // Elements to provide: - // NOTICE: We are in a transition from migration interfaces that require - // NodeType *, to NodeRef. NodeRef is required to be cheap to copy, but does - // not have to be a raw pointer. In the transition, user should define - // NodeType, and NodeRef = NodeType *. - // - // typedef NodeType - Type of Node in the graph - // typedef NodeRef - NodeType * + // typedef NodeRef - Type of Node token in the graph, which should + // be cheap to copy. // typedef ChildIteratorType - Type used to iterate over children in graph, - // dereference to a NodeRef + // dereference to a NodeRef. // static NodeRef getEntryNode(const GraphType &) // Return the entry node of the graph Index: llvm/trunk/include/llvm/Analysis/CallGraph.h =================================================================== --- llvm/trunk/include/llvm/Analysis/CallGraph.h +++ llvm/trunk/include/llvm/Analysis/CallGraph.h @@ -409,50 +409,48 @@ // Provide graph traits for tranversing call graphs using standard graph // traversals. template <> struct GraphTraits { - typedef CallGraphNode NodeType; typedef CallGraphNode *NodeRef; typedef CallGraphNode::CallRecord CGNPairTy; - static NodeType *getEntryNode(CallGraphNode *CGN) { return CGN; } + static NodeRef getEntryNode(CallGraphNode *CGN) { return CGN; } static CallGraphNode *CGNGetValue(CGNPairTy P) { return P.second; } - typedef mapped_iterator + typedef mapped_iterator ChildIteratorType; - static inline ChildIteratorType child_begin(NodeType *N) { + static inline ChildIteratorType child_begin(NodeRef N) { return ChildIteratorType(N->begin(), &CGNGetValue); } - static inline ChildIteratorType child_end(NodeType *N) { + static inline ChildIteratorType child_end(NodeRef N) { return ChildIteratorType(N->end(), &CGNGetValue); } }; template <> struct GraphTraits { - typedef const CallGraphNode NodeType; typedef const CallGraphNode *NodeRef; typedef CallGraphNode::CallRecord CGNPairTy; - static NodeType *getEntryNode(const CallGraphNode *CGN) { return CGN; } + static NodeRef getEntryNode(const CallGraphNode *CGN) { return CGN; } static const CallGraphNode *CGNGetValue(CGNPairTy P) { return P.second; } - typedef mapped_iterator + typedef mapped_iterator ChildIteratorType; - static inline ChildIteratorType child_begin(NodeType *N) { + static inline ChildIteratorType child_begin(NodeRef N) { return ChildIteratorType(N->begin(), &CGNGetValue); } - static inline ChildIteratorType child_end(NodeType *N) { + static inline ChildIteratorType child_end(NodeRef N) { return ChildIteratorType(N->end(), &CGNGetValue); } }; template <> struct GraphTraits : public GraphTraits { - static NodeType *getEntryNode(CallGraph *CGN) { + static NodeRef getEntryNode(CallGraph *CGN) { return CGN->getExternalCallingNode(); // Start at the external node! } typedef std::pair> @@ -475,7 +473,7 @@ template <> struct GraphTraits : public GraphTraits< const CallGraphNode *> { - static NodeType *getEntryNode(const CallGraph *CGN) { + static NodeRef getEntryNode(const CallGraph *CGN) { return CGN->getExternalCallingNode(); // Start at the external node! } typedef std::pair> Index: llvm/trunk/include/llvm/Analysis/Interval.h =================================================================== --- llvm/trunk/include/llvm/Analysis/Interval.h +++ llvm/trunk/include/llvm/Analysis/Interval.h @@ -121,30 +121,26 @@ } template <> struct GraphTraits { - typedef Interval NodeType; + typedef Interval *NodeRef; typedef Interval::succ_iterator ChildIteratorType; - static NodeType *getEntryNode(Interval *I) { return I; } + static NodeRef getEntryNode(Interval *I) { return I; } /// nodes_iterator/begin/end - Allow iteration over all nodes in the graph - static inline ChildIteratorType child_begin(NodeType *N) { + static inline ChildIteratorType child_begin(NodeRef N) { return succ_begin(N); } - static inline ChildIteratorType child_end(NodeType *N) { - return succ_end(N); - } + static inline ChildIteratorType child_end(NodeRef N) { return succ_end(N); } }; template <> struct GraphTraits > { - typedef Interval NodeType; + typedef Interval *NodeRef; typedef Interval::pred_iterator ChildIteratorType; - static NodeType *getEntryNode(Inverse G) { return G.Graph; } - static inline ChildIteratorType child_begin(NodeType *N) { + static NodeRef getEntryNode(Inverse G) { return G.Graph; } + static inline ChildIteratorType child_begin(NodeRef N) { return pred_begin(N); } - static inline ChildIteratorType child_end(NodeType *N) { - return pred_end(N); - } + static inline ChildIteratorType child_end(NodeRef N) { return pred_end(N); } }; } // End llvm namespace Index: llvm/trunk/include/llvm/Analysis/LazyCallGraph.h =================================================================== --- llvm/trunk/include/llvm/Analysis/LazyCallGraph.h +++ llvm/trunk/include/llvm/Analysis/LazyCallGraph.h @@ -953,20 +953,20 @@ // Provide GraphTraits specializations for call graphs. template <> struct GraphTraits { - typedef LazyCallGraph::Node NodeType; + typedef LazyCallGraph::Node *NodeRef; typedef LazyCallGraph::edge_iterator ChildIteratorType; - static NodeType *getEntryNode(NodeType *N) { return N; } - static ChildIteratorType child_begin(NodeType *N) { return N->begin(); } - static ChildIteratorType child_end(NodeType *N) { return N->end(); } + static NodeRef getEntryNode(NodeRef N) { return N; } + static ChildIteratorType child_begin(NodeRef N) { return N->begin(); } + static ChildIteratorType child_end(NodeRef N) { return N->end(); } }; template <> struct GraphTraits { - typedef LazyCallGraph::Node NodeType; + typedef LazyCallGraph::Node *NodeRef; typedef LazyCallGraph::edge_iterator ChildIteratorType; - static NodeType *getEntryNode(NodeType *N) { return N; } - static ChildIteratorType child_begin(NodeType *N) { return N->begin(); } - static ChildIteratorType child_end(NodeType *N) { return N->end(); } + static NodeRef getEntryNode(NodeRef N) { return N; } + static ChildIteratorType child_begin(NodeRef N) { return N->begin(); } + static ChildIteratorType child_end(NodeRef N) { return N->end(); } }; /// An analysis pass which computes the call graph for a module. Index: llvm/trunk/include/llvm/Analysis/LoopInfo.h =================================================================== --- llvm/trunk/include/llvm/Analysis/LoopInfo.h +++ llvm/trunk/include/llvm/Analysis/LoopInfo.h @@ -761,31 +761,21 @@ // Allow clients to walk the list of nested loops... template <> struct GraphTraits { - typedef const Loop NodeType; typedef const Loop *NodeRef; typedef LoopInfo::iterator ChildIteratorType; - static NodeType *getEntryNode(const Loop *L) { return L; } - static inline ChildIteratorType child_begin(NodeType *N) { - return N->begin(); - } - static inline ChildIteratorType child_end(NodeType *N) { - return N->end(); - } + static NodeRef getEntryNode(const Loop *L) { return L; } + static inline ChildIteratorType child_begin(NodeRef N) { return N->begin(); } + static inline ChildIteratorType child_end(NodeRef N) { return N->end(); } }; template <> struct GraphTraits { - typedef Loop NodeType; typedef Loop *NodeRef; typedef LoopInfo::iterator ChildIteratorType; - static NodeType *getEntryNode(Loop *L) { return L; } - static inline ChildIteratorType child_begin(NodeType *N) { - return N->begin(); - } - static inline ChildIteratorType child_end(NodeType *N) { - return N->end(); - } + static NodeRef getEntryNode(Loop *L) { return L; } + static inline ChildIteratorType child_begin(NodeRef N) { return N->begin(); } + static inline ChildIteratorType child_end(NodeRef N) { return N->end(); } }; /// \brief Analysis pass that exposes the \c LoopInfo for a function. Index: llvm/trunk/include/llvm/Analysis/PostDominators.h =================================================================== --- llvm/trunk/include/llvm/Analysis/PostDominators.h +++ llvm/trunk/include/llvm/Analysis/PostDominators.h @@ -89,7 +89,7 @@ template <> struct GraphTraits : public GraphTraits { - static NodeType *getEntryNode(PostDominatorTree *DT) { + static NodeRef getEntryNode(PostDominatorTree *DT) { return DT->getRootNode(); } Index: llvm/trunk/include/llvm/Analysis/RegionIterator.h =================================================================== --- llvm/trunk/include/llvm/Analysis/RegionIterator.h +++ llvm/trunk/include/llvm/Analysis/RegionIterator.h @@ -255,7 +255,6 @@ #define RegionNodeGraphTraits(NodeT, BlockT, RegionT) \ template <> struct GraphTraits { \ - typedef NodeT NodeType; \ typedef NodeT *NodeRef; \ typedef RNSuccIterator ChildIteratorType; \ static NodeRef getEntryNode(NodeRef N) { return N; } \ @@ -267,7 +266,6 @@ } \ }; \ template <> struct GraphTraits> { \ - typedef NodeT NodeType; \ typedef NodeT *NodeRef; \ typedef RNSuccIterator, BlockT, RegionT> \ ChildIteratorType; \ Index: llvm/trunk/include/llvm/CodeGen/MachineBasicBlock.h =================================================================== --- llvm/trunk/include/llvm/CodeGen/MachineBasicBlock.h +++ llvm/trunk/include/llvm/CodeGen/MachineBasicBlock.h @@ -728,31 +728,25 @@ // template <> struct GraphTraits { - typedef MachineBasicBlock NodeType; typedef MachineBasicBlock *NodeRef; typedef MachineBasicBlock::succ_iterator ChildIteratorType; - static NodeType *getEntryNode(MachineBasicBlock *BB) { return BB; } - static inline ChildIteratorType child_begin(NodeType *N) { + static NodeRef getEntryNode(MachineBasicBlock *BB) { return BB; } + static inline ChildIteratorType child_begin(NodeRef N) { return N->succ_begin(); } - static inline ChildIteratorType child_end(NodeType *N) { - return N->succ_end(); - } + static inline ChildIteratorType child_end(NodeRef N) { return N->succ_end(); } }; template <> struct GraphTraits { - typedef const MachineBasicBlock NodeType; typedef const MachineBasicBlock *NodeRef; typedef MachineBasicBlock::const_succ_iterator ChildIteratorType; - static NodeType *getEntryNode(const MachineBasicBlock *BB) { return BB; } - static inline ChildIteratorType child_begin(NodeType *N) { + static NodeRef getEntryNode(const MachineBasicBlock *BB) { return BB; } + static inline ChildIteratorType child_begin(NodeRef N) { return N->succ_begin(); } - static inline ChildIteratorType child_end(NodeType *N) { - return N->succ_end(); - } + static inline ChildIteratorType child_end(NodeRef N) { return N->succ_end(); } }; // Provide specializations of GraphTraits to be able to treat a @@ -762,33 +756,27 @@ // instead of the successor edges. // template <> struct GraphTraits > { - typedef MachineBasicBlock NodeType; typedef MachineBasicBlock *NodeRef; typedef MachineBasicBlock::pred_iterator ChildIteratorType; - static NodeType *getEntryNode(Inverse G) { + static NodeRef getEntryNode(Inverse G) { return G.Graph; } - static inline ChildIteratorType child_begin(NodeType *N) { + static inline ChildIteratorType child_begin(NodeRef N) { return N->pred_begin(); } - static inline ChildIteratorType child_end(NodeType *N) { - return N->pred_end(); - } + static inline ChildIteratorType child_end(NodeRef N) { return N->pred_end(); } }; template <> struct GraphTraits > { - typedef const MachineBasicBlock NodeType; typedef const MachineBasicBlock *NodeRef; typedef MachineBasicBlock::const_pred_iterator ChildIteratorType; - static NodeType *getEntryNode(Inverse G) { + static NodeRef getEntryNode(Inverse G) { return G.Graph; } - static inline ChildIteratorType child_begin(NodeType *N) { + static inline ChildIteratorType child_begin(NodeRef N) { return N->pred_begin(); } - static inline ChildIteratorType child_end(NodeType *N) { - return N->pred_end(); - } + static inline ChildIteratorType child_end(NodeRef N) { return N->pred_end(); } }; Index: llvm/trunk/include/llvm/CodeGen/MachineDominators.h =================================================================== --- llvm/trunk/include/llvm/CodeGen/MachineDominators.h +++ llvm/trunk/include/llvm/CodeGen/MachineDominators.h @@ -271,15 +271,12 @@ template struct MachineDomTreeGraphTraitsBase { - typedef Node NodeType; typedef Node *NodeRef; typedef ChildIterator ChildIteratorType; - static NodeType *getEntryNode(NodeType *N) { return N; } - static inline ChildIteratorType child_begin(NodeType *N) { - return N->begin(); - } - static inline ChildIteratorType child_end(NodeType *N) { return N->end(); } + static NodeRef getEntryNode(NodeRef N) { return N; } + static inline ChildIteratorType child_begin(NodeRef N) { return N->begin(); } + static inline ChildIteratorType child_end(NodeRef N) { return N->end(); } }; template struct GraphTraits; @@ -297,7 +294,7 @@ template <> struct GraphTraits : public GraphTraits { - static NodeType *getEntryNode(MachineDominatorTree *DT) { + static NodeRef getEntryNode(MachineDominatorTree *DT) { return DT->getRootNode(); } }; Index: llvm/trunk/include/llvm/CodeGen/MachineFunction.h =================================================================== --- llvm/trunk/include/llvm/CodeGen/MachineFunction.h +++ llvm/trunk/include/llvm/CodeGen/MachineFunction.h @@ -614,9 +614,7 @@ // template <> struct GraphTraits : public GraphTraits { - static NodeType *getEntryNode(MachineFunction *F) { - return &F->front(); - } + static NodeRef getEntryNode(MachineFunction *F) { return &F->front(); } // nodes_iterator/begin/end - Allow iteration over all nodes in the graph typedef pointer_iterator nodes_iterator; @@ -630,9 +628,7 @@ }; template <> struct GraphTraits : public GraphTraits { - static NodeType *getEntryNode(const MachineFunction *F) { - return &F->front(); - } + static NodeRef getEntryNode(const MachineFunction *F) { return &F->front(); } // nodes_iterator/begin/end - Allow iteration over all nodes in the graph typedef pointer_iterator nodes_iterator; @@ -655,13 +651,13 @@ // template <> struct GraphTraits > : public GraphTraits > { - static NodeType *getEntryNode(Inverse G) { + static NodeRef getEntryNode(Inverse G) { return &G.Graph->front(); } }; template <> struct GraphTraits > : public GraphTraits > { - static NodeType *getEntryNode(Inverse G) { + static NodeRef getEntryNode(Inverse G) { return &G.Graph->front(); } }; Index: llvm/trunk/include/llvm/CodeGen/MachineLoopInfo.h =================================================================== --- llvm/trunk/include/llvm/CodeGen/MachineLoopInfo.h +++ llvm/trunk/include/llvm/CodeGen/MachineLoopInfo.h @@ -162,31 +162,21 @@ // Allow clients to walk the list of nested loops... template <> struct GraphTraits { - typedef const MachineLoop NodeType; typedef const MachineLoop *NodeRef; typedef MachineLoopInfo::iterator ChildIteratorType; - static NodeType *getEntryNode(const MachineLoop *L) { return L; } - static inline ChildIteratorType child_begin(NodeType *N) { - return N->begin(); - } - static inline ChildIteratorType child_end(NodeType *N) { - return N->end(); - } + static NodeRef getEntryNode(const MachineLoop *L) { return L; } + static inline ChildIteratorType child_begin(NodeRef N) { return N->begin(); } + static inline ChildIteratorType child_end(NodeRef N) { return N->end(); } }; template <> struct GraphTraits { - typedef MachineLoop NodeType; typedef MachineLoop *NodeRef; typedef MachineLoopInfo::iterator ChildIteratorType; - static NodeType *getEntryNode(MachineLoop *L) { return L; } - static inline ChildIteratorType child_begin(NodeType *N) { - return N->begin(); - } - static inline ChildIteratorType child_end(NodeType *N) { - return N->end(); - } + static NodeRef getEntryNode(MachineLoop *L) { return L; } + static inline ChildIteratorType child_begin(NodeRef N) { return N->begin(); } + static inline ChildIteratorType child_end(NodeRef N) { return N->end(); } }; } // End llvm namespace Index: llvm/trunk/include/llvm/CodeGen/MachineRegionInfo.h =================================================================== --- llvm/trunk/include/llvm/CodeGen/MachineRegionInfo.h +++ llvm/trunk/include/llvm/CodeGen/MachineRegionInfo.h @@ -142,10 +142,11 @@ template <> struct GraphTraits : public GraphTraits > { - typedef df_iterator, false, - GraphTraits > > nodes_iterator; + typedef df_iterator, false, + GraphTraits>> + nodes_iterator; - static NodeType *getEntryNode(MachineRegionInfo *RI) { + static NodeRef getEntryNode(MachineRegionInfo *RI) { return GraphTraits >::getEntryNode(RI->getTopLevelRegion()); } static nodes_iterator nodes_begin(MachineRegionInfo* RI) { @@ -158,10 +159,11 @@ template <> struct GraphTraits : public GraphTraits { - typedef df_iterator, false, - GraphTraits > > nodes_iterator; + typedef df_iterator, false, + GraphTraits>> + nodes_iterator; - static NodeType *getEntryNode(MachineRegionInfoPass *RI) { + static NodeRef getEntryNode(MachineRegionInfoPass *RI) { return GraphTraits::getEntryNode(&RI->getRegionInfo()); } static nodes_iterator nodes_begin(MachineRegionInfoPass* RI) { Index: llvm/trunk/include/llvm/CodeGen/ScheduleDAG.h =================================================================== --- llvm/trunk/include/llvm/CodeGen/ScheduleDAG.h +++ llvm/trunk/include/llvm/CodeGen/ScheduleDAG.h @@ -679,14 +679,13 @@ }; template <> struct GraphTraits { - typedef SUnit NodeType; typedef SUnit *NodeRef; typedef SUnitIterator ChildIteratorType; - static inline NodeType *getEntryNode(SUnit *N) { return N; } - static inline ChildIteratorType child_begin(NodeType *N) { + static inline NodeRef getEntryNode(SUnit *N) { return N; } + static inline ChildIteratorType child_begin(NodeRef N) { return SUnitIterator::begin(N); } - static inline ChildIteratorType child_end(NodeType *N) { + static inline ChildIteratorType child_end(NodeRef N) { return SUnitIterator::end(N); } }; Index: llvm/trunk/include/llvm/CodeGen/SelectionDAGNodes.h =================================================================== --- llvm/trunk/include/llvm/CodeGen/SelectionDAGNodes.h +++ llvm/trunk/include/llvm/CodeGen/SelectionDAGNodes.h @@ -2055,14 +2055,13 @@ }; template <> struct GraphTraits { - typedef SDNode NodeType; typedef SDNode *NodeRef; typedef SDNodeIterator ChildIteratorType; - static inline NodeType *getEntryNode(SDNode *N) { return N; } - static inline ChildIteratorType child_begin(NodeType *N) { + static inline NodeRef getEntryNode(SDNode *N) { return N; } + static inline ChildIteratorType child_begin(NodeRef N) { return SDNodeIterator::begin(N); } - static inline ChildIteratorType child_end(NodeType *N) { + static inline ChildIteratorType child_end(NodeRef N) { return SDNodeIterator::end(N); } }; Index: llvm/trunk/include/llvm/IR/CFG.h =================================================================== --- llvm/trunk/include/llvm/IR/CFG.h +++ llvm/trunk/include/llvm/IR/CFG.h @@ -154,32 +154,26 @@ // graph of basic blocks... template <> struct GraphTraits { - typedef BasicBlock NodeType; typedef BasicBlock *NodeRef; typedef succ_iterator ChildIteratorType; - static NodeType *getEntryNode(BasicBlock *BB) { return BB; } - static inline ChildIteratorType child_begin(NodeType *N) { + static NodeRef getEntryNode(BasicBlock *BB) { return BB; } + static inline ChildIteratorType child_begin(NodeRef N) { return succ_begin(N); } - static inline ChildIteratorType child_end(NodeType *N) { - return succ_end(N); - } + static inline ChildIteratorType child_end(NodeRef N) { return succ_end(N); } }; template <> struct GraphTraits { - typedef const BasicBlock NodeType; typedef const BasicBlock *NodeRef; typedef succ_const_iterator ChildIteratorType; - static NodeType *getEntryNode(const BasicBlock *BB) { return BB; } + static NodeRef getEntryNode(const BasicBlock *BB) { return BB; } - static inline ChildIteratorType child_begin(NodeType *N) { + static inline ChildIteratorType child_begin(NodeRef N) { return succ_begin(N); } - static inline ChildIteratorType child_end(NodeType *N) { - return succ_end(N); - } + static inline ChildIteratorType child_end(NodeRef N) { return succ_end(N); } }; // Provide specializations of GraphTraits to be able to treat a function as a @@ -188,31 +182,23 @@ // instead of the successor edges. // template <> struct GraphTraits > { - typedef BasicBlock NodeType; typedef BasicBlock *NodeRef; typedef pred_iterator ChildIteratorType; - static NodeType *getEntryNode(Inverse G) { return G.Graph; } - static inline ChildIteratorType child_begin(NodeType *N) { + static NodeRef getEntryNode(Inverse G) { return G.Graph; } + static inline ChildIteratorType child_begin(NodeRef N) { return pred_begin(N); } - static inline ChildIteratorType child_end(NodeType *N) { - return pred_end(N); - } + static inline ChildIteratorType child_end(NodeRef N) { return pred_end(N); } }; template <> struct GraphTraits > { - typedef const BasicBlock NodeType; typedef const BasicBlock *NodeRef; typedef const_pred_iterator ChildIteratorType; - static NodeType *getEntryNode(Inverse G) { - return G.Graph; - } - static inline ChildIteratorType child_begin(NodeType *N) { + static NodeRef getEntryNode(Inverse G) { return G.Graph; } + static inline ChildIteratorType child_begin(NodeRef N) { return pred_begin(N); } - static inline ChildIteratorType child_end(NodeType *N) { - return pred_end(N); - } + static inline ChildIteratorType child_end(NodeRef N) { return pred_end(N); } }; @@ -226,7 +212,7 @@ // except that the root node is implicitly the first node of the function. // template <> struct GraphTraits : public GraphTraits { - static NodeType *getEntryNode(Function *F) { return &F->getEntryBlock(); } + static NodeRef getEntryNode(Function *F) { return &F->getEntryBlock(); } // nodes_iterator/begin/end - Allow iteration over all nodes in the graph typedef pointer_iterator nodes_iterator; @@ -240,7 +226,7 @@ }; template <> struct GraphTraits : public GraphTraits { - static NodeType *getEntryNode(const Function *F) {return &F->getEntryBlock();} + static NodeRef getEntryNode(const Function *F) { return &F->getEntryBlock(); } // nodes_iterator/begin/end - Allow iteration over all nodes in the graph typedef pointer_iterator nodes_iterator; @@ -261,13 +247,13 @@ // template <> struct GraphTraits > : public GraphTraits > { - static NodeType *getEntryNode(Inverse G) { + static NodeRef getEntryNode(Inverse G) { return &G.Graph->getEntryBlock(); } }; template <> struct GraphTraits > : public GraphTraits > { - static NodeType *getEntryNode(Inverse G) { + static NodeRef getEntryNode(Inverse G) { return &G.Graph->getEntryBlock(); } }; Index: llvm/trunk/include/llvm/IR/Dominators.h =================================================================== --- llvm/trunk/include/llvm/IR/Dominators.h +++ llvm/trunk/include/llvm/IR/Dominators.h @@ -155,24 +155,19 @@ // iterable by generic graph iterators. template struct DomTreeGraphTraitsBase { - typedef Node NodeType; typedef Node *NodeRef; typedef ChildIterator ChildIteratorType; - typedef df_iterator> nodes_iterator; + typedef df_iterator> nodes_iterator; - static NodeType *getEntryNode(NodeType *N) { return N; } - static inline ChildIteratorType child_begin(NodeType *N) { - return N->begin(); - } - static inline ChildIteratorType child_end(NodeType *N) { return N->end(); } + static NodeRef getEntryNode(NodeRef N) { return N; } + static inline ChildIteratorType child_begin(NodeRef N) { return N->begin(); } + static inline ChildIteratorType child_end(NodeRef N) { return N->end(); } - static nodes_iterator nodes_begin(NodeType *N) { + static nodes_iterator nodes_begin(NodeRef N) { return df_begin(getEntryNode(N)); } - static nodes_iterator nodes_end(NodeType *N) { - return df_end(getEntryNode(N)); - } + static nodes_iterator nodes_end(NodeRef N) { return df_end(getEntryNode(N)); } }; template <> @@ -186,9 +181,7 @@ template <> struct GraphTraits : public GraphTraits { - static NodeType *getEntryNode(DominatorTree *DT) { - return DT->getRootNode(); - } + static NodeRef getEntryNode(DominatorTree *DT) { return DT->getRootNode(); } static nodes_iterator nodes_begin(DominatorTree *N) { return df_begin(getEntryNode(N)); Index: llvm/trunk/include/llvm/IR/Type.h =================================================================== --- llvm/trunk/include/llvm/IR/Type.h +++ llvm/trunk/include/llvm/IR/Type.h @@ -429,29 +429,27 @@ // graph of sub types. template <> struct GraphTraits { - typedef Type NodeType; typedef Type *NodeRef; typedef Type::subtype_iterator ChildIteratorType; - static inline NodeType *getEntryNode(Type *T) { return T; } - static inline ChildIteratorType child_begin(NodeType *N) { + static inline NodeRef getEntryNode(Type *T) { return T; } + static inline ChildIteratorType child_begin(NodeRef N) { return N->subtype_begin(); } - static inline ChildIteratorType child_end(NodeType *N) { + static inline ChildIteratorType child_end(NodeRef N) { return N->subtype_end(); } }; template <> struct GraphTraits { - typedef const Type NodeType; typedef const Type *NodeRef; typedef Type::subtype_iterator ChildIteratorType; - static inline NodeType *getEntryNode(NodeType *T) { return T; } - static inline ChildIteratorType child_begin(NodeType *N) { + static inline NodeRef getEntryNode(NodeRef T) { return T; } + static inline ChildIteratorType child_begin(NodeRef N) { return N->subtype_begin(); } - static inline ChildIteratorType child_end(NodeType *N) { + static inline ChildIteratorType child_end(NodeRef N) { return N->subtype_end(); } }; Index: llvm/trunk/include/llvm/Transforms/Utils/MemorySSA.h =================================================================== --- llvm/trunk/include/llvm/Transforms/Utils/MemorySSA.h +++ llvm/trunk/include/llvm/Transforms/Utils/MemorySSA.h @@ -876,29 +876,25 @@ /// \brief GraphTraits for a MemoryAccess, which walks defs in the normal case, /// and uses in the inverse case. template <> struct GraphTraits { - using NodeType = MemoryAccess; + using NodeRef = MemoryAccess *; using ChildIteratorType = memoryaccess_def_iterator; - static NodeType *getEntryNode(NodeType *N) { return N; } - static inline ChildIteratorType child_begin(NodeType *N) { + static NodeRef getEntryNode(NodeRef N) { return N; } + static inline ChildIteratorType child_begin(NodeRef N) { return N->defs_begin(); } - static inline ChildIteratorType child_end(NodeType *N) { - return N->defs_end(); - } + static inline ChildIteratorType child_end(NodeRef N) { return N->defs_end(); } }; template <> struct GraphTraits> { - using NodeType = MemoryAccess; + using NodeRef = MemoryAccess *; using ChildIteratorType = MemoryAccess::iterator; - static NodeType *getEntryNode(NodeType *N) { return N; } - static inline ChildIteratorType child_begin(NodeType *N) { + static NodeRef getEntryNode(NodeRef N) { return N; } + static inline ChildIteratorType child_begin(NodeRef N) { return N->user_begin(); } - static inline ChildIteratorType child_end(NodeType *N) { - return N->user_end(); - } + static inline ChildIteratorType child_end(NodeRef N) { return N->user_end(); } }; /// \brief Provide an iterator that walks defs, giving both the memory access, Index: llvm/trunk/lib/Analysis/BlockFrequencyInfo.cpp =================================================================== --- llvm/trunk/lib/Analysis/BlockFrequencyInfo.cpp +++ llvm/trunk/lib/Analysis/BlockFrequencyInfo.cpp @@ -60,20 +60,17 @@ template <> struct GraphTraits { - typedef const BasicBlock NodeType; typedef const BasicBlock *NodeRef; typedef succ_const_iterator ChildIteratorType; typedef pointer_iterator nodes_iterator; - static inline const NodeType *getEntryNode(const BlockFrequencyInfo *G) { + static inline NodeRef getEntryNode(const BlockFrequencyInfo *G) { return &G->getFunction()->front(); } - static ChildIteratorType child_begin(const NodeType *N) { + static ChildIteratorType child_begin(const NodeRef N) { return succ_begin(N); } - static ChildIteratorType child_end(const NodeType *N) { - return succ_end(N); - } + static ChildIteratorType child_end(const NodeRef N) { return succ_end(N); } static nodes_iterator nodes_begin(const BlockFrequencyInfo *G) { return nodes_iterator(G->getFunction()->begin()); } Index: llvm/trunk/lib/Analysis/BlockFrequencyInfoImpl.cpp =================================================================== --- llvm/trunk/lib/Analysis/BlockFrequencyInfoImpl.cpp +++ llvm/trunk/lib/Analysis/BlockFrequencyInfoImpl.cpp @@ -628,15 +628,12 @@ template <> struct GraphTraits { typedef bfi_detail::IrreducibleGraph GraphT; - typedef const GraphT::IrrNode NodeType; typedef const GraphT::IrrNode *NodeRef; typedef GraphT::IrrNode::iterator ChildIteratorType; - static const NodeType *getEntryNode(const GraphT &G) { - return G.StartIrr; - } - static ChildIteratorType child_begin(NodeType *N) { return N->succ_begin(); } - static ChildIteratorType child_end(NodeType *N) { return N->succ_end(); } + static NodeRef getEntryNode(const GraphT &G) { return G.StartIrr; } + static ChildIteratorType child_begin(NodeRef N) { return N->succ_begin(); } + static ChildIteratorType child_end(NodeRef N) { return N->succ_end(); } }; } // end namespace llvm Index: llvm/trunk/lib/CodeGen/MachineBlockFrequencyInfo.cpp =================================================================== --- llvm/trunk/lib/CodeGen/MachineBlockFrequencyInfo.cpp +++ llvm/trunk/lib/CodeGen/MachineBlockFrequencyInfo.cpp @@ -52,23 +52,19 @@ namespace llvm { template <> struct GraphTraits { - typedef const MachineBasicBlock NodeType; typedef const MachineBasicBlock *NodeRef; typedef MachineBasicBlock::const_succ_iterator ChildIteratorType; typedef pointer_iterator nodes_iterator; - static inline const NodeType * - getEntryNode(const MachineBlockFrequencyInfo *G) { + static inline NodeRef getEntryNode(const MachineBlockFrequencyInfo *G) { return &G->getFunction()->front(); } - static ChildIteratorType child_begin(const NodeType *N) { + static ChildIteratorType child_begin(const NodeRef N) { return N->succ_begin(); } - static ChildIteratorType child_end(const NodeType *N) { - return N->succ_end(); - } + static ChildIteratorType child_end(const NodeRef N) { return N->succ_end(); } static nodes_iterator nodes_begin(const MachineBlockFrequencyInfo *G) { return nodes_iterator(G->getFunction()->begin()); Index: llvm/trunk/lib/Transforms/IPO/FunctionAttrs.cpp =================================================================== --- llvm/trunk/lib/Transforms/IPO/FunctionAttrs.cpp +++ llvm/trunk/lib/Transforms/IPO/FunctionAttrs.cpp @@ -332,23 +332,18 @@ namespace llvm { template <> struct GraphTraits { - typedef ArgumentGraphNode NodeType; typedef ArgumentGraphNode *NodeRef; typedef SmallVectorImpl::iterator ChildIteratorType; - static inline NodeType *getEntryNode(NodeType *A) { return A; } - static inline ChildIteratorType child_begin(NodeType *N) { + static inline NodeRef getEntryNode(NodeRef A) { return A; } + static inline ChildIteratorType child_begin(NodeRef N) { return N->Uses.begin(); } - static inline ChildIteratorType child_end(NodeType *N) { - return N->Uses.end(); - } + static inline ChildIteratorType child_end(NodeRef N) { return N->Uses.end(); } }; template <> struct GraphTraits : public GraphTraits { - static NodeType *getEntryNode(ArgumentGraph *AG) { - return AG->getEntryNode(); - } + static NodeRef getEntryNode(ArgumentGraph *AG) { return AG->getEntryNode(); } static ChildIteratorType nodes_begin(ArgumentGraph *AG) { return AG->begin(); } Index: llvm/trunk/unittests/ADT/SCCIteratorTest.cpp =================================================================== --- llvm/trunk/unittests/ADT/SCCIteratorTest.cpp +++ llvm/trunk/unittests/ADT/SCCIteratorTest.cpp @@ -229,15 +229,16 @@ template struct GraphTraits > { - typedef typename Graph::NodeType NodeType; typedef typename Graph::NodeType *NodeRef; typedef typename Graph::ChildIterator ChildIteratorType; - static inline NodeType *getEntryNode(const Graph &G) { return G.AccessNode(0); } - static inline ChildIteratorType child_begin(NodeType *Node) { - return Graph::child_begin(Node); + static inline NodeRef getEntryNode(const Graph &G) { + return G.AccessNode(0); + } + static inline ChildIteratorType child_begin(NodeRef Node) { + return Graph::child_begin(Node); } - static inline ChildIteratorType child_end(NodeType *Node) { + static inline ChildIteratorType child_end(NodeRef Node) { return Graph::child_end(Node); } }; Index: llvm/trunk/unittests/Analysis/CallGraphTest.cpp =================================================================== --- llvm/trunk/unittests/Analysis/CallGraphTest.cpp +++ llvm/trunk/unittests/Analysis/CallGraphTest.cpp @@ -17,29 +17,29 @@ namespace { template void canSpecializeGraphTraitsIterators(Ty *G) { - typedef typename GraphTraits::NodeType NodeTy; + typedef typename GraphTraits::NodeRef NodeRef; auto I = GraphTraits::nodes_begin(G); auto E = GraphTraits::nodes_end(G); auto X = ++I; // Should be able to iterate over all nodes of the graph. - static_assert(std::is_same::value, + static_assert(std::is_same::value, "Node type does not match"); - static_assert(std::is_same::value, + static_assert(std::is_same::value, "Node type does not match"); - static_assert(std::is_same::value, + static_assert(std::is_same::value, "Node type does not match"); - NodeTy *N = GraphTraits::getEntryNode(G); + NodeRef N = GraphTraits::getEntryNode(G); - auto S = GraphTraits::child_begin(N); - auto F = GraphTraits::child_end(N); + auto S = GraphTraits::child_begin(N); + auto F = GraphTraits::child_end(N); // Should be able to iterate over immediate successors of a node. - static_assert(std::is_same::value, + static_assert(std::is_same::value, "Node type does not match"); - static_assert(std::is_same::value, + static_assert(std::is_same::value, "Node type does not match"); }