Page MenuHomePhabricator

[InstrumentationRuntime] Refactor the API (Part 2/N) (NFCI)
ClosedPublic

Authored by vsk on Aug 3 2016, 9:19 PM.

Event Timeline

vsk updated this revision to Diff 66755.Aug 3 2016, 9:19 PM
vsk retitled this revision from to [InstrumentationRuntime] Refactor the API (Part 2/N) (NFCI).
vsk updated this object.
vsk added reviewers: kubamracek, k8stone.
vsk added a subscriber: lldb-commits.
kubamracek accepted this revision.Aug 11 2016, 8:07 AM
kubamracek edited edge metadata.

LGTM. While you’re at it, could you also reformat with clang-format? I noticed that the files inconsistently use curly braces on same line or new line.

This revision is now accepted and ready to land.Aug 11 2016, 8:07 AM
vsk added a comment.Aug 11 2016, 10:11 AM

Thanks for the review!

Normally I'd be happy to commit some clang-format changes as a follow-up, but the lldb team is planning on doing a project-wide clang-format commit in early September. Maybe it would be best to wait for that?

This revision was automatically updated to reflect the committed changes.