Index: lib/Transforms/Scalar/GVNHoist.cpp =================================================================== --- lib/Transforms/Scalar/GVNHoist.cpp +++ lib/Transforms/Scalar/GVNHoist.cpp @@ -193,14 +193,11 @@ VN.setAliasAnalysis(AA); VN.setMemDep(MD); bool Res = false; + MemorySSA M(F, AA, DT); + MSSA = &M; // FIXME: use lazy evaluation of VN to avoid the fix-point computation. while (1) { - // FIXME: only compute MemorySSA once. We need to update the analysis in - // the same time as transforming the code. - MemorySSA M(F, AA, DT); - MSSA = &M; - // Perform DFS Numbering of instructions. unsigned I = 0; for (const BasicBlock *BB : depth_first(&F.getEntryBlock())) @@ -208,15 +205,15 @@ DFSNumber.insert({&Inst, ++I}); auto HoistStat = hoistExpressions(F); - if (HoistStat.first + HoistStat.second == 0) { + if (HoistStat.first + HoistStat.second == 0) return Res; - } - if (HoistStat.second > 0) { + + if (HoistStat.second > 0) // To address a limitation of the current GVN, we need to rerun the - // hoisting after we hoisted loads in order to be able to hoist all - // scalars dependent on the hoisted loads. Same for stores. + // hoisting after we hoisted loads or stores in order to be able to + // hoist all scalars dependent on the hoisted ld/st. VN.clear(); - } + Res = true; // DFS numbers change when instructions are hoisted: clear and recompute. @@ -725,6 +722,8 @@ if (!Repl || firstInBB(I, Repl)) Repl = I; + MemoryAccess *NewMemAcc = nullptr; + if (Repl) { // Repl is already in HoistPt: it remains in place. assert(allOperandsAvailable(Repl, HoistPt) && @@ -742,7 +741,23 @@ !makeGepOperandsAvailable(Repl, HoistPt, InstructionsToHoist)) continue; + // Before moving the instruction, get its MSSA access. + MemoryUseOrDef *OldMemAcc = nullptr; + if (MemoryAccess *MA = MSSA->getMemoryAccess(Repl)) + OldMemAcc = dyn_cast(MA); + + // Move the instruction at the end of HoistPt. Repl->moveBefore(HoistPt->getTerminator()); + + if (OldMemAcc) { + // The definition of this ld/st will not change: ld/st hoisting is + // legal when the ld/st is not moved past its current definition. + MemoryAccess *Def = OldMemAcc->getDefiningAccess(); + NewMemAcc = MSSA->createMemoryAccessInBB(Repl, Def, HoistPt, + MemorySSA::End); + OldMemAcc->replaceAllUsesWith(NewMemAcc); + MSSA->removeMemoryAccess(OldMemAcc); + } } if (isa(Repl)) @@ -775,6 +790,14 @@ } else if (isa(Repl)) { ++NumCallsRemoved; } + + if (NewMemAcc) { + // Update the uses of the old MSSA access with NewMemAcc. + MemoryAccess *OldMA = MSSA->getMemoryAccess(I); + OldMA->replaceAllUsesWith(NewMemAcc); + MSSA->removeMemoryAccess(OldMA); + } + Repl->intersectOptionalDataWith(I); combineKnownMetadata(Repl, I); I->replaceAllUsesWith(Repl);