Index: lib/Target/AMDGPU/SIInstrInfo.cpp =================================================================== --- lib/Target/AMDGPU/SIInstrInfo.cpp +++ lib/Target/AMDGPU/SIInstrInfo.cpp @@ -390,7 +390,6 @@ unsigned Opcode; ArrayRef SubIndices; - bool Forward; if (AMDGPU::SReg_32RegClass.contains(DestReg)) { assert(AMDGPU::SReg_32RegClass.contains(SrcReg)); @@ -474,10 +473,7 @@ llvm_unreachable("Can't copy register!"); } - if (RI.getHWRegIndex(DestReg) <= RI.getHWRegIndex(SrcReg)) - Forward = true; - else - Forward = false; + bool Forward = RI.getHWRegIndex(DestReg) <= RI.getHWRegIndex(SrcReg); for (unsigned Idx = 0; Idx < SubIndices.size(); ++Idx) { unsigned SubIdx; @@ -496,6 +492,8 @@ if (Idx == 0) Builder.addReg(DestReg, RegState::Define | RegState::Implicit); + + Builder.addReg(SrcReg, RegState::Implicit); } } Index: test/CodeGen/AMDGPU/undefined-subreg-liverange.ll =================================================================== --- test/CodeGen/AMDGPU/undefined-subreg-liverange.ll +++ test/CodeGen/AMDGPU/undefined-subreg-liverange.ll @@ -1,9 +1,10 @@ -; RUN: llc -verify-machineinstrs -o /dev/null %s +; RUN: llc -march=amdgcn -verify-machineinstrs < %s | FileCheck %s ; We may have subregister live ranges that are undefined on some paths. The ; verifier should not complain about this. -target triple = "amdgcn--" -define void @func() { + +; CHECK-LABEL: {{^}}func: +define void @func() #0 { B0: br i1 undef, label %B1, label %B2 @@ -24,3 +25,66 @@ store float %ve0, float addrspace(3)* undef, align 4 ret void } + +; FIXME: Extra undef subregister copy should be removed before +; overwritten with defined copy +; CHECK-LABEL: {{^}}valley_partially_undef_copy: +define amdgpu_ps float @valley_partially_undef_copy() #0 { +bb: + %tmp = load volatile i32, i32 addrspace(1)* undef, align 4 + %tmp1 = load volatile i32, i32 addrspace(1)* undef, align 4 + %tmp2 = insertelement <4 x i32> undef, i32 %tmp1, i32 0 + %tmp3 = insertelement <4 x i32> %tmp2, i32 %tmp1, i32 1 + %tmp4 = call <4 x float> @llvm.SI.image.sample.v4i32(<4 x i32> %tmp3, <8 x i32> undef, <4 x i32> undef, i32 15, i32 0, i32 0, i32 0, i32 0, i32 0, i32 0, i32 0) + %tmp5 = extractelement <4 x float> %tmp4, i32 0 + %tmp6 = fmul float %tmp5, undef + %tmp7 = fadd float %tmp6, %tmp6 + %tmp8 = insertelement <4 x i32> %tmp2, i32 %tmp, i32 1 + store <4 x i32> %tmp8, <4 x i32> addrspace(1)* undef, align 16 + store float %tmp7, float addrspace(1)* undef, align 4 + br label %bb9 + +bb9: ; preds = %bb9, %bb + %tmp10 = icmp eq i32 %tmp, 0 + br i1 %tmp10, label %bb9, label %bb11 + +bb11: ; preds = %bb9 + store <4 x i32> %tmp2, <4 x i32> addrspace(1)* undef, align 16 + ret float undef +} + +; FIXME: Should be able to remove the undef copies + +; CHECK-LABEL: {{^}}partially_undef_copy: +; CHECK: v_mov_b32_e32 v5, 5 +; CHECK: v_mov_b32_e32 v6, 6 + +; CHECK: v_mov_b32_e32 v[[OUTPUT_LO:[0-9]+]], v5 + +; Undef copy +; CHECK: v_mov_b32_e32 v1, v6 + +; undef copy +; CHECK: v_mov_b32_e32 v2, v7 + +; CHECK: v_mov_b32_e32 v[[OUTPUT_HI:[0-9]+]], v8 +; CHECK: v_mov_b32_e32 v[[OUTPUT_LO]], v6 + +; CHECK: buffer_store_dwordx4 v{{\[}}[[OUTPUT_LO]]:[[OUTPUT_HI]]{{\]}} +define void @partially_undef_copy() #0 { + %tmp0 = call i32 asm sideeffect "v_mov_b32_e32 v5, 5", "={VGPR5}"() + %tmp1 = call i32 asm sideeffect "v_mov_b32_e32 v6, 6", "={VGPR6}"() + + %partially.undef.0 = insertelement <4 x i32> undef, i32 %tmp0, i32 0 + %partially.undef.1 = insertelement <4 x i32> %partially.undef.0, i32 %tmp1, i32 0 + + store volatile <4 x i32> %partially.undef.1, <4 x i32> addrspace(1)* undef, align 16 + tail call void asm sideeffect "v_nop", "v={VGPR5_VGPR6_VGPR7_VGPR8}"(<4 x i32> %partially.undef.0) + ret void +} + +declare <4 x float> @llvm.SI.image.sample.v4i32(<4 x i32>, <8 x i32>, <4 x i32>, i32, i32, i32, i32, i32, i32, i32, i32) #1 +declare float @llvm.SI.image.sample.i32(i32, <8 x i32>, <4 x i32>, i32, i32, i32, i32, i32, i32, i32, i32) #1 + +attributes #0 = { nounwind } +attributes #1 = { nounwind readnone }