Index: clang-tools-extra/trunk/clang-tidy/misc/DefinitionsInHeadersCheck.cpp =================================================================== --- clang-tools-extra/trunk/clang-tidy/misc/DefinitionsInHeadersCheck.cpp +++ clang-tools-extra/trunk/clang-tidy/misc/DefinitionsInHeadersCheck.cpp @@ -126,8 +126,8 @@ diag(FD->getLocation(), "function %0 defined in a header file; " "function definitions in header files can lead to ODR violations") - << FD << FixItHint::CreateInsertion(FD->getSourceRange().getBegin(), - "inline "); + << FD << FixItHint::CreateInsertion( + FD->getReturnTypeSourceRange().getBegin(), "inline "); } else if (const auto *VD = dyn_cast(ND)) { // Static data members of a class template are allowed. if (VD->getDeclContext()->isDependentContext() && VD->isStaticDataMember()) Index: clang-tools-extra/trunk/test/clang-tidy/misc-definitions-in-headers.hpp =================================================================== --- clang-tools-extra/trunk/test/clang-tidy/misc-definitions-in-headers.hpp +++ clang-tools-extra/trunk/test/clang-tidy/misc-definitions-in-headers.hpp @@ -29,6 +29,7 @@ template <> int CA::f3() { // CHECK-MESSAGES: :[[@LINE-1]]:9: warning: function 'f3' defined in a header file; +// CHECK-FIXES: inline int CA::f3() { int a = 1; return a; } @@ -90,8 +91,9 @@ } template <> -// CHECK-MESSAGES: :[[@LINE+1]]:5: warning: function 'f3' defined in a header file; int f3() { +// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: function 'f3' defined in a header file; +// CHECK-FIXES: inline int f3() { int a = 1; return a; } @@ -153,6 +155,7 @@ int CD::f() { // CHECK-MESSAGES: :[[@LINE-1]]:19: warning: function 'f' defined in a header file; +// CHECK-FIXES: inline int CD::f() { return 0; }