I think you can also use triple components in REQUIRES, which makes me wonder about 'x86_64-linux'. Is that something lit supports separately from the triple check?
|399 ↗||(On Diff #63353)|
I think you need a colon after REQUIRES.
|401 ↗||(On Diff #63353)|
coma -> comma
|402 ↗||(On Diff #63353)|
I would rather see the two forms contrasted more directly, maybe like this:
REQUIRES means all listed requirements must be satisfied; REQUIRES-ANY means at least one must be satisfied.
|429 ↗||(On Diff #63353)|
Please sort the list alphabetically. If you prefer to keep the "not" versions with the positive versions, that's fine.
Just curious, what is 'xar'?
Should we really list all of them here? I see this list getting out of date quickly as it is not obvious to people changing lit.cfg that this list exists here. I'd recommend to only refer to lit.cfg and maybe mention 1 or 2 examples...
I think having list somewhere is usefull. It wasn't obvious for me where I can find the code that defines the features - and all features are splitted between different files. The argument that it get outdated fast ins invalid - just keep track of it in reviews (I am willing to be added as a subscriber to every patch that touches any lit.cfg to check it)
The list is useful. e.g. I can see that the list doesn't mention anything similar to LLVM_ENABLE_STATS that I was looking for, so I know that I should probably go different way.
Sorry but you can't just say that the argument "is invalid". Experience shows it is.
Sure, in the meantime I think we should remove it.
A list is definitely useful. It's a reasonable point that the list evolves over time and a manually maintained list is a headache.
Maybe add a command-line option to 'lit' that will dump the REQUIRES features. Then document that option in TestingGuide.rst, instead of having the list.