Index: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp =================================================================== --- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -14516,6 +14516,11 @@ /// number. /// Ref: "Hacker's Delight" or "The PowerPC Compiler Writer's Guide". SDValue DAGCombiner::BuildUDIV(SDNode *N) { + // when optimising for size, we don't want to expand a div to a mul and + // and a shift. + if (ForCodeSize) + return SDValue(); + ConstantSDNode *C = isConstOrConstSplat(N->getOperand(1)); if (!C) return SDValue(); Index: llvm/trunk/test/CodeGen/ARM/urem-opt-size.ll =================================================================== --- llvm/trunk/test/CodeGen/ARM/urem-opt-size.ll +++ llvm/trunk/test/CodeGen/ARM/urem-opt-size.ll @@ -0,0 +1,25 @@ +; When optimising for size, we don't want to expand a div to a mul and +; and a shift sequence. As a result, the urem instruction will not be +; expanded to a sequence of umull, lsrs, muls and sub instructions, but +; just a call to __aeabi_uidivmod. +; +; RUN: llc -mtriple=armv7a-eabi -mattr=-neon -verify-machineinstrs %s -o - | FileCheck %s + +target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64" +target triple = "thumbv7m-arm-none-eabi" + +define i32 @foo() local_unnamed_addr #0 { +entry: +; CHECK-LABEL: foo: +; CHECK: __aeabi_uidivmod +; CHECK-NOT: umull + %call = tail call i32 bitcast (i32 (...)* @GetValue to i32 ()*)() + %rem = urem i32 %call, 1000000 + %cmp = icmp eq i32 %rem, 0 + %conv = zext i1 %cmp to i32 + ret i32 %conv +} + +declare i32 @GetValue(...) local_unnamed_addr + +attributes #0 = { minsize nounwind optsize }