Page MenuHomePhabricator

[MemorySSA] Reinstate the legacy printer and verifier.
ClosedPublic

Authored by mcrosier on Jul 6 2016, 10:58 AM.

Details

Summary

This was an unintended consequence of Geoff's change to add new pass manager support. Bring it back to life, so it's easier to bugpoint MemorySSA related bugs.

Chad

Event Timeline

mcrosier updated this revision to Diff 62913.Jul 6 2016, 10:58 AM
mcrosier retitled this revision from to [MemorySSA] Reinstate the legacy printer and verifier..
mcrosier updated this object.
mcrosier added subscribers: gberry, llvm-commits.
mcrosier added inline comments.Jul 6 2016, 11:00 AM
lib/Transforms/Utils/MemorySSA.cpp
59 ↗(On Diff #62963)

AAResultsWrapper and DominatorTreeWrapper can be removed.. just something I missed.

mcrosier updated this revision to Diff 62917.Jul 6 2016, 11:15 AM

-Remove the dependency on AAWrapper and DomWrapper
-Properly store MSSA pointer

mcrosier marked an inline comment as done.Jul 6 2016, 11:15 AM
gberry added inline comments.Jul 6 2016, 11:43 AM
lib/Transforms/Utils/MemorySSA.cpp
919 ↗(On Diff #62963)

You could get rid of this function and just have runOnFunction call MSSA->print() before verification.
Then you could remove the MSSA private member variable as well.

mcrosier updated this revision to Diff 62963.Jul 6 2016, 2:12 PM

Address Geoff's comments.

mcrosier marked an inline comment as done.Jul 6 2016, 2:12 PM
This revision was automatically updated to reflect the committed changes.