Page MenuHomePhabricator

AMDGPU: Fix return of non-void-returning shaders
ClosedPublic

Authored by nhaehnle on Jul 4 2016, 8:04 AM.

Details

Summary

Since "AMDGPU: Fix verifier errors in SILowerControlFlow", the logic that
ensures that a non-void-returning shader falls off the end of the last
basic block was effectively disabled, since SI_RETURN is now used.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96731

Event Timeline

nhaehnle updated this revision to Diff 62686.Jul 4 2016, 8:04 AM
nhaehnle retitled this revision from to AMDGPU: Fix return of non-void-returning shaders.
nhaehnle updated this object.
nhaehnle added reviewers: arsenm, tstellarAMD.
nhaehnle added a subscriber: llvm-commits.
arsenm accepted this revision.Jul 4 2016, 10:11 AM
arsenm edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jul 4 2016, 10:11 AM
This revision was automatically updated to reflect the committed changes.