Index: lib/CodeGen/AsmPrinter/CodeViewDebug.cpp =================================================================== --- lib/CodeGen/AsmPrinter/CodeViewDebug.cpp +++ lib/CodeGen/AsmPrinter/CodeViewDebug.cpp @@ -1325,6 +1325,8 @@ MemberList Members; // Direct overloaded methods gathered by name. MethodsMap Methods; + + std::vector NestedClasses; }; void CodeViewDebug::clear() { @@ -1377,8 +1379,8 @@ // friends in the past, but modern versions do not. } // FIXME: Get Clang to emit function virtual table here and handle it. - // FIXME: Get clang to emit nested types here and do something with - // them. + } else if (auto *Composite = dyn_cast(Element)) { + Info.NestedClasses.push_back(Composite); } // Skip other unrecognized kinds of elements. } @@ -1560,6 +1562,12 @@ OverloadedMethodRecord(Methods.size(), MethodList, Name)); } } + + // Create nested classes. + for (const DICompositeType *Nested : Info.NestedClasses) { + /* What to do with the type index? */ lowerCompleteTypeClass(Nested); + } + TypeIndex FieldTI = TypeTable.writeFieldList(Fields); return std::make_tuple(FieldTI, TypeIndex(), MemberCount); } Index: test/DebugInfo/COFF/types-nested-class.ll =================================================================== --- /dev/null +++ test/DebugInfo/COFF/types-nested-class.ll @@ -0,0 +1,98 @@ +; RUN: llc < %s -filetype=obj | llvm-readobj - -codeview | FileCheck %s + +; C++ source to regenerate: +; $ cat t.cpp +; struct A { +; struct Nested {}; +; } a; +; $ clang t.cpp -S -emit-llvm -g -gcodeview -o t.ll + +; CHECK: CodeViewTypes [ +; CHECK: Section: .debug$T (5) +; CHECK: Magic: 0x4 +; CHECK: Struct (0x1000) { +; CHECK: TypeLeafKind: LF_STRUCTURE (0x1505) +; CHECK: MemberCount: 0 +; CHECK: Properties [ (0x280) +; CHECK: ForwardReference (0x80) +; CHECK: HasUniqueName (0x200) +; CHECK: ] +; CHECK: FieldList: 0x0 +; CHECK: DerivedFrom: 0x0 +; CHECK: VShape: 0x0 +; CHECK: SizeOf: 0 +; CHECK: Name: A +; CHECK: LinkageName: .?AUA@@ +; CHECK: } +; CHECK: FieldList (0x1001) { +; CHECK: TypeLeafKind: LF_FIELDLIST (0x1203) +; CHECK: } +; CHECK: Struct (0x1002) { +; CHECK: TypeLeafKind: LF_STRUCTURE (0x1505) +; CHECK: MemberCount: 0 +; CHECK: Properties [ (0x200) +; CHECK: HasUniqueName (0x200) +; CHECK: ] +; CHECK: FieldList: (0x1001) +; CHECK: DerivedFrom: 0x0 +; CHECK: VShape: 0x0 +; CHECK: SizeOf: 1 +; CHECK: Name: A::Nested +; CHECK: LinkageName: .?AUNested@A@@ +; CHECK: } +; CHECK: StringId (0x1003) { +; CHECK: TypeLeafKind: LF_STRING_ID (0x1605) +; CHECK: Id: 0x0 +; CHECK: StringData: D:\src\hello\hello.cpp +; CHECK: } +; CHECK: UdtSourceLine (0x1004) { +; CHECK: TypeLeafKind: LF_UDT_SRC_LINE (0x1606) +; CHECK: UDT: A::Nested (0x1002) +; CHECK: SourceFile: D:\src\hello\hello.cpp (0x1003) +; CHECK: LineNumber: 2 +; CHECK: } +; CHECK: Struct (0x1005) { +; CHECK: TypeLeafKind: LF_STRUCTURE (0x1505) +; CHECK: MemberCount: 0 +; CHECK: Properties [ (0x200) +; CHECK: HasUniqueName (0x200) +; CHECK: ] +; CHECK: FieldList: (0x1001) +; CHECK: DerivedFrom: 0x0 +; CHECK: VShape: 0x0 +; CHECK: SizeOf: 1 +; CHECK: Name: A +; CHECK: LinkageName: .?AUA@@ +; CHECK: } +; CHECK: UdtSourceLine (0x1006) { +; CHECK: TypeLeafKind: LF_UDT_SRC_LINE (0x1606) +; CHECK: UDT: A (0x1005) +; CHECK: SourceFile: D:\src\hello\hello.cpp (0x1003) +; CHECK: LineNumber: 1 +; CHECK: } +; CHECK: ] + +; ModuleID = 't.cpp' +source_filename = "t.cpp" +target datalayout = "e-m:x-p:32:32-i64:64-f80:32-n8:16:32-a:0:32-S32" +target triple = "i686-pc-windows-msvc19.0.23918" + +%struct.A = type { i8 } + +@"\01?a@@3UA@@A" = global %struct.A zeroinitializer, align 1 + +!llvm.dbg.cu = !{!0} +!llvm.module.flags = !{!8, !9} +!llvm.ident = !{!10} + +!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, file: !1, producer: "clang version 3.9.0 ", isOptimized: false, runtimeVersion: 0, emissionKind: FullDebug, enums: !2, globals: !3) +!1 = !DIFile(filename: "hello.cpp", directory: "D:\5Csrc\5Chello") +!2 = !{} +!3 = !{!4} +!4 = distinct !DIGlobalVariable(name: "a", linkageName: "\01?a@@3UA@@A", scope: !0, file: !1, line: 3, type: !5, isLocal: false, isDefinition: true, variable: %struct.A* @"\01?a@@3UA@@A") +!5 = distinct !DICompositeType(tag: DW_TAG_structure_type, name: "A", file: !1, line: 1, size: 8, align: 8, elements: !6, identifier: ".?AUA@@") +!6 = !{!7} +!7 = !DICompositeType(tag: DW_TAG_structure_type, name: "Nested", scope: !5, file: !1, line: 2, size: 8, align: 8, flags: DIFlagFwdDecl, identifier: ".?AUNested@A@@") +!8 = !{i32 2, !"CodeView", i32 1} +!9 = !{i32 2, !"Debug Info Version", i32 3} +!10 = !{!"clang version 3.9.0 "}