[libcxx] [test] The Standard requires meow_insert_iterator::reference to be void.

[STL_MSFT]

Summary

The Standard requires meow_insert_iterator::reference to be void.

This is a libcxx product and test bug, since the type is observable. Mark these static_asserts as libcxx-specific, because MSVC follows the Standard strictly here.

[EricWF]

I fixed both the libc++ implementation and tests in r274209.

test/std/iterators/predef.iterators/insert.iterators/back.insert.iterator/types.pass.cpp

 //   typedef back_insert_iterator<Cont>& reference;
 //   typedef void                        pointer;
 // };
 
 #include <iterator>
 #include <type_traits>
 #include <vector>
 
+#include "test_macros.h"
+
 template <class C>
 struct find_container
     : private std::back_insert_iterator<C>
 {
     explicit find_container(C& c) : std::back_insert_iterator<C>(c) {}
     void test() {this->container = 0;}
 };
 
 template <class C>
 void
 test()
 {
     typedef std::back_insert_iterator<C> R;
     C c;
     find_container<C> q(c);
     q.test();
     static_assert((std::is_same<typename R::container_type, C>::value), "");
     static_assert((std::is_same<typename R::value_type, void>::value), "");
     static_assert((std::is_same<typename R::difference_type, void>::value), "");
-    static_assert((std::is_same<typename R::reference, R&>::value), "");
+    LIBCPP_STATIC_ASSERT((std::is_same<typename R::reference, R&>::value), "");
     static_assert((std::is_same<typename R::pointer, void>::value), "");
     static_assert((std::is_same<typename R::iterator_category, std::output_iterator_tag>::value), "");
 }
 
 int main()
 {
     test<std::vector<int> >();
 }

test/std/iterators/predef.iterators/insert.iterators/front.insert.iterator/types.pass.cpp

 //   typedef void                        pointer;
 //   typedef output_iterator_tag         iterator_category;
 // };
 
 #include <iterator>
 #include <type_traits>
 #include <vector>
 
+#include "test_macros.h"
+
 template <class C>
 struct find_container
     : private std::front_insert_iterator<C>
 {
     explicit find_container(C& c) : std::front_insert_iterator<C>(c) {}
     void test() {this->container = 0;}
 };
 
 template <class C>
 void
 test()
 {
     typedef std::front_insert_iterator<C> R;
     C c;
     find_container<C> q(c);
     q.test();
     static_assert((std::is_same<typename R::container_type, C>::value), "");
     static_assert((std::is_same<typename R::value_type, void>::value), "");
     static_assert((std::is_same<typename R::difference_type, void>::value), "");
-    static_assert((std::is_same<typename R::reference, R&>::value), "");
+    LIBCPP_STATIC_ASSERT((std::is_same<typename R::reference, R&>::value), "");
     static_assert((std::is_same<typename R::pointer, void>::value), "");
     static_assert((std::is_same<typename R::iterator_category, std::output_iterator_tag>::value), "");
 }
 
 int main()
 {
     test<std::vector<int> >();
 }

test/std/iterators/predef.iterators/insert.iterators/insert.iterator/types.pass.cpp

 //   typedef insert_iterator<Cont>& reference;
 //   typedef void                   pointer;
 // };
 
 #include <iterator>
 #include <type_traits>
 #include <vector>
 
+#include "test_macros.h"
+
 template <class C>
 struct find_members
     : private std::insert_iterator<C>
 {
     explicit find_members(C& c) : std::insert_iterator<C>(c, c.begin()) {}
     void test()
     {
         this->container = 0;
         (void)(this->iter == this->iter);
     }
 };
 
 template <class C>
 void
 test()
 {
     typedef std::insert_iterator<C> R;
     C c;
     find_members<C> q(c);
     q.test();
     static_assert((std::is_same<typename R::container_type, C>::value), "");
     static_assert((std::is_same<typename R::value_type, void>::value), "");
     static_assert((std::is_same<typename R::difference_type, void>::value), "");
-    static_assert((std::is_same<typename R::reference, R&>::value), "");
+    LIBCPP_STATIC_ASSERT((std::is_same<typename R::reference, R&>::value), "");
     static_assert((std::is_same<typename R::pointer, void>::value), "");
     static_assert((std::is_same<typename R::iterator_category, std::output_iterator_tag>::value), "");
 }
 
 int main()
 {
     test<std::vector<int> >();
 }