This is an archive of the discontinued LLVM Phabricator instance.

Add flag to control use of liveness tracking for global metadata
ClosedPublic

Authored by rgov on Jun 22 2016, 1:43 AM.

Details

Summary

This patch changes the default behavior on Mach-O platforms to not use liveness tracking for global metadata unless a new hidden flag, -asan-dead-strip-globals, is passed.

Diff Detail

Event Timeline

rgov updated this revision to Diff 61515.Jun 22 2016, 1:43 AM
rgov retitled this revision from to Add flag to control use of liveness tracking for global metadata.
rgov updated this object.
rgov added reviewers: kubamracek, zaks.anna.
rgov added a comment.Jun 22 2016, 12:19 PM

I will also have to XFAIL the initialization-bug.cc test case again.

rgov added a comment.Jun 22 2016, 12:37 PM

The dead-strip.c test is broken because:

clang-3.9: warning: argument unused during compilation: '-Xllvm'
clang-3.9: warning: argument unused during compilation: '-asan-dead-strip-globals'

I guess it's -mllvm. Fixing.

rgov updated this revision to Diff 61588.Jun 22 2016, 12:39 PM
zaks.anna accepted this revision.Jul 1 2016, 10:42 AM
zaks.anna edited edge metadata.

LGTM. Please, commit.

This revision is now accepted and ready to land.Jul 1 2016, 10:42 AM
rgov closed this revision.Jul 5 2016, 5:07 PM

I changed the flag to -asan-globals-live-support and committed as r274578 and r274579.