Page MenuHomePhabricator

LangRef: Note expectations when loading with extra alignment

Authored by arsenm on Jun 15 2016, 3:14 PM.



Diff Detail

Event Timeline

arsenm updated this revision to Diff 60919.Jun 15 2016, 3:14 PM
arsenm retitled this revision from to LangRef: Note expectations when loading with extra alignment.
arsenm updated this object.
arsenm added a reviewer: chandlerc.
arsenm added a subscriber: llvm-commits.
chandlerc added inline comments.Jun 15 2016, 3:17 PM

Maybe mention that this is hostile to debugging tools and so shouldn't be done if the function carries the address or thread sanitizer attribute?


This has the same problem as above for address sanitizer (but has no problems for thread sanitizer).

Also, you should probably explicitly state that introducing a data race is not allowed. I don't anyone to be thinking (wrongly) that the race will totally be benign because the value of the bytes are undefined and so its 'fine'.

arsenm updated this revision to Diff 60920.Jun 15 2016, 3:27 PM

Fix typo. Clarify store rules. Mention sanitizer interference

chandlerc accepted this revision.Jun 15 2016, 3:31 PM
chandlerc edited edge metadata.

LGTM, thanks for writing this down!

This revision is now accepted and ready to land.Jun 15 2016, 3:31 PM
arsenm closed this revision.Jun 16 2016, 9:40 AM