This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Remove NEON from "generic" CPU target
AbandonedPublic

Authored by aemerson on Nov 6 2013, 2:10 AM.

Details

Reviewers
None
Summary

Since NEON codegen support is still under development, we should not enable it for the default generic CPU target. This was exposed by r193740 which changed the default backend target to "generic" from *nothing* (which was not enabling NEON, just the default FP).

We can re-enable this when NEON is ready.

Diff Detail

Event Timeline

Since NEON codegen support is still under development, we
should not enable it for the default generic CPU target.

Ah, good catch! I bet that caused all sorts of problems. Looks good to me.

Cheers.

Tim.

Cheers, r194152.

Amara

Is this the proper time to re-enable NEON in AArch64 by default?

Is this the proper time to re-enable NEON in AArch64 by default?

Could be. I think the assembly support has been finished for a while.
If the vectorizer is active (not sure if it needs target stubs
implementing) it'd be a very good idea to try running the test-suite
or something though.

Cheers.

Tim.

aemerson abandoned this revision.Jul 6 2017, 10:58 AM
aemerson removed a reviewer: t.p.northover.
aemerson removed subscribers: tyomitch, llvm-commits.