Index: lib/IR/Verifier.cpp =================================================================== --- lib/IR/Verifier.cpp +++ lib/IR/Verifier.cpp @@ -276,13 +276,14 @@ Context = &M->getContext(); // First ensure the function is well-enough formed to compute dominance - // information. - if (F.empty()) { - if (OS) - *OS << "Function '" << F.getName() - << "' does not contain an entry block!\n"; - return false; - } + // information, and directly compute a dominance tree. We don't rely on the + // pass manager to provide this as it isolates us from a potentially + // out-of-date dominator tree and makes it significantly more complex to run + // this code outside of a pass manager. + // FIXME: It's really gross that we have to cast away constness here. + if (!F.empty()) + DT.recalculate(const_cast(F)); + for (const BasicBlock &BB : F) { if (!BB.empty() && BB.back().isTerminator()) continue; @@ -296,13 +297,6 @@ return false; } - // Now directly compute a dominance tree. We don't rely on the pass - // manager to provide this as it isolates us from a potentially - // out-of-date dominator tree and makes it significantly more complex to - // run this code outside of a pass manager. - // FIXME: It's really gross that we have to cast away constness here. - DT.recalculate(const_cast(F)); - Broken = false; // FIXME: We strip const here because the inst visitor strips const. visit(const_cast(F)); @@ -320,17 +314,10 @@ Context = &M.getContext(); Broken = false; - // Scan through, checking all of the external function's linkage now... - for (const Function &F : M) { - visitGlobalValue(F); - - // Check to make sure function prototypes are okay. - if (F.isDeclaration()) { - visitFunction(F); - if (F.getIntrinsicID() == Intrinsic::experimental_deoptimize) - DeoptimizeDeclarations.push_back(&F); - } - } + // Collect all declarations of the llvm.experimental.deoptimize intrinsic. + for (const Function &F : M) + if (F.getIntrinsicID() == Intrinsic::experimental_deoptimize) + DeoptimizeDeclarations.push_back(&F); // Now that we've visited every function, verify that we never asked to // recover a frame index that wasn't escaped. @@ -1872,6 +1859,8 @@ // visitFunction - Verify that a function is ok. // void Verifier::visitFunction(const Function &F) { + visitGlobalValue(F); + // Check function arguments. FunctionType *FT = F.getFunctionType(); unsigned NumArgs = F.arg_size(); @@ -4433,7 +4422,6 @@ bool llvm::verifyFunction(const Function &f, raw_ostream *OS) { Function &F = const_cast(f); - assert(!F.isDeclaration() && "Cannot verify external functions"); // Don't use a raw_null_ostream. Printing IR is expensive. Verifier V(OS, /*ShouldTreatBrokenDebugInfoAsError=*/true); @@ -4450,8 +4438,7 @@ bool Broken = false; for (const Function &F : M) - if (!F.isDeclaration() && !F.isMaterializable()) - Broken |= !V.verify(F); + Broken |= !V.verify(F); Broken |= !V.verify(M); if (BrokenDebugInfo) @@ -4488,7 +4475,12 @@ } bool doFinalization(Module &M) override { - bool HasErrors = !V.verify(M); + bool HasErrors = false; + for (Function &F : M) + if (F.isDeclaration()) + HasErrors |= !V.verify(F); + + HasErrors |= !V.verify(M); if (FatalErrors) { if (HasErrors) report_fatal_error("Broken module found, compilation aborted!");