Page MenuHomePhabricator

Add unit tests for ModuleCache
ClosedPublic

Authored by labath on May 24 2016, 9:12 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 58244.May 24 2016, 9:12 AM
labath retitled this revision from to Add unit tests for ModuleCache.
labath updated this object.
labath added reviewers: ovyalov, zturner.
labath added a subscriber: lldb-commits.
zturner accepted this revision.May 24 2016, 9:59 AM
zturner edited edge metadata.

Nothing obvious that will break on Windows here, so looks good.

This revision is now accepted and ready to land.May 24 2016, 9:59 AM
ovyalov accepted this revision.May 24 2016, 10:34 AM
ovyalov edited edge metadata.
ovyalov added inline comments.
unittests/Utility/ModuleCacheTest.cpp
74 ↗(On Diff #58244)

If it's one-off initialization can we use setUpTestCase for these purposes (for HostInfo::Initialize and ObjectFileELF::Initialize)?

This revision was automatically updated to reflect the committed changes.
labath added inline comments.May 25 2016, 3:55 AM
unittests/Utility/ModuleCacheTest.cpp
74 ↗(On Diff #58244)

Good point. I have moved this to the static method (including the variable initialization below, as they are not modified). I have also added the corresponding tearDown method.