Page MenuHomePhabricator

Skip leading spaces when decoding hex values
ClosedPublic

Authored by fjricci on May 21 2016, 8:17 AM.

Details

Summary

The StringExtractor functions using stroull will already
skip leading whitespace (ie GetU64). Make sure that the manual
hex parsing functions also skip leading whitespace.

This is important for members of the gdb protocol which are defined
as using whitespace separators (ie qfThreadInfo, qC, etc). While
lldb-server does not use the whitespace separators, gdb-remotes
should work if they do, as the whitespace is defined by the gdb-remote
protocol.

Diff Detail

Repository
rL LLVM

Event Timeline

fjricci updated this revision to Diff 58041.May 21 2016, 8:17 AM
fjricci retitled this revision from to Skip leading spaces when decoding hex values.
fjricci updated this object.
fjricci added reviewers: vharron, clayborg, jasonmolenda.
fjricci added a subscriber: lldb-commits.
sas added a subscriber: sas.May 21 2016, 9:31 PM
clayborg accepted this revision.May 23 2016, 10:15 AM
clayborg edited edge metadata.
This revision is now accepted and ready to land.May 23 2016, 10:15 AM
This revision was automatically updated to reflect the committed changes.