Page MenuHomePhabricator

[ASTMatcher] Make dump_ast_matchers.py executable.
Needs ReviewPublic

Authored by hokein on May 18 2016, 6:57 AM.

Details

Reviewers
aaron.ballman

Diff Detail

Event Timeline

hokein updated this revision to Diff 57613.May 18 2016, 6:57 AM
hokein retitled this revision from to [ASTMatcher] Make dump_ast_matchers.py executable..
hokein updated this object.
hokein added a reviewer: aaron.ballman.
hokein added a subscriber: cfe-commits.

I don't why the diff shows 755 here. But in my local directory, it's rwxr--r--.

aaron.ballman edited edge metadata.May 18 2016, 7:00 AM

I don't why the diff shows 755 here. But in my local directory, it's rwxr--r--.

Yeah, I'm not certain either (I've never used phab for reviewing this sort of thing). I would prefer this to be 0744 so that it is not group or world executable.

Yeah, I'm not certain either (I've never used phab for reviewing this sort of thing). I would prefer this to be 0744 so that it is not group or world executable.

No idea on this now. I tried chmod 744 either in git.core.filemode=true or in git.core.filemode=false, the git always shows 755 in the commit :(.

Yeah, I'm not certain either (I've never used phab for reviewing this sort of thing). I would prefer this to be 0744 so that it is not group or world executable.

No idea on this now. I tried chmod 744 either in git.core.filemode=true or in git.core.filemode=false, the git always shows 755 in the commit :(.

It sounds like this may be a git thing and what you really want is svn:executable. However, the documentation doesn't specify *what* permissions that file winds up with (http://svnbook.red-bean.com/en/1.7/svn.advanced.props.file-portability.html#svn.advanced.props.special.executable).

What's the harm in leaving the props at 0644?

What's the harm in leaving the props at 0644?

Just inconvenient . And I see the dump_format_style.py in the same directory is executable.

What's the harm in leaving the props at 0644?

Just inconvenient . And I see the dump_format_style.py in the same directory is executable.

I guess I would recommend making both python scripts executable with svn:executable is the correct way to go, instead of setting the file mode directly.