Index: lib/Driver/Tools.h =================================================================== --- lib/Driver/Tools.h +++ lib/Driver/Tools.h @@ -299,6 +299,7 @@ bool hasMipsAbiArg(const llvm::opt::ArgList &Args, const char *Value); bool isUCLibc(const llvm::opt::ArgList &Args); bool isNaN2008(const llvm::opt::ArgList &Args, const llvm::Triple &Triple); +bool isFP64ADefault(const llvm::Triple &Triple, StringRef CPUName); bool isFPXXDefault(const llvm::Triple &Triple, StringRef CPUName, StringRef ABIName, mips::FloatABI FloatABI); bool shouldUseFPXX(const llvm::opt::ArgList &Args, const llvm::Triple &Triple, Index: lib/Driver/Tools.cpp =================================================================== --- lib/Driver/Tools.cpp +++ lib/Driver/Tools.cpp @@ -1359,8 +1359,9 @@ AddTargetFeature(Args, Features, options::OPT_mmsa, options::OPT_mno_msa, "msa"); - // Add the last -mfp32/-mfpxx/-mfp64 or if none are given and the ABI is O32 - // pass -mfpxx + // Add the last -mfp32/-mfpxx/-mfp64, if none are given and the ABI is O32 + // pass -mfpxx, or if none are given and fp64a is default, pass fp64 and + // nooddspreg. if (Arg *A = Args.getLastArg(options::OPT_mfp32, options::OPT_mfpxx, options::OPT_mfp64)) { if (A->getOption().matches(options::OPT_mfp32)) @@ -1373,6 +1374,9 @@ } else if (mips::shouldUseFPXX(Args, Triple, CPUName, ABIName, FloatABI)) { Features.push_back(Args.MakeArgString("+fpxx")); Features.push_back(Args.MakeArgString("+nooddspreg")); + } else if (mips::isFP64ADefault(Triple, CPUName)) { + Features.push_back(Args.MakeArgString("+fp64")); + Features.push_back(Args.MakeArgString("+nooddspreg")); } AddTargetFeature(Args, Features, options::OPT_mno_odd_spreg, @@ -7030,10 +7034,21 @@ return false; } +bool mips::isFP64ADefault(const llvm::Triple &Triple, StringRef CPUName) { + if (!Triple.isAndroid()) + return false; + + // Android MIPS32R6 defaults to FP64A. + return llvm::StringSwitch(CPUName) + .Case("mips32r6", true) + .Default(false); +} + bool mips::isFPXXDefault(const llvm::Triple &Triple, StringRef CPUName, StringRef ABIName, mips::FloatABI FloatABI) { if (Triple.getVendor() != llvm::Triple::ImaginationTechnologies && - Triple.getVendor() != llvm::Triple::MipsTechnologies) + Triple.getVendor() != llvm::Triple::MipsTechnologies && + !Triple.isAndroid()) return false; if (ABIName != "32") Index: test/Driver/clang-translation.c =================================================================== --- test/Driver/clang-translation.c +++ test/Driver/clang-translation.c @@ -246,8 +246,19 @@ // MIPSEL-ANDROID: clang // MIPSEL-ANDROID: "-cc1" // MIPSEL-ANDROID: "-target-cpu" "mips32" +// MIPSEL-ANDROID: "-target-feature" "+fpxx" +// MIPSEL-ANDROID: "-target-feature" "+nooddspreg" // MIPSEL-ANDROID: "-mfloat-abi" "hard" +// RUN: %clang -target mipsel-linux-android -### -S %s -mcpu=mips32r6 2>&1 | \ +// RUN: FileCheck -check-prefix=MIPSEL-ANDROID-R6 %s +// MIPSEL-ANDROID-R6: clang +// MIPSEL-ANDROID-R6: "-cc1" +// MIPSEL-ANDROID-R6: "-target-cpu" "mips32r6" +// MIPSEL-ANDROID-R6: "-target-feature" "+fp64" +// MIPSEL-ANDROID-R6: "-target-feature" "+nooddspreg" +// MIPSEL-ANDROID-R6: "-mfloat-abi" "hard" + // RUN: %clang -target mips64-linux-gnu -### -S %s 2>&1 | \ // RUN: FileCheck -check-prefix=MIPS64 %s // MIPS64: clang