Make "@name =" mandatory for globals in .ll files

[• espindola]

Summary

An oddity of the .ll syntax is that the "@var = " in

@var = global i32 42

is optional. Writing just

global i32 42

is equivalent to

@0 = global i32 42

This means that there is a pretty big First set at the top level. The current implementation maintains it manually. I was trying to refactor it, but then started wondering why keep it a all. I personally find the above syntax confusing. It looks like something is missing.

The attached patch removes the feature and simplifies the parser.

[pete]

Yeah, that doesn’t seem to be particularly useful. The small number of tests you had to update shows just how few people probably even knew it existed.

LGTM to remove it.

Cheers,
Pete

[dexonsmith]

I'm not sure this goes far enough.

While it's inconvenient for parsing and not particularly readable, it makes .ll files with unnamed globals easier to modify. E.g., if you have this file:

global i32 42
global i32 43

global i32 44

you can delete the second line to create:

global i32 42

global i32 44

However, IIRC, skipping a slot would be illegal:

@0 = global i32 42

@2 = global i32 44

If you make the above (skipping a slot) legal (or if I'm wrong and it's already legal), then I'm fine with this.

docs/LangRef.rst

 
 Globals can also have a :ref:`DLL storage class <dllstorageclass>`.
 
 Variables and aliases can have a
 :ref:`Thread Local Storage Model <tls_model>`.
 
 Syntax::
 
-    [@<GlobalVarName> =] [Linkage] [Visibility] [DLLStorageClass] [ThreadLocal]
+      @<GlobalVarName> = [Linkage] [Visibility] [DLLStorageClass] [ThreadLocal]
                          [unnamed_addr] [AddrSpace] [ExternallyInitialized]
                          <global | constant> <Type> [<InitializerConstant>]
                          [, section "name"] [, comdat [($name)]]
                          [, align <Alignment>]
 
 For example, the following defines a global in a numbered address space
 with an initializer, section, and alignment:
 

lib/AsmParser/LLParser.cpp

while (1) {
     case lltok::kw_deplibs: if (ParseDepLibs()) return true; break;
     case lltok::LocalVarID: if (ParseUnnamedType()) return true; break;
     case lltok::LocalVar:   if (ParseNamedType()) return true; break;
     case lltok::GlobalID:   if (ParseUnnamedGlobal()) return true; break;
     case lltok::GlobalVar:  if (ParseNamedGlobal()) return true; break;
     case lltok::ComdatVar:  if (parseComdat()) return true; break;
     case lltok::exclaim:    if (ParseStandaloneMetadata()) return true; break;
     case lltok::MetadataVar:if (ParseNamedMetadata()) return true; break;
-
-    // The Global variable production with no name can have many different
-    // optional leading prefixes, the production is:
-    // GlobalVar ::= OptionalLinkage OptionalVisibility OptionalDLLStorageClass
-    //               OptionalThreadLocal OptionalAddrSpace OptionalUnnamedAddr
-    //               ('constant'|'global') ...
-    case lltok::kw_private:             // OptionalLinkage
-    case lltok::kw_internal:            // OptionalLinkage
-    case lltok::kw_weak:                // OptionalLinkage
-    case lltok::kw_weak_odr:            // OptionalLinkage
-    case lltok::kw_linkonce:            // OptionalLinkage
-    case lltok::kw_linkonce_odr:        // OptionalLinkage
-    case lltok::kw_appending:           // OptionalLinkage
-    case lltok::kw_common:              // OptionalLinkage
-    case lltok::kw_extern_weak:         // OptionalLinkage
-    case lltok::kw_external:            // OptionalLinkage
-    case lltok::kw_default:             // OptionalVisibility
-    case lltok::kw_hidden:              // OptionalVisibility
-    case lltok::kw_protected:           // OptionalVisibility
-    case lltok::kw_dllimport:           // OptionalDLLStorageClass
-    case lltok::kw_dllexport:           // OptionalDLLStorageClass
-    case lltok::kw_thread_local:        // OptionalThreadLocal
-    case lltok::kw_addrspace:           // OptionalAddrSpace
-    case lltok::kw_constant:            // GlobalType
-    case lltok::kw_global: {            // GlobalType
-      unsigned Linkage, Visibility, DLLStorageClass;
-      bool UnnamedAddr;
-      GlobalVariable::ThreadLocalMode TLM;
-      bool HasLinkage;
-      if (ParseOptionalLinkage(Linkage, HasLinkage) ||
-          ParseOptionalVisibility(Visibility) ||
-          ParseOptionalDLLStorageClass(DLLStorageClass) ||
-          ParseOptionalThreadLocal(TLM) ||
-          parseOptionalUnnamedAddr(UnnamedAddr) ||
-          ParseGlobal("", SMLoc(), Linkage, HasLinkage, Visibility,
-                      DLLStorageClass, TLM, UnnamedAddr))
-        return true;
-      break;
-    }
-
     case lltok::kw_attributes: if (ParseUnnamedAttrGrp()) return true; break;
     case lltok::kw_uselistorder: if (ParseUseListOrder()) return true; break;
     case lltok::kw_uselistorder_bb:
                                  if (ParseUseListOrderBB()) return true; break;
     }
   }
 }
 

test/Assembler/2003-04-15-ConstantInitAssertion.ll

 ; RUN: not llvm-as < %s >/dev/null 2> %t
 ; RUN: grep "struct initializer doesn't match struct element type" %t
 ; Test the case of a misformed constant initializer
 ; This should cause an assembler error, not an assertion failure!
-constant { i32 } { float 1.0 }
+@0 = constant { i32 } { float 1.0 }

test/Assembler/2003-05-21-ConstantShiftExpr.ll

 ; RUN: llvm-as %s -o /dev/null
 ; RUN: verify-uselistorder %s
 ; Test that shift instructions can be used in constant expressions.
 
-global i32 3670016
+@0 = global i32 3670016

test/Assembler/2003-05-21-MalformedShiftCrash.ll

 ; Found by inspection of the code
 ; RUN: not llvm-as < %s > /dev/null 2> %t
 ; RUN: grep "constexpr requires integer operands" %t
 
-global i32 ashr (float 1.0, float 2.0)
+@0 = global i32 ashr (float 1.0, float 2.0)

test/Assembler/2003-05-21-MalformedStructCrash.ll

 ; Found by inspection of the code
 ; RUN: not llvm-as < %s  > /dev/null 2> %t
 ; RUN: grep "initializer with struct type has wrong # elements" %t
 
-global {} { i32 7, float 1.0, i32 7, i32 8 }
+@0 = global {} { i32 7, float 1.0, i32 7, i32 8 }

test/Assembler/2003-08-21-ConstantExprCast-Fold.ll

 ; RUN: llvm-as < %s | llvm-dis | not grep getelementptr
 ; RUN: verify-uselistorder %s
 
 @A = external global { float }          ; <{ float }*> [#uses=2]
-global i32* bitcast ({ float }* @A to i32*)             ; <i32**>:0 [#uses=0]
+@0 = global i32* bitcast ({ float }* @A to i32*)             ; <i32**>:0 [#uses=0]

test/Assembler/2004-01-20-MaxLongLong.ll

 ; RUN: llvm-as < %s | llvm-dis | grep 9223372036854775808
 ; RUN: verify-uselistorder %s
 
-global i64 -9223372036854775808
+@0 = global i64 -9223372036854775808
 

test/Assembler/2004-02-01-NegativeZero.ll

 ; RUN: llvm-as < %s | llvm-dis | FileCheck %s
 ; RUN: verify-uselistorder %s
 
 ; CHECK: global double -0.000000e+00
-global double 0x8000000000000000
+@0 = global double 0x8000000000000000
 
 ; CHECK: global float -0.000000e+00
-global float -0.0
+@1 = global float -0.0
 

test/Assembler/2009-02-01-UnnamedForwardRef.ll

 ; RUN: llvm-as < %s | llvm-dis
 ; RUN: verify-uselistorder %s
 ; PR3372
 
 @X = global i32* @0
-global i32 4
+@0 = global i32 4
 

test/Assembler/ConstantExprFold.ll

 ; This test checks to make sure that constant exprs fold in some simple 
 ; situations
 
 ; RUN: llvm-as < %s | llvm-dis | not grep "("
 ; RUN: verify-uselistorder %s
 
 @A = global i64 0
 
-global i64* inttoptr (i64 add (i64 ptrtoint (i64* @A to i64), i64 0) to i64*) ; X + 0 == X
-global i64* inttoptr (i64 sub (i64 ptrtoint (i64* @A to i64), i64 0) to i64*) ; X - 0 == X
-global i64* inttoptr (i64 mul (i64 ptrtoint (i64* @A to i64), i64 0) to i64*) ; X * 0 == 0
-global i64* inttoptr (i64 sdiv (i64 ptrtoint (i64* @A to i64), i64 1) to i64*) ; X / 1 == X
-global i64* inttoptr (i64 srem (i64 ptrtoint (i64* @A to i64), i64 1) to i64*) ; X % 1 == 0
-global i64* inttoptr (i64 and (i64 ptrtoint (i64* @A to i64), i64 0) to i64*) ; X & 0 == 0
-global i64* inttoptr (i64 and (i64 ptrtoint (i64* @A to i64), i64 -1) to i64*) ; X & -1 == X
-global i64 or (i64 ptrtoint (i64* @A to i64), i64 -1)  ; X | -1 == -1
-global i64* inttoptr (i64 xor (i64 ptrtoint (i64* @A to i64), i64 0) to i64*) ; X ^ 0 == X
+@0 = global i64* inttoptr (i64 add (i64 ptrtoint (i64* @A to i64), i64 0) to i64*) ; X + 0 == X
+@1 = global i64* inttoptr (i64 sub (i64 ptrtoint (i64* @A to i64), i64 0) to i64*) ; X - 0 == X
+@2 = global i64* inttoptr (i64 mul (i64 ptrtoint (i64* @A to i64), i64 0) to i64*) ; X * 0 == 0
+@3 = global i64* inttoptr (i64 sdiv (i64 ptrtoint (i64* @A to i64), i64 1) to i64*) ; X / 1 == X
+@4 = global i64* inttoptr (i64 srem (i64 ptrtoint (i64* @A to i64), i64 1) to i64*) ; X % 1 == 0
+@5 = global i64* inttoptr (i64 and (i64 ptrtoint (i64* @A to i64), i64 0) to i64*) ; X & 0 == 0
+@6 = global i64* inttoptr (i64 and (i64 ptrtoint (i64* @A to i64), i64 -1) to i64*) ; X & -1 == X
+@7 = global i64 or (i64 ptrtoint (i64* @A to i64), i64 -1)  ; X | -1 == -1
+@8 = global i64* inttoptr (i64 xor (i64 ptrtoint (i64* @A to i64), i64 0) to i64*) ; X ^ 0 == X
 
 %Ty = type { i32, i32 }
 @B = external global %Ty 
 
-global i1 icmp slt (i64* @A, i64* getelementptr (i64, i64* @A, i64 1))        ; true
-global i1 icmp ult (i64* @A, i64* getelementptr (i64, i64* @A, i64 1))        ; true
-global i1 icmp slt (i64* @A, i64* getelementptr (i64, i64* @A, i64 0))        ; false
-global i1 icmp slt (i32* getelementptr (%Ty, %Ty* @B, i64 0, i32 0), 
+@9 = global i1 icmp slt (i64* @A, i64* getelementptr (i64, i64* @A, i64 1))        ; true
+@10 = global i1 icmp ult (i64* @A, i64* getelementptr (i64, i64* @A, i64 1))        ; true
+@11 = global i1 icmp slt (i64* @A, i64* getelementptr (i64, i64* @A, i64 0))        ; false
+@12 = global i1 icmp slt (i32* getelementptr (%Ty, %Ty* @B, i64 0, i32 0), 
                    i32* getelementptr (%Ty, %Ty* @B, i64 0, i32 1))            ; true
 ;global i1 icmp ne (i64* @A, i64* bitcast (%Ty* @B to i64*))                 ; true
 
 ; PR2206
 @cons = weak global i32 0, align 8              ; <i32*> [#uses=1]
-global i64 and (i64 ptrtoint (i32* @cons to i64), i64 7)
+@13 = global i64 and (i64 ptrtoint (i32* @cons to i64), i64 7)
 
-global <2 x i8*> getelementptr(i8, <2 x i8*> undef, <2 x i64> <i64 1, i64 1>)
-global <2 x i8*> getelementptr({ i8 }, <2 x { i8 }*> undef, <2 x i64> <i64 1, i64 1>, <2 x i32> <i32 0, i32 0>)
-global <2 x i8*> getelementptr(i8, <2 x i8*> zeroinitializer, <2 x i64> <i64 0, i64 0>)
-global <2 x i8*> getelementptr({ i8 }, <2 x { i8 }*> zeroinitializer, <2 x i64> <i64 0, i64 0>, <2 x i32> <i32 0, i32 0>)
+@14 = global <2 x i8*> getelementptr(i8, <2 x i8*> undef, <2 x i64> <i64 1, i64 1>)
+@15 = global <2 x i8*> getelementptr({ i8 }, <2 x { i8 }*> undef, <2 x i64> <i64 1, i64 1>, <2 x i32> <i32 0, i32 0>)
+@16 = global <2 x i8*> getelementptr(i8, <2 x i8*> zeroinitializer, <2 x i64> <i64 0, i64 0>)
+@17 = global <2 x i8*> getelementptr({ i8 }, <2 x { i8 }*> zeroinitializer, <2 x i64> <i64 0, i64 0>, <2 x i32> <i32 0, i32 0>)

test/Assembler/getelementptr_vec_idx4.ll

 ; RUN: not llvm-as < %s 2>&1 | FileCheck %s
 
 ; CHECK: getelementptr vector index has a wrong number of elements
 
-global <2 x i32*> getelementptr ([3 x {i32, i32}], <4 x [3 x {i32, i32}]*> zeroinitializer, <2 x i32> <i32 1, i32 2>, <2 x i32> <i32 2, i32 3>, <2 x i32> <i32 1, i32 1>)
+@0 = global <2 x i32*> getelementptr ([3 x {i32, i32}], <4 x [3 x {i32, i32}]*> zeroinitializer, <2 x i32> <i32 1, i32 2>, <2 x i32> <i32 2, i32 3>, <2 x i32> <i32 1, i32 1>)

test/Assembler/invalid-hexint.ll

 ; RUN: not llvm-as < %s 2>&1 | FileCheck %s
 
-global i64 u0x0p001
+@0 = global i64 u0x0p001
 ; CHECK: expected value token

test/Assembler/invalid_cast4.ll

 ; RUN: not llvm-as < %s 2>&1 | FileCheck %s
 
 ; CHECK: invalid cast opcode for cast from 'i64' to 'i64'
-global i64* inttoptr (i64 0 to i64)
+@0 = global i64* inttoptr (i64 0 to i64)

test/Assembler/vector-cmp.ll

 ; RUN: llvm-as < %s | llvm-dis | llvm-as | llvm-dis | FileCheck %s
 ; RUN: verify-uselistorder %s
 ; PR2317
 target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128"
 target triple = "i686-apple-darwin9.2.2"
 
 ; CHECK: @1 = global <4 x i1> <i1 icmp slt (i32 ptrtoint (i32* @B to i32), i32 1), i1 true, i1 false, i1 true>
 
 define <4 x i1> @foo(<4 x float> %a, <4 x float> %b) nounwind  {
 entry:
   %cmp = fcmp olt <4 x float> %a, %b    ; <4 x i32> [#uses=1]
   ret <4 x i1> %cmp
 }
 
-global <4 x i1> icmp slt ( <4 x i32> <i32 1, i32 1, i32 1, i32 1>, <4 x i32>  <i32 1, i32 2, i32 1, i32 2> )
+@0 = global <4 x i1> icmp slt ( <4 x i32> <i32 1, i32 1, i32 1, i32 1>, <4 x i32>  <i32 1, i32 2, i32 1, i32 2> )
 @B = external global i32
-global <4 x i1> icmp slt ( <4 x i32> <i32 ptrtoint (i32 * @B to i32), i32 1, i32 1, i32 1>, <4 x i32>  <i32 1, i32 2, i32 1, i32 2> )
+@1 = global <4 x i1> icmp slt ( <4 x i32> <i32 ptrtoint (i32 * @B to i32), i32 1, i32 1, i32 1>, <4 x i32>  <i32 1, i32 2, i32 1, i32 2> )

test/CodeGen/PowerPC/2008-03-24-CoalescerBug.ll

 ; RUN: llc < %s -march=ppc32
 
   %struct..0objc_object = type { %struct.objc_class* }
   %struct.NSArray = type { %struct..0objc_object }
   %struct.NSMutableArray = type { %struct.NSArray }
   %struct.PFTPersistentSymbols = type { %struct..0objc_object, %struct.VMUSymbolicator*, %struct.NSMutableArray*, %struct.__CFDictionary*, %struct.__CFDictionary*, %struct.__CFDictionary*, %struct.__CFDictionary*, %struct.NSMutableArray*, i8, %struct.pthread_mutex_t, %struct.NSMutableArray*, %struct.pthread_rwlock_t }
   %struct.VMUMachTaskContainer = type { %struct..0objc_object, i32, i32 }
   %struct.VMUSymbolicator = type { %struct..0objc_object, %struct.NSMutableArray*, %struct.NSArray*, %struct.NSArray*, %struct.VMUMachTaskContainer*, i8 }
   %struct.__CFDictionary = type opaque
   %struct.__builtin_CFString = type { i32*, i32, i8*, i32 }
   %struct.objc_class = type opaque
   %struct.objc_selector = type opaque
   %struct.pthread_mutex_t = type { i32, [40 x i8] }
   %struct.pthread_rwlock_t = type { i32, [124 x i8] }
-external constant %struct.__builtin_CFString    ; <%struct.__builtin_CFString*>:0 [#uses=1]
+@0 = external constant %struct.__builtin_CFString    ; <%struct.__builtin_CFString*>:0 [#uses=1]
 
 define void @"-[PFTPersistentSymbols saveSymbolWithName:address:path:lineNumber:flags:owner:]"(%struct.PFTPersistentSymbols* %self, %struct.objc_selector* %_cmd, %struct.NSArray* %name, i64 %address, %struct.NSArray* %path, i32 %lineNumber, i64 %flags, %struct..0objc_object* %owner) nounwind  {
 entry:
   br i1 false, label %bb12, label %bb21
 bb12:   ; preds = %entry
   %tmp17 = tail call signext i8 inttoptr (i64 4294901504 to i8 (%struct..0objc_object*, %struct.objc_selector*, %struct.NSArray*)*)( %struct..0objc_object* null, %struct.objc_selector* null, %struct.NSArray* bitcast (%struct.__builtin_CFString* @0 to %struct.NSArray*) )  nounwind     ; <i8> [#uses=0]
   br i1 false, label %bb25, label %bb21
 bb21:   ; preds = %bb12, %entry
   %tmp24 = or i64 %flags, 4   ; <i64> [#uses=1]
   br label %bb25
 bb25:   ; preds = %bb21, %bb12
   %flags_addr.0 = phi i64 [ %tmp24, %bb21 ], [ %flags, %bb12 ]    ; <i64> [#uses=1]
   %tmp3233 = trunc i64 %flags_addr.0 to i32   ; <i32> [#uses=0]
   ret void
 }

test/CodeGen/X86/2008-07-19-movups-spills.ll

 ; RUN: llc < %s -mtriple=i686-pc-linux -mattr=sse2 | FileCheck %s
 ; PR2539
 ; PR8969 - make 32-bit linux have a 16-byte aligned stack
 ; Verify that movups is still generated with an aligned stack for the globals
 ; that must be accessed unaligned
 
-external global <4 x float>, align 1    ; <<4 x float>*>:0 [#uses=2]
-external global <4 x float>, align 1    ; <<4 x float>*>:1 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:2 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:3 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:4 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:5 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:6 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:7 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:8 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:9 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:10 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:11 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:12 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:13 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:14 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:15 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:16 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:17 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:18 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:19 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:20 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:21 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:22 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:23 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:24 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:25 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:26 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:27 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:28 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:29 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:30 [#uses=1]
-external global <4 x float>, align 1    ; <<4 x float>*>:31 [#uses=1]
+@0 = external global <4 x float>, align 1  ; <<4 x float>*>:0 [#uses=2]
+@1 = external global <4 x float>, align 1  ; <<4 x float>*>:1 [#uses=1]
+@2 = external global <4 x float>, align 1  ; <<4 x float>*>:2 [#uses=1]
+@3 = external global <4 x float>, align 1  ; <<4 x float>*>:3 [#uses=1]
+@4 = external global <4 x float>, align 1  ; <<4 x float>*>:4 [#uses=1]
+@5 = external global <4 x float>, align 1  ; <<4 x float>*>:5 [#uses=1]
+@6 = external global <4 x float>, align 1  ; <<4 x float>*>:6 [#uses=1]
+@7 = external global <4 x float>, align 1  ; <<4 x float>*>:7 [#uses=1]
+@8 = external global <4 x float>, align 1  ; <<4 x float>*>:8 [#uses=1]
+@9 = external global <4 x float>, align 1  ; <<4 x float>*>:9 [#uses=1]
+@10 = external global <4 x float>, align 1  ; <<4 x float>*>:10 [#uses=1]
+@11 = external global <4 x float>, align 1  ; <<4 x float>*>:11 [#uses=1]
+@12 = external global <4 x float>, align 1  ; <<4 x float>*>:12 [#uses=1]
+@13 = external global <4 x float>, align 1  ; <<4 x float>*>:13 [#uses=1]
+@14 = external global <4 x float>, align 1  ; <<4 x float>*>:14 [#uses=1]
+@15 = external global <4 x float>, align 1  ; <<4 x float>*>:15 [#uses=1]
+@16 = external global <4 x float>, align 1  ; <<4 x float>*>:16 [#uses=1]
+@17 = external global <4 x float>, align 1  ; <<4 x float>*>:17 [#uses=1]
+@18 = external global <4 x float>, align 1  ; <<4 x float>*>:18 [#uses=1]
+@19 = external global <4 x float>, align 1  ; <<4 x float>*>:19 [#uses=1]
+@20 = external global <4 x float>, align 1  ; <<4 x float>*>:20 [#uses=1]
+@21 = external global <4 x float>, align 1  ; <<4 x float>*>:21 [#uses=1]
+@22 = external global <4 x float>, align 1  ; <<4 x float>*>:22 [#uses=1]
+@23 = external global <4 x float>, align 1  ; <<4 x float>*>:23 [#uses=1]
+@24 = external global <4 x float>, align 1  ; <<4 x float>*>:24 [#uses=1]
+@25 = external global <4 x float>, align 1  ; <<4 x float>*>:25 [#uses=1]
+@26 = external global <4 x float>, align 1  ; <<4 x float>*>:26 [#uses=1]
+@27 = external global <4 x float>, align 1  ; <<4 x float>*>:27 [#uses=1]
+@28 = external global <4 x float>, align 1  ; <<4 x float>*>:28 [#uses=1]
+@29 = external global <4 x float>, align 1  ; <<4 x float>*>:29 [#uses=1]
+@30 = external global <4 x float>, align 1  ; <<4 x float>*>:30 [#uses=1]
+@31 = external global <4 x float>, align 1  ; <<4 x float>*>:31 [#uses=1]
 
 declare void @abort()
 
 define void @test1() {
 ; CHECK: test1
 ; CHECK: movups
 ; CHECK: movups
 ; CHECK: movups

test/CodeGen/X86/2008-07-22-CombinerCrash.ll

 ; RUN: llc < %s -march=x86 -mattr=+sse2
 ; PR2566
 
-external global i16   ; <i16*>:0 [#uses=1]
-external global <4 x i16>    ; <<4 x i16>*>:1 [#uses=1]
+@0 = external global i16    ; <i16*>:0 [#uses=1]
+@1 = external global <4 x i16>    ; <<4 x i16>*>:1 [#uses=1]
 
 declare void @abort()
 
 define void @t() nounwind {
   load i16, i16* @0   ; <i16>:1 [#uses=1]
   zext i16 %1 to i64    ; <i64>:2 [#uses=1]
   bitcast i64 %2 to <4 x i16>    ; <<4 x i16>>:3 [#uses=1]
   shufflevector <4 x i16> %3, <4 x i16> undef, <4 x i32> zeroinitializer    ; <<4 x i16>>:4 [#uses=1]
   store <4 x i16> %4, <4 x i16>* @1
   ret void
 }

test/CodeGen/X86/2008-09-29-ReMatBug.ll

 ; RUN: llc < %s -mtriple=i386-apple-darwin -relocation-model=pic -disable-fp-elim
 
   %struct..0objc_selector = type opaque
   %struct.NSString = type opaque
   %struct.XCStringList = type { i32, %struct._XCStringListNode* }
   %struct._XCStringListNode = type { [3 x i8], [0 x i8], i8 }
   %struct.__builtin_CFString = type { i32*, i32, i8*, i32 }
-internal constant %struct.__builtin_CFString { i32* getelementptr ([0 x i32], [0 x i32]* @__CFConstantStringClassReference, i32 0, i32 0), i32 1992, i8* getelementptr ([3 x i8], [3 x i8]* @"\01LC", i32 0, i32 0), i32 2 }    ; <%struct.__builtin_CFString*>:0 [#uses=1]
+@0 = internal constant %struct.__builtin_CFString { i32* getelementptr ([0 x i32], [0 x i32]* @__CFConstantStringClassReference, i32 0, i32 0), i32 1992, i8* getelementptr ([3 x i8], [3 x i8]* @"\01LC", i32 0, i32 0), i32 2 }    ; <%struct.__builtin_CFString*>:0 [#uses=1]
 @__CFConstantStringClassReference = external global [0 x i32]    ; <[0 x i32]*> [#uses=1]
 @"\01LC" = internal constant [3 x i8] c"NO\00"    ; <[3 x i8]*> [#uses=1]
 @"\01LC1" = internal constant [1 x i8] zeroinitializer    ; <[1 x i8]*> [#uses=1]
 @llvm.used1 = appending global [1 x i8*] [ i8* bitcast (%struct.NSString* (%struct.XCStringList*, %struct..0objc_selector*)* @"-[XCStringList stringRepresentation]" to i8*) ], section "llvm.metadata"    ; <[1 x i8*]*> [#uses=0]
 
 define %struct.NSString* @"-[XCStringList stringRepresentation]"(%struct.XCStringList* %self, %struct..0objc_selector* %_cmd) nounwind {
 entry:
   %0 = load i32, i32* null, align 4    ; <i32> [#uses=1]

test/CodeGen/X86/2009-03-05-burr-list-crash.ll

 ; RUN: llc < %s
 
 target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128"
 target triple = "x86_64-unknown-linux-gnu"
-external global i32   ; <i32*>:0 [#uses=1]
+@0 = external global i32    ; <i32*>:0 [#uses=1]
 
 declare i64 @strlen(i8* nocapture) nounwind readonly
 
 define fastcc i8* @1(i8*) nounwind {
   br i1 false, label %3, label %2
 
 ; <label>:2   ; preds = %1
   ret i8* %0

test/CodeGen/X86/extractps.ll

 ; RUN: llc < %s -march=x86 -mcpu=penryn > %t
 ; RUN: not grep movd %t
 ; RUN: grep "movss %xmm" %t | count 1
 ; RUN: grep "extractps \$1, %xmm0, " %t | count 1
 ; PR2647
 
-external global float, align 16         ; <float*>:0 [#uses=2]
+@0 = external global float, align 16         ; <float*>:0 [#uses=2]
 
 define internal void @""() nounwind {
         load float, float* @0, align 16                ; <float>:1 [#uses=1]
         insertelement <4 x float> undef, float %1, i32 0                ; <<4 x float>>:2 [#uses=1]
         call <4 x float> @llvm.x86.sse.rsqrt.ss( <4 x float> %2 )              ; <<4 x float>>:3 [#uses=1]
         extractelement <4 x float> %3, i32 0            ; <float>:4 [#uses=1]
         store float %4, float* @0, align 16
         ret void

test/CodeGen/X86/pr2585.ll

 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc < %s -mtriple=i686-unknown-unknown -mattr=+sse2 | FileCheck %s --check-prefix=X32
 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+sse2 | FileCheck %s --check-prefix=X64
 
-external constant <4 x i32>    ; <<4 x i32>*>:0 [#uses=1]
-external constant <4 x i16>    ; <<4 x i16>*>:1 [#uses=1]
+@0 = external constant <4 x i32>    ; <<4 x i32>*>:0 [#uses=1]
+@1 = external constant <4 x i16>    ; <<4 x i16>*>:1 [#uses=1]
 
 define internal void @PR2585() {
 ; X32-LABEL: PR2585:
 ; X32:       # BB#0:
 ; X32-NEXT:    pshuflw {{.*#+}} xmm0 = mem[0,2,2,3,4,5,6,7]
 ; X32-NEXT:    pshufhw {{.*#+}} xmm0 = xmm0[0,1,2,3,4,6,6,7]
 ; X32-NEXT:    pshufd {{.*#+}} xmm0 = xmm0[0,2,2,3]
 ; X32-NEXT:    movq %xmm0, __unnamed_2

test/Feature/constexpr.ll

 ; RUN: llvm-as < %s | llvm-dis > %t1.ll
 ; RUN: llvm-as %t1.ll -o - | llvm-dis > %t2.ll
 ; RUN: diff %t1.ll %t2.ll
 
 ; This testcase is for testing expressions constructed from
 ; constant values, including constant pointers to globals.
 ;
 
 ;;-------------------------------
 ;; Test constant cast expressions
 ;;-------------------------------
 
-global i64 u0x00001     ; hexadecimal unsigned integer constants
-global i64  s0x0012312   ; hexadecimal signed integer constants
+@0 = global i64 u0x00001     ; hexadecimal unsigned integer constants
+@1 = global i64  s0x0012312   ; hexadecimal signed integer constants
 
 @t2 = global i32* @t1                             ;; Forward reference without cast
 @t3 = global i32* bitcast (i32* @t1 to i32*)       ;; Forward reference with cast
 @t1 = global i32 4                                ;; i32* @0
 @t4 = global i32** bitcast (i32** @t3 to i32**)     ;; Cast of a previous cast
 @t5 = global i32** @t3                           ;; Reference to a previous cast
 @t6 = global i32*** @t4                           ;; Different ref. to a previous cast
 @t7 = global float* inttoptr (i32 12345678 to float*) ;; Cast ordinary value to ptr
 @t9 = global i32 bitcast (float bitcast (i32 8 to float) to i32) ;; Nested cast expression
 
-global i32* bitcast (float* @4 to i32*)   ;; Forward numeric reference
-global float* @4                       ;; Duplicate forward numeric reference
-global float 0.0
+@2 = global i32* bitcast (float* @4 to i32*)   ;; Forward numeric reference
+@3 = global float* @4                     ;; Duplicate forward numeric reference
+@4 = global float 0.0
 
 
 ;;---------------------------------------------------
 ;; Test constant getelementpr expressions for arrays
 ;;---------------------------------------------------
 
 @array  = constant [2 x i32] [ i32 12, i32 52 ]
 @arrayPtr = global i32* getelementptr ([2 x i32], [2 x i32]* @array, i64 0, i64 0)    ;; i32* &@array[0][0]

test/Feature/constpointer.ll

 
 
 @t3 = global i32* @t1           ;; Forward reference
 @t1 = global i32 4
 @t4 = global i32** @t3     ;; reference to reference
 
 @t2 = global i32* @t1
 
-global float * @2                ;; Forward numeric reference
-global float * @2                ;; Duplicate forward numeric reference
-global float 0.0
-global float * @2                ;; Numeric reference
+@0 = global float * @2                ;; Forward numeric reference
+@1 = global float * @2                ;; Duplicate forward numeric reference
+@2 = global float 0.0
+@3 = global float * @2                ;; Numeric reference
 
 
 @fptr = global void() * @f       ;; Forward ref method defn
 declare void @f()               ;; External method
 
 @sptr1   = global [11x i8]* @somestr    ;; Forward ref to a constant
 @somestr = constant [11x i8] c"hello world"
 @sptr2   = global [11x i8]* @somestr
 

test/Feature/globalvars.ll

 ; RUN: llvm-as < %s | llvm-dis > %t1.ll
 ; RUN: llvm-as %t1.ll -o - | llvm-dis > %t2.ll
 ; RUN: diff %t1.ll %t2.ll
 
 @MyVar = external global i32            ; <i32*> [#uses=1]
 @MyIntList = external global { i32*, i32 }               ; <{ \2*, i32 }*> [#uses=1]
-external global i32             ; <i32*>:0 [#uses=0]
+@0 = external global i32             ; <i32*>:0 [#uses=0]
 @AConst = constant i32 123              ; <i32*> [#uses=0]
 @AString = constant [4 x i8] c"test"            ; <[4 x i8]*> [#uses=0]
 @ZeroInit = global { [100 x i32], [40 x float] } zeroinitializer                ; <{ [100 x i32], [40 x float] }*> [#uses=0]
 
 define i32 @foo(i32 %blah) {
         store i32 5, i32* @MyVar
         %idx = getelementptr { i32*, i32 }, { i32*, i32 }* @MyIntList, i64 0, i32 1             ; <i32*> [#uses=1]
         store i32 12, i32* %idx
         ret i32 %blah
 }
 
-hidden dllexport global i32 42
-dllexport global i32 42
+@1 = hidden dllexport global i32 42
+@2 = dllexport global i32 42

test/Feature/testconstants.ll

 ; RUN: llvm-as < %s | llvm-dis > %t1.ll
 ; RUN: llvm-as %t1.ll -o - | llvm-dis > %t2.ll
 ; RUN: diff %t1.ll %t2.ll
 
 @somestr = constant [11 x i8] c"hello world"            ; <[11 x i8]*> [#uses=1]
 @array = constant [2 x i32] [ i32 12, i32 52 ]          ; <[2 x i32]*> [#uses=1]
-constant { i32, i32 } { i32 4, i32 3 }          ; <{ i32, i32 }*>:0 [#uses=0]
+@0 = constant { i32, i32 } { i32 4, i32 3 }        ; <{ i32, i32 }*>:0 [#uses=0]
 
 define [2 x i32]* @testfunction(i32 %i0, i32 %j0) {
         ret [2 x i32]* @array
 }
 
 define i8* @otherfunc(i32, double) {
         %somestr = getelementptr [11 x i8], [11 x i8]* @somestr, i64 0, i64 0              ; <i8*> [#uses=1]
         ret i8* %somestr

test/Integer/constexpr_bt.ll

 ; RUN: llvm-as %s -o - | llvm-dis > %t1.ll
 ; RUN: llvm-as %t1.ll -o - | llvm-dis > %t2.ll
 ; RUN: diff %t1.ll %t2.ll
 
 
 ; This testcase is for testing expressions constructed from
 ; constant values, including constant pointers to globals.
 ;
 
 ;;-------------------------------
 ;; Test constant cast expressions
 ;;-------------------------------
 
-global i63 u0x00001     ; hexadecimal unsigned integer constants
-global i63  s0x012312   ; hexadecimal signed integer constants
+@0 = global i63 u0x00001     ; hexadecimal unsigned integer constants
+@1 = global i63  s0x012312   ; hexadecimal signed integer constants
 
 @t2 = global i33* @t1                             ;; Forward reference without cast
 @t3 = global i33* bitcast (i33* @t1 to i33*)       ;; Forward reference with cast
 @t1 = global i33 4                                ;; i32* @0
 @t4 = global i33** bitcast (i33** @t3 to i33**)     ;; Cast of a previous cast
 @t5 = global i33** @t3                           ;; Reference to a previous cast
 @t6 = global i33*** @t4
 @t7 = global float* inttoptr (i32 12345678 to float*) ;; Cast ordinary value to ptr
 @t9 = global i33 fptosi (float sitofp (i33 8 to float) to i33) ;; Nested cast expression
 
 
-global i32* bitcast (float* @4 to i32*)   ;; Forward numeric reference
-global float* @4                       ;; Duplicate forward numeric reference
-global float 0.0
+@2 = global i32* bitcast (float* @4 to i32*)   ;; Forward numeric reference
+@3 = global float* @4                     ;; Duplicate forward numeric reference
+@4 = global float 0.0
 
 
 ;;---------------------------------------------------
 ;; Test constant getelementpr expressions for arrays
 ;;---------------------------------------------------
 
 @array  = constant [2 x i33] [ i33 12, i33 52 ]
 @arrayPtr = global i33* getelementptr ([2 x i33], [2 x i33]* @array, i64 0, i64 0)    ;; i33* &@array[0][0]

test/Integer/constpointer_bt.ll

 
 
 @t3 = global i40 * @t1           ;; Forward reference
 @t1 = global i40 4
 @t4 = global i40 ** @t3    ;; reference to reference
 
 @t2 = global i40 * @t1
 
-global float * @2                ;; Forward numeric reference
-global float * @2                ;; Duplicate forward numeric reference
-global float 0.0
-global float * @2                ;; Numeric reference
+@0 = global float * @2                ;; Forward numeric reference
+@1 = global float * @2                ;; Duplicate forward numeric reference
+@2 = global float 0.0
+@3 = global float * @2                ;; Numeric reference
 
 
 @fptr = global void() * @f       ;; Forward ref method defn
 declare void @"f"()               ;; External method
 
 @sptr1   = global [11x i8]* @somestr    ;; Forward ref to a constant
 @somestr = constant [11x i8] c"hello world"
 @sptr2   = global [11x i8]* @somestr
 
 

test/Linker/2003-08-28-TypeResolvesGlobal3.ll

 ; RUN: llvm-as < %s > %t.out1.bc
 ; RUN: echo "%M = type i32" | llvm-as > %t.out2.bc
 ; RUN: llvm-link %t.out2.bc %t.out1.bc
 
 %M = type opaque
 
 ; GLobal using the resolved function prototype
-global void (%M*)* @foo   ; <void (%M*)**>:0 [#uses=0]
+@0 = global void (%M*)* @foo    ; <void (%M*)**>:0 [#uses=0]
 
 define void @foo.upgrd.1(i32* %V) {
   ret void
 }
 
 declare void @foo(%M*)
 

test/Transforms/GlobalOpt/2007-05-13-Crash.ll

 ; RUN: opt < %s  -globalopt -disable-output
 
 target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64"
 target triple = "i686-apple-darwin8"
         %struct.SFLMutableListItem = type { i16 }
         %struct.__CFDictionary = type opaque
         %struct.__CFString = type opaque
         %struct.__builtin_CFString = type { i32*, i32, i8*, i32 }
 @_ZZ19SFLGetVisibilityKeyvE19_kSFLLVisibilityKey = internal global %struct.__CFString* null             ; <%struct.__CFString**> [#uses=2]
 @_ZZ22SFLGetAlwaysVisibleKeyvE22_kSFLLAlwaysVisibleKey = internal global %struct.__CFString* null               ; <%struct.__CFString**> [#uses=7]
-internal constant %struct.__builtin_CFString {
+@0 = internal constant %struct.__builtin_CFString {
     i32* getelementptr ([0 x i32], [0 x i32]* @__CFConstantStringClassReference, i32 0, i32 0), 
     i32 1992, 
     i8* getelementptr ([14 x i8], [14 x i8]* @.str, i32 0, i32 0), 
     i32 13 }, section "__DATA,__cfstring"               ; <%struct.__builtin_CFString*>:0 [#uses=1]
 @__CFConstantStringClassReference = external global [0 x i32]           ; <[0 x i32]*> [#uses=1]
 @.str = internal constant [14 x i8] c"AlwaysVisible\00"         ; <[14 x i8]*> [#uses=1]
 @_ZZ21SFLGetNeverVisibleKeyvE21_kSFLLNeverVisibleKey = internal global %struct.__CFString* null         ; <%struct.__CFString**> [#uses=2]
 

test/Transforms/GlobalOpt/2009-03-06-Anonymous.ll

 ; RUN: opt < %s -globalopt -S | FileCheck %s
 
-global i32 0
+@0 = global i32 0
 ; CHECK-DAG: @0 = internal global i32 0
 
-private global i32 0
+@1 = private global i32 0
 ; CHECK-DAG: @1 = private global i32 0
 
 define i32* @2() {
   ret i32* @0
 }
 ; CHECK-DAG: define internal fastcc i32* @2()
 
 define i32* @f() {