Page MenuHomePhabricator

[OpenCL] Fix pipe type dump.
ClosedPublic

Authored by pxli168 on Apr 26 2016, 1:41 AM.

Details

Summary

Fix the dump of PipeType.
Now we will have "pipe int" and element type.

Diff Detail

Repository
rL LLVM

Event Timeline

pxli168 updated this revision to Diff 54971.Apr 26 2016, 1:41 AM
pxli168 retitled this revision from to [OpenCL] Fix pipe type dump..
pxli168 updated this object.
pxli168 added reviewers: Anastasia, yaxunl.
pxli168 added subscribers: bader, cfe-commits.
bader added a comment.Apr 26 2016, 2:05 AM

LGTM.
Probably it would be forth to add a simple test.

Anastasia edited edge metadata.Apr 26 2016, 7:49 AM

Do you think we could add a test? For example similar to test/Misc/ast-dump-decl.c. We could have it for now in test/SemaOpenCL folder.

I will add a test and send a new version.

pxli168 updated this revision to Diff 55161.Apr 26 2016, 9:57 PM
pxli168 edited edge metadata.

Add test and fix some old test.

Anastasia accepted this revision.Apr 27 2016, 12:06 PM
Anastasia edited edge metadata.

LGTM! Thanks!

This revision is now accepted and ready to land.Apr 27 2016, 12:06 PM
This revision was automatically updated to reflect the committed changes.