Index: include/clang/Basic/DiagnosticSemaKinds.td =================================================================== --- include/clang/Basic/DiagnosticSemaKinds.td +++ include/clang/Basic/DiagnosticSemaKinds.td @@ -5764,6 +5764,9 @@ "cannot cast %0 to %1 via virtual base %2">; def err_downcast_from_inaccessible_base : Error< "cannot cast %select{private|protected}2 base class %1 to %0">; +def ext_ms_downcast_from_inaccessible_base : ExtWarn< + "cast %select{private|protected}2 base class %1 to %0 is a Microsoft extension">, + InGroup; def err_upcast_to_inaccessible_base : Error< "cannot cast %0 to its %select{private|protected}2 base class %1">; def err_bad_dynamic_cast_not_ref_or_ptr : Error< Index: lib/Sema/SemaCast.cpp =================================================================== --- lib/Sema/SemaCast.cpp +++ lib/Sema/SemaCast.cpp @@ -1344,10 +1344,11 @@ } if (!CStyle) { - switch (Self.CheckBaseClassAccess(OpRange.getBegin(), - SrcType, DestType, - Paths.front(), - diag::err_downcast_from_inaccessible_base)) { + unsigned Diag = Self.getLangOpts().MSVCCompat + ? diag::ext_ms_downcast_from_inaccessible_base + : diag::err_downcast_from_inaccessible_base; + switch (Self.CheckBaseClassAccess(OpRange.getBegin(), SrcType, DestType, + Paths.front(), Diag)) { case Sema::AR_accessible: case Sema::AR_delayed: // be optimistic case Sema::AR_dependent: // be optimistic Index: test/SemaCXX/ext_ms_downcast.cpp =================================================================== --- /dev/null +++ test/SemaCXX/ext_ms_downcast.cpp @@ -0,0 +1,40 @@ +// RUN: %clang_cc1 -fsyntax-only -fms-compatibility -verify %s +// RUN: %clang_cc1 -fsyntax-only -DNO_MS_COMPATIBILITY -verify %s + +// Minimal reproducer. +class A {}; +class B : A {}; // expected-note 2 {{implicitly declared private here}} + +B* foo(A* p) { + return static_cast(p); +#ifdef NO_MS_COMPATIBILITY + // expected-error@-2 {{cannot cast private base class 'A' to 'B'}} +#else + // expected-warning@-4 {{cast private base class 'A' to 'B' is a Microsoft extension}} +#endif +} + +A* bar(B* p) { + return static_cast(p); // expected-error {{cannot cast 'B' to its private base class 'A'}} +} + +// from atlframe.h +template +class CUpdateUI { +public: + CUpdateUI() { + T* pT = static_cast(this); +#ifdef NO_MS_COMPATIBILITY + // expected-error@-2 {{cannot cast private base class}} +#else + // expected-warning@-4 {{cast private base class 'CUpdateUI' to 'CMDIFrame' is a Microsoft extension}} +#endif + } +}; + +// from sample WTL/MDIDocVw (mainfrm.h +class CMDIFrame : CUpdateUI {}; +// expected-note@-1 {{implicitly declared private here}} +// expected-note@-2 {{in instantiation of member function}} + +CMDIFrame wndMain;