Page MenuHomePhabricator

Fix incorrect redundant expression in target AMDGPU.
ClosedPublic

Authored by etienneb on Apr 23 2016, 12:16 PM.

Details

Summary

The expression is detected as a redundant expression.
Turn out, this is probably a bug.

/home/etienneb/llvm/llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:306:26: warning: both side of operator are equivalent [misc-redundant-expression]
  if (isSMRD(*FirstLdSt) && isSMRD(*FirstLdSt)) {

Diff Detail

Event Timeline

etienneb updated this revision to Diff 54787.Apr 23 2016, 12:16 PM
etienneb retitled this revision from to Fix incorrect redundant expresion in target AMDGPU..
etienneb updated this object.
etienneb added a reviewer: rnk.
etienneb added a subscriber: cfe-commits.
etienneb retitled this revision from Fix incorrect redundant expresion in target AMDGPU. to Fix incorrect redundant expression in target AMDGPU..Apr 23 2016, 12:28 PM
etienneb edited edge metadata.
tstellarAMD accepted this revision.Apr 25 2016, 7:02 AM
tstellarAMD edited edge metadata.

Thanks for catching this.

This revision is now accepted and ready to land.Apr 25 2016, 7:02 AM
etienneb closed this revision.Apr 25 2016, 8:12 AM