Page MenuHomePhabricator

[AMDGPU] prohibit >4 bytes private memory access.
AbandonedPublic

Authored by vpykhtin on Apr 21 2016, 10:03 AM.

Details

Reviewers
None
Summary

Fixes mlopen 5x5 case.

This is a preview, not for submitting.

Failed tests:

LLVM :: CodeGen/AMDGPU/indirect-private-64.ll
LLVM :: CodeGen/AMDGPU/insert_vector_elt.ll
LLVM :: CodeGen/AMDGPU/private-element-size.ll

Diff Detail

Event Timeline

vpykhtin updated this revision to Diff 54521.Apr 21 2016, 10:03 AM
vpykhtin retitled this revision from to [AMDGPU] prohibit >4 bytes private memory access. .
vpykhtin updated this object.
vpykhtin updated this object.Apr 21 2016, 10:04 AM
vpykhtin edited edge metadata.

If this fixes correctness issue, commit please. Optimization can come after, if not along.

If this fixes correctness issue, commit please. Optimization can come after, if not along.

I think what Matt suggests is more reasonable here. I would wait for his patch.

tstellarAMD resigned from this revision.May 2 2016, 7:15 AM
tstellarAMD removed a reviewer: tstellarAMD.
vpykhtin abandoned this revision.Jul 28 2016, 8:19 AM