Page MenuHomePhabricator

Enable stack-use-after-scope tests
ClosedPublic

Authored by vitalybuka on Apr 20 2016, 6:06 PM.

Details

Summary

Fix and enable working stack-use-after-scope tests.
Add more failing tests for the feature, for fix later.

https://llvm.org/bugs/show_bug.cgi?id=27453

Diff Detail

Event Timeline

vitalybuka updated this revision to Diff 54448.Apr 20 2016, 6:06 PM
vitalybuka retitled this revision from to Enable stack-use-after-scope tests.
vitalybuka updated this object.
vitalybuka added reviewers: kcc, aizatsky.
vitalybuka added a subscriber: llvm-commits.
aizatsky accepted this revision.Apr 21 2016, 1:17 PM
aizatsky edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2016, 1:17 PM
eugenis added inline comments.Apr 21 2016, 1:25 PM
test/asan/TestCases/use-after-scope-dtor-order.cc
11

why are you removing the file name?

test/asan/TestCases/use-after-scope-if.cc
2

-asan-use-after-scope=1 for consistency

test/asan/TestCases/use-after-scope-loop.cc
2

-asan-use-after-scope=1

vitalybuka updated this object.Apr 21 2016, 2:01 PM
vitalybuka edited edge metadata.
vitalybuka updated this revision to Diff 54576.Apr 21 2016, 2:15 PM
vitalybuka marked 2 inline comments as done.

Changed to -asan-use-after-scope=1

vitalybuka requested a review of this revision.Apr 21 2016, 2:15 PM
vitalybuka edited edge metadata.
vitalybuka added inline comments.
test/asan/TestCases/use-after-scope-dtor-order.cc
11

Probability that we hit same function and line number but in different filename is minimal.
So filename is redundant here.
My understanding is that these are tests for the check, but not for output format. So we should limit hard-coding output format and check only essential stuff.

Please take another look and land if possible.

eugenis accepted this revision.Apr 21 2016, 5:16 PM
eugenis edited edge metadata.

LGTM

This revision is now accepted and ready to land.Apr 21 2016, 5:16 PM
eugenis closed this revision.Apr 21 2016, 5:16 PM

r267084