Page MenuHomePhabricator

Maintain register numbering across xml include features
ClosedPublic

Authored by fjricci on Apr 19 2016, 5:24 PM.

Details

Summary

If the remote uses include features when communicating
xml register info back to lldb, the existing code would reset the
lldb register index at the beginning of each include node.
This would lead to multiple registers having the same lldb register index.
Since the lldb register numbers should be contiguous and unique,
maintain them accross the parsing of all of the xml feature nodes.

Diff Detail

Repository
rL LLVM

Event Timeline

fjricci updated this revision to Diff 54298.Apr 19 2016, 5:24 PM
fjricci retitled this revision from to Maintain register numbering across xml include features.
fjricci updated this object.
fjricci added reviewers: jingham, clayborg, jasonmolenda.
fjricci added subscribers: sas, lldb-commits.
clayborg accepted this revision.Apr 19 2016, 5:38 PM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Apr 19 2016, 5:38 PM
This revision was automatically updated to reflect the committed changes.