Index: include/llvm/Analysis/AliasSetTracker.h =================================================================== --- include/llvm/Analysis/AliasSetTracker.h +++ include/llvm/Analysis/AliasSetTracker.h @@ -59,8 +59,12 @@ return &NextInList; } - void updateSizeAndAAInfo(uint64_t NewSize, const AAMDNodes &NewAAInfo) { - if (NewSize > Size) Size = NewSize; + bool updateSizeAndAAInfo(uint64_t NewSize, const AAMDNodes &NewAAInfo) { + bool SizeChanged = false; + if (NewSize > Size) { + Size = NewSize; + SizeChanged = true; + } if (AAInfo == DenseMapInfo::getEmptyKey()) // We don't have a AAInfo yet. Set it to NewAAInfo. @@ -68,6 +72,8 @@ else if (AAInfo != NewAAInfo) // NewAAInfo conflicts with AAInfo. AAInfo = DenseMapInfo::getTombstoneKey(); + + return SizeChanged; } uint64_t getSize() const { return Size; } Index: lib/Analysis/AliasSetTracker.cpp =================================================================== --- lib/Analysis/AliasSetTracker.cpp +++ lib/Analysis/AliasSetTracker.cpp @@ -274,7 +274,14 @@ // Check to see if the pointer is already known. if (Entry.hasAliasSet()) { - Entry.updateSizeAndAAInfo(Size, AAInfo); + // If the size changed, we may need to merge several alias sets. + // Use findAliasSetForPointer for its merging side effect. + // Note that we can *not* return the result of findAliasSetForPointer + // due to a quirk of alias analysis behavior. Since alias(undef, undef) + // is NoAlias, findAliasSetForPointer(undef, ...) will not find the + // the right set for undef, even if it exists. + if (Entry.updateSizeAndAAInfo(Size, AAInfo)) + findAliasSetForPointer(Pointer, Size, AAInfo); // Return the set! return *Entry.getAliasSet(*this)->getForwardedTarget(*this); } Index: test/Transforms/LICM/pr27262.ll =================================================================== --- test/Transforms/LICM/pr27262.ll +++ test/Transforms/LICM/pr27262.ll @@ -0,0 +1,33 @@ +; RUN: opt -S -basicaa -licm < %s | FileCheck %s + +target datalayout = "e-m:x-p:32:32-i64:64-f80:32-n8:16:32-a:0:32-S32" +target triple = "i686-pc-windows-msvc18.0.0" + +; Make sure the store to v is not sunk past the memset +; CHECK-LABEL: @main +; CHECK: for.body: +; CHECK-NEXT: store i8 1, i8* %p +; CHECK-NEXT: store i8 2, i8* %p1 +; CHECK-NEXT: call void @llvm.memset +; CHECK: end: +; CHECK-NEXT: ret i32 0 + +define i32 @main(i1 %k, i8* %p) { +entry: + %p1 = getelementptr i8, i8* %p, i32 1 + br label %for.body + +for.body: + store i8 1, i8* %p, align 1 + store i8 2, i8* %p1, align 1 + call void @llvm.memset.p0i8.i32(i8* %p, i8 255, i32 4, i32 1, i1 false) + br label %for.latch + +for.latch: + br i1 %k, label %for.body, label %end + +end: + ret i32 0 +} + +declare void @llvm.memset.p0i8.i32(i8* nocapture, i8, i32, i32, i1)